propagate changes through slots with props (#4091)

pull/4101/head
Timothy Johnson 5 years ago committed by Conduitry
parent f9a9484e39
commit 2cd5c2934b

@ -182,11 +182,9 @@ export default class InlineComponentWrapper extends Wrapper {
});
});
const non_let_dependencies = Array.from(fragment_dependencies).filter(name => !this.node.scope.is_let(name));
const dynamic_attributes = this.node.attributes.filter(a => a.get_dependencies().length > 0);
if (!uses_spread && (dynamic_attributes.length > 0 || this.node.bindings.length > 0 || non_let_dependencies.length > 0)) {
if (!uses_spread && (dynamic_attributes.length > 0 || this.node.bindings.length > 0 || fragment_dependencies.size > 0)) {
updates.push(b`const ${name_changes} = {};`);
}
@ -266,9 +264,9 @@ export default class InlineComponentWrapper extends Wrapper {
}
}
if (non_let_dependencies.length > 0) {
if (fragment_dependencies.size > 0) {
updates.push(b`
if (${renderer.dirty(non_let_dependencies)}) {
if (${renderer.dirty(Array.from(fragment_dependencies))}) {
${name_changes}.$$scope = { dirty: #dirty, ctx: #ctx };
}`);
}

@ -0,0 +1,5 @@
<script>
export let prop
</script>
<slot value={prop} />

@ -0,0 +1,12 @@
export default {
props: {
prop: 'a',
},
html: 'a',
test({ assert, component, target }) {
component.prop = 'b';
assert.htmlEqual( target.innerHTML, 'b' );
}
};

@ -0,0 +1,10 @@
<script>
import Outer from './Outer.svelte'
import Inner from './Inner.svelte'
export let prop
</script>
<Outer {prop} let:value>
<Inner>{value}</Inner>
</Outer>
Loading…
Cancel
Save