diff --git a/.changeset/serious-goats-tap.md b/.changeset/serious-goats-tap.md new file mode 100644 index 0000000000..b746f1fa69 --- /dev/null +++ b/.changeset/serious-goats-tap.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: make `$effect.active()` true when updating deriveds diff --git a/packages/svelte/src/internal/client/reactivity/effects.js b/packages/svelte/src/internal/client/reactivity/effects.js index 823c9dbc7c..1724a19ed7 100644 --- a/packages/svelte/src/internal/client/reactivity/effects.js +++ b/packages/svelte/src/internal/client/reactivity/effects.js @@ -26,7 +26,8 @@ import { EFFECT_RAN, BLOCK_EFFECT, ROOT_EFFECT, - EFFECT_TRANSPARENT + EFFECT_TRANSPARENT, + DERIVED } from '../constants.js'; import { set } from './sources.js'; import { remove } from '../dom/reconciler.js'; @@ -118,7 +119,9 @@ function create_effect(type, fn, sync) { * @returns {boolean} */ export function effect_active() { - return current_effect ? (current_effect.f & (BRANCH_EFFECT | ROOT_EFFECT)) === 0 : false; + if (current_effect) return (current_effect.f & (BRANCH_EFFECT | ROOT_EFFECT)) === 0; + if (current_reaction) return (current_reaction.f & DERIVED) !== 0; + return false; } /** diff --git a/packages/svelte/tests/runtime-runes/samples/effect-active-derived/_config.js b/packages/svelte/tests/runtime-runes/samples/effect-active-derived/_config.js new file mode 100644 index 0000000000..7a6929a9bb --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/effect-active-derived/_config.js @@ -0,0 +1,13 @@ +import { flushSync } from 'svelte'; +import { test } from '../../test'; + +export default test({ + html: ``, + + test({ assert, target }) { + const btn = target.querySelector('button'); + flushSync(() => btn?.click()); + + assert.htmlEqual(target.innerHTML, `
bar is true
`); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/effect-active-derived/main.svelte b/packages/svelte/tests/runtime-runes/samples/effect-active-derived/main.svelte new file mode 100644 index 0000000000..63ff4d48bf --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/effect-active-derived/main.svelte @@ -0,0 +1,12 @@ + + + + +{#if bar} +bar is true
+{/if}