Merge pull request #71 from sveltejs/gh-63

handle empty attributes in elements and components
pull/76/head
Rich Harris 9 years ago committed by GitHub
commit 1de87945db

@ -16,6 +16,13 @@ export default function addComponentAttributes ( generator, node, local ) {
});
}
else if ( attribute.value.length === 0 ) {
local.staticAttributes.push({
name: attribute.name,
value: `''`
});
}
else if ( attribute.value.length === 1 ) {
const value = attribute.value[0];

@ -31,6 +31,18 @@ export default function addElementAttributes ( generator, node, local ) {
}
}
else if ( attribute.value.length === 0 ) {
if ( propertyName ) {
local.init.push( deindent`
${local.name}.${propertyName} = '';
` );
} else {
local.init.push( deindent`
${local.name}.setAttribute( '${attribute.name}', '' );
` );
}
}
else if ( attribute.value.length === 1 ) {
const value = attribute.value[0];

@ -0,0 +1,7 @@
export default {
html: `
<svg>
<g class=''></g>
</svg>
`
};

@ -0,0 +1,3 @@
<svg>
<g class=''></g>
</svg>

After

Width:  |  Height:  |  Size: 31 B

@ -0,0 +1,3 @@
export default {
html: `<div class=""></div>`
};

@ -0,0 +1,3 @@
export default {
html: `<div><p>foo: ''</p></div>`
};

@ -0,0 +1,11 @@
<div>
<Widget foo=''/>
</div>
<script>
import Widget from './Widget.html';
export default {
components: { Widget }
};
</script>
Loading…
Cancel
Save