#6299 - Throw a compile error when passing an empty directive name (#6300)

* Compile error when passing empty directive names

* Revert "Compile error when passing empty directive names"

This reverts commit ac8718b3a4.

* Compile error when passing empty directive names

* Adjust empty-directive-name error offset
pull/6467/head
Mohammed Al-Qurafi 3 years ago committed by GitHub
parent 2357e642e3
commit 1b33248ead
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -385,6 +385,13 @@ function read_attribute(parser: Parser, unique_names: Set<string>) {
if (type) {
const [directive_name, ...modifiers] = name.slice(colon_index + 1).split('|');
if (directive_name === '') {
parser.error({
code: 'empty-directive-name',
message: `${type} name cannot be empty`
}, start + colon_index + 1);
}
if (type === 'Binding' && directive_name !== 'this') {
check_unique(directive_name);
} else if (type !== 'EventHandler' && type !== 'Action') {
@ -398,13 +405,6 @@ function read_attribute(parser: Parser, unique_names: Set<string>) {
}, start);
}
if (type === 'Class' && directive_name === '') {
parser.error({
code: 'invalid-class-directive',
message: 'Class binding name cannot be empty'
}, start + colon_index + 1);
}
if (value[0]) {
if ((value as any[]).length > 1 || value[0].type === 'Text') {
parser.error({

@ -1,6 +1,6 @@
{
"code": "invalid-class-directive",
"message": "Class binding name cannot be empty",
"code": "empty-directive-name",
"message": "Class name cannot be empty",
"start": {
"line": 1,
"column": 10,

@ -0,0 +1,10 @@
{
"code": "empty-directive-name",
"message": "Action name cannot be empty",
"start": {
"line": 1,
"column": 8,
"character": 8
},
"pos": 8
}
Loading…
Cancel
Save