From 1b2cf3ee7622cb9e484f50a25aa3e90d47205e59 Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Fri, 26 Jul 2024 18:21:03 +0200 Subject: [PATCH] chore: unskip more tests --- .../samples/supports-nested-page/_config.js | 6 ------ .../escaped-css/_config.js | 1 - .../action-update-before-destroy/_config.js | 20 ++++--------------- .../samples/animation-css/_config.js | 17 ++++++++-------- .../samples/before-render-chain/_config.js | 2 +- .../dev-warning-readonly-computed/_config.js | 4 +--- .../_config.js | 6 +----- .../main.svelte | 2 +- .../_config.js | 1 - .../_config.js | 1 - 10 files changed, 16 insertions(+), 44 deletions(-) delete mode 100644 packages/svelte/tests/css/samples/supports-nested-page/_config.js diff --git a/packages/svelte/tests/css/samples/supports-nested-page/_config.js b/packages/svelte/tests/css/samples/supports-nested-page/_config.js deleted file mode 100644 index 148da9b2ee..0000000000 --- a/packages/svelte/tests/css/samples/supports-nested-page/_config.js +++ /dev/null @@ -1,6 +0,0 @@ -import { test } from '../../test'; - -export default test({ - // TODO JSDOM doesn't support container queries - skip: true -}); diff --git a/packages/svelte/tests/runtime-browser/custom-elements-samples/escaped-css/_config.js b/packages/svelte/tests/runtime-browser/custom-elements-samples/escaped-css/_config.js index 9ecebdea47..0cbfd63821 100644 --- a/packages/svelte/tests/runtime-browser/custom-elements-samples/escaped-css/_config.js +++ b/packages/svelte/tests/runtime-browser/custom-elements-samples/escaped-css/_config.js @@ -2,7 +2,6 @@ import { test } from '../../assert'; const tick = () => Promise.resolve(); export default test({ - skip: true, // TODO: needs inline CSS, decide how to add async test({ assert, target }) { target.innerHTML = ''; await tick(); diff --git a/packages/svelte/tests/runtime-legacy/samples/action-update-before-destroy/_config.js b/packages/svelte/tests/runtime-legacy/samples/action-update-before-destroy/_config.js index 328d67cb2c..2411936d9c 100644 --- a/packages/svelte/tests/runtime-legacy/samples/action-update-before-destroy/_config.js +++ b/packages/svelte/tests/runtime-legacy/samples/action-update-before-destroy/_config.js @@ -2,28 +2,16 @@ import { flushSync } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, // TODO: needs fixing - html: `
1
`, - async test({ assert, target, window }) { + async test({ assert, target, logs }) { const button = target.querySelector('button'); - const event = new window.MouseEvent('click'); - /** - * @type {any[]} - */ - const messages = []; - const log = console.log; - console.log = (msg) => messages.push(msg); - flushSync(() => { - // @ts-ignore - button.dispatchEvent(event); - }); + button?.click(); + flushSync(); - console.log = log; - assert.deepEqual(messages, ['afterUpdate', 'onDestroy']); + assert.deepEqual(logs, ['afterUpdate', 'onDestroy']); } }); diff --git a/packages/svelte/tests/runtime-legacy/samples/animation-css/_config.js b/packages/svelte/tests/runtime-legacy/samples/animation-css/_config.js index 848da78b2d..b6b601a96b 100644 --- a/packages/svelte/tests/runtime-legacy/samples/animation-css/_config.js +++ b/packages/svelte/tests/runtime-legacy/samples/animation-css/_config.js @@ -1,9 +1,6 @@ -// @ts-nocheck import { test } from '../../test'; export default test({ - skip: true, // TODO: needs fixing - get props() { return { things: [ @@ -27,7 +24,9 @@ export default test({ test({ assert, component, target, raf }) { let divs = target.querySelectorAll('div'); divs.forEach((div) => { + // @ts-expect-error div.getBoundingClientRect = function () { + // @ts-expect-error const index = [...this.parentNode.children].indexOf(this); const top = index * 30; @@ -49,13 +48,13 @@ export default test({ ]; divs = target.querySelectorAll('div'); - assert.ok(~divs[0].style.animation.indexOf('__svelte')); - assert.equal(divs[1].style.animation, ''); - assert.equal(divs[2].style.animation, ''); - assert.equal(divs[3].style.animation, ''); - assert.ok(~divs[4].style.animation.indexOf('__svelte')); + assert.ok(divs[0].getAnimations().length > 0); + assert.equal(divs[1].getAnimations().length, 0); + assert.equal(divs[2].getAnimations().length, 0); + assert.equal(divs[3].getAnimations().length, 0); + assert.ok(divs[4].getAnimations().length > 0); raf.tick(100); - assert.deepEqual([divs[0].style.animation, divs[4].style.animation], ['', '']); + assert.deepEqual([divs[0].getAnimations().length, divs[4].getAnimations().length], [0, 0]); } }); diff --git a/packages/svelte/tests/runtime-legacy/samples/before-render-chain/_config.js b/packages/svelte/tests/runtime-legacy/samples/before-render-chain/_config.js index c21b68106d..9364bd9f9e 100644 --- a/packages/svelte/tests/runtime-legacy/samples/before-render-chain/_config.js +++ b/packages/svelte/tests/runtime-legacy/samples/before-render-chain/_config.js @@ -1,7 +1,7 @@ import { test } from '../../test'; export default test({ - skip: true, // TODO: needs fixing + mode: ['client', 'hydrate'], html: ` 3 diff --git a/packages/svelte/tests/runtime-legacy/samples/dev-warning-readonly-computed/_config.js b/packages/svelte/tests/runtime-legacy/samples/dev-warning-readonly-computed/_config.js index 333ad48ba5..8606f012b4 100644 --- a/packages/svelte/tests/runtime-legacy/samples/dev-warning-readonly-computed/_config.js +++ b/packages/svelte/tests/runtime-legacy/samples/dev-warning-readonly-computed/_config.js @@ -1,8 +1,6 @@ import { test } from '../../test'; export default test({ - skip: true, // TODO: needs fixing, error message is wrong - compileOptions: { dev: true }, @@ -17,7 +15,7 @@ export default test({ throw new Error('Expected an error'); } catch (err) { // @ts-ignore - assert.equal(err.message, "
: Cannot set read-only property 'foo'"); + assert.equal(err.message, 'Cannot set property foo of # which has only a getter'); } } }); diff --git a/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/_config.js b/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/_config.js index 12a0960d87..136dc92f54 100644 --- a/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/_config.js +++ b/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/_config.js @@ -1,11 +1,7 @@ import { test } from '../../test'; export default test({ - // This is skipped for now, because it's not clear how to make this work on client-side initial run: - // The anchor isn't connected to its parent at the time we can do a runtime check for the namespace, and we - // need the parent for this check. (this didn't work in Svelte 4 either) - skip: true, - html: '', + html: '', test({ assert, target }) { const svg = target.querySelector('svg'); diff --git a/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/main.svelte b/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/main.svelte index 00069f711c..9d190b7b2d 100644 --- a/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/main.svelte +++ b/packages/svelte/tests/runtime-legacy/samples/dynamic-element-svg-implicit-namespace/main.svelte @@ -5,6 +5,6 @@ export let path = 'path'; - + diff --git a/packages/svelte/tests/validator/samples/general-siblings-combinator-in-custom-element-selects-slot-fallback/_config.js b/packages/svelte/tests/validator/samples/general-siblings-combinator-in-custom-element-selects-slot-fallback/_config.js index 6bd925197f..307385cb57 100644 --- a/packages/svelte/tests/validator/samples/general-siblings-combinator-in-custom-element-selects-slot-fallback/_config.js +++ b/packages/svelte/tests/validator/samples/general-siblings-combinator-in-custom-element-selects-slot-fallback/_config.js @@ -1,7 +1,6 @@ import { test } from '../../test'; export default test({ - skip: true, compileOptions: { customElement: true } diff --git a/packages/svelte/tests/validator/samples/siblings-combinator-in-custom-element-selects-slot-fallback/_config.js b/packages/svelte/tests/validator/samples/siblings-combinator-in-custom-element-selects-slot-fallback/_config.js index 6bd925197f..307385cb57 100644 --- a/packages/svelte/tests/validator/samples/siblings-combinator-in-custom-element-selects-slot-fallback/_config.js +++ b/packages/svelte/tests/validator/samples/siblings-combinator-in-custom-element-selects-slot-fallback/_config.js @@ -1,7 +1,6 @@ import { test } from '../../test'; export default test({ - skip: true, compileOptions: { customElement: true }