From bba3ffed0e7ed0c417df0cb8414eea2b96758a8a Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=B8rgen=20Kalsnes=20Hagen?= <43886029+Snailedlt@users.noreply.github.com> Date: Thu, 3 Nov 2022 09:43:39 +0100 Subject: [PATCH 1/4] [chore] Update link to feature request template (#7992) --- CONTRIBUTING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index 816faf31aa..6153ae25d9 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -65,7 +65,7 @@ Working on your first Pull Request? You can learn how from this free video serie ### Proposing a change -If you would like to request a new feature or enhancement but are not yet thinking about opening a pull request, you can also file an issue with [feature template](https://github.com/sveltejs/svelte/issues/new?template=feature_request.md). +If you would like to request a new feature or enhancement but are not yet thinking about opening a pull request, you can also file an issue with [feature template](https://github.com/sveltejs/svelte/issues/new?template=feature_request.yml). If you're only fixing a bug, it's fine to submit a pull request right away, but we still recommend that you file an issue detailing what you're fixing. This is helpful in case we don't accept that specific fix but want to keep track of the issue. From d39920fb102a66e0bc4301c7dd633ea748648e60 Mon Sep 17 00:00:00 2001 From: tomoam <29677552+tomoam@users.noreply.github.com> Date: Mon, 7 Nov 2022 18:15:25 +0900 Subject: [PATCH 2/4] [docs] fix link in November newsletter (#7998) --- .../blog/2022-11-01-whats-new-in-svelte-november-2022.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/site/content/blog/2022-11-01-whats-new-in-svelte-november-2022.md b/site/content/blog/2022-11-01-whats-new-in-svelte-november-2022.md index 0c909548af..1bd83afb2e 100644 --- a/site/content/blog/2022-11-01-whats-new-in-svelte-november-2022.md +++ b/site/content/blog/2022-11-01-whats-new-in-svelte-november-2022.md @@ -12,7 +12,7 @@ There's also a _huge_ showcase to cover... so let's jump in! ## What's new in SvelteKit - The new `update` method for `use:enhance` lets you easily get back the default form behavior while augmenting it with your own logic ([docs](https://kit.svelte.dev/docs/form-actions#progressive-enhancement-use-enhance), [#7083](https://github.com/sveltejs/kit/pull/7083) and [#7326](https://github.com/sveltejs/kit/pull/7326)) - `[[optional]]` parameters are now available for routing ([docs](https://kit.svelte.dev/docs/advanced-routing#optional-parameters), [#7051](https://github.com/sveltejs/kit/pull/7051)) -- `goto` now has `invalidateAll` to (re-)run all `load` functions belonging to the new active page ([docs](https://kit.svelte.dev/docs/modules#app-navigation-goto), [#7407](https://github.com/sveltejs/kit/pull/7407)) +- `goto` now has `invalidateAll` to (re-)run all `load` functions belonging to the new active page ([docs](https://kit.svelte.dev/docs/modules#$app-navigation-goto), [#7407](https://github.com/sveltejs/kit/pull/7407)) - `config.kit.paths.base` is now used in adapters looking for static assets - fixing 404 issues across `adapter-netlify`, `adapter-vercel`, `adapter-cloudflare`, and `adapter-cloudflare-workers` ([#4448](https://github.com/sveltejs/kit/pull/4448)) **Breaking changes:** From 84ea242666174a405d27a46e19d148d1ef622875 Mon Sep 17 00:00:00 2001 From: byt3r Date: Mon, 7 Nov 2022 14:09:01 +0200 Subject: [PATCH 3/4] [fix] check parentNode exists before removing child (#6910) Fixes #6037 --- src/runtime/internal/dom.ts | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/src/runtime/internal/dom.ts b/src/runtime/internal/dom.ts index e6b2c270df..ca76b11ab3 100644 --- a/src/runtime/internal/dom.ts +++ b/src/runtime/internal/dom.ts @@ -204,7 +204,9 @@ export function insert_hydration(target: NodeEx, node: NodeEx, anchor?: NodeEx) } export function detach(node: Node) { - node.parentNode.removeChild(node); + if (node.parentNode) { + node.parentNode.removeChild(node); + } } export function destroy_each(iterations, detaching) { From b05b684b95a5670968f83ae6868881f2231afa74 Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Mon, 7 Nov 2022 13:09:53 +0100 Subject: [PATCH 4/4] Update changelog --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 606645a7b0..491da451c4 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -2,6 +2,7 @@ ## Unreleased * Upgraded `css-tree` to `2.1.0` ([#7572](https://github.com/sveltejs/svelte/pull/7572)) +* Check if `parentNode` exists before removing child ([#6037](https://github.com/sveltejs/svelte/issues/6037)) ## 3.52.0