more tests, more unreachable code removed

src/validate/js/propValidators/components.ts

@@ -10,7 +10,6 @@ export default function components(validator: Validator, prop: Node) {
 			`The 'components' property must be an object literal`,
 			prop.start
 		);
-		return;
 	}
 
 	checkForDupes(validator, prop.value.properties);

src/validate/js/propValidators/computed.ts

@@ -14,7 +14,6 @@ export default function computed(validator: Validator, prop: Node) {
 			`The 'computed' property must be an object literal`,
 			prop.start
 		);
-		return;
 	}
 
 	checkForDupes(validator, prop.value.properties);
@@ -26,7 +25,6 @@ export default function computed(validator: Validator, prop: Node) {
 				`Computed properties can be function expressions or arrow function expressions`,
 				computation.value.start
 			);
-			return;
 		}
 
 		const params = computation.value.params;
@@ -36,7 +34,6 @@ export default function computed(validator: Validator, prop: Node) {
 				`A computed value must depend on at least one property`,
 				computation.value.start
 			);
-			return;
 		}
 
 		params.forEach((param: Node) => {

src/validate/js/propValidators/helpers.ts

@@ -10,7 +10,6 @@ export default function helpers(validator: Validator, prop: Node) {
 			`The 'helpers' property must be an object literal`,
 			prop.start
 		);
-		return;
 	}
 
 	checkForDupes(validator, prop.value.properties);

src/validate/js/propValidators/methods.ts

@@ -14,7 +14,6 @@ export default function methods(validator: Validator, prop: Node) {
 			`The 'methods' property must be an object literal`,
 			prop.start
 		);
-		return;
 	}
 
 	checkForAccessors(validator, prop.value.properties, 'Methods');

src/validate/js/propValidators/transitions.ts

@@ -9,7 +9,6 @@ export default function transitions(validator: Validator, prop: Node) {
 			`The 'transitions' property must be an object literal`,
 			prop.start
 		);
-		return;
 	}
 
 	checkForDupes(validator, prop.value.properties);

test/validator/samples/non-object-literal-components/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "The 'components' property must be an object literal",
+	"loc": {
+		"line": 3,
+		"column": 2
+	},
+	"pos": 29
+}]

test/validator/samples/non-object-literal-components/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		components: 'not an object literal'
+	};
+</script>

test/validator/samples/non-object-literal-helpers/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "The 'helpers' property must be an object literal",
+	"loc": {
+		"line": 3,
+		"column": 2
+	},
+	"pos": 29
+}]

test/validator/samples/non-object-literal-helpers/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		helpers: 'not an object literal'
+	};
+</script>

test/validator/samples/non-object-literal-methods/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "The 'methods' property must be an object literal",
+	"loc": {
+		"line": 3,
+		"column": 2
+	},
+	"pos": 29
+}]

test/validator/samples/non-object-literal-methods/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		methods: 'not an object literal'
+	};
+</script>

test/validator/samples/non-object-literal-transitions/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "The 'transitions' property must be an object literal",
+	"loc": {
+		"line": 3,
+		"column": 2
+	},
+	"pos": 29
+}]

test/validator/samples/non-object-literal-transitions/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		transitions: 'not an object literal'
+	};
+</script>

test/validator/samples/tag-invalid/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "tag name must be two or more words joined by the '-' character",
+	"loc": {
+		"line": 3,
+		"column": 7
+	},
+	"pos": 34
+}]

test/validator/samples/tag-invalid/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		tag: 'invalid'
+	};
+</script>

test/validator/samples/tag-non-string/errors.json

@@ -0,0 +1,8 @@
+[{
+	"message": "'tag' must be a string literal",
+	"loc": {
+		"line": 3,
+		"column": 7
+	},
+	"pos": 34
+}]

test/validator/samples/tag-non-string/input.html

@@ -0,0 +1,5 @@
+<script>
+	export default {
+		tag: 42
+	};
+</script>