From 150f745b6d39b1742c369deba0112e26e688f6a9 Mon Sep 17 00:00:00 2001
From: Simon H <5968653+dummdidumm@users.noreply.github.com>
Date: Tue, 14 Mar 2023 17:40:31 +0100
Subject: [PATCH] Apply suggestions from code review

---
 site/content/docs/04-run-time.md |  6 +++---
 src/runtime/internal/utils.ts    |  9 ++++-----
 test/utils/index.ts              | 24 ------------------------
 3 files changed, 7 insertions(+), 32 deletions(-)

diff --git a/site/content/docs/04-run-time.md b/site/content/docs/04-run-time.md
index e3928b6156..eafa5457d0 100644
--- a/site/content/docs/04-run-time.md
+++ b/site/content/docs/04-run-time.md
@@ -670,7 +670,7 @@ Animates a `blur` filter alongside an element's opacity.
 * `duration` (`number`, default 400) — milliseconds the transition lasts
 * `easing` (`function`, default `cubicInOut`) — an [easing function](/docs#run-time-svelte-easing)
 * `opacity` (`number`, default 0) - the opacity value to animate out to and in from
-* `amount` (`number|string`, default 5) - the size of the blur (support css units, for example: "4rem", numbers use px)
+* `amount` (`number | string`, default 5) - the size of the blur. Supports css units (for example: `"4rem"`). The default unit is `px`
 
 ```sv
 <script>
@@ -705,8 +705,8 @@ Animates the x and y positions and the opacity of an element. `in` transitions a
 * `delay` (`number`, default 0) — milliseconds before starting
 * `duration` (`number`, default 400) — milliseconds the transition lasts
 * `easing` (`function`, default `cubicOut`) — an [easing function](/docs#run-time-svelte-easing)
-* `x` (`number|string`, default 0) - the x offset to animate out to and in from
-* `y` (`number|string`, default 0) - the y offset to animate out to and in from
+* `x` (`number | string`, default 0) - the x offset to animate out to and in from
+* `y` (`number | string`, default 0) - the y offset to animate out to and in from
 * `opacity` (`number`, default 0) - the opacity value to animate out to and in from
 
 x and y use `px` by default but support css units, for example `x: '100vw'` or `y: '50%'`.
diff --git a/src/runtime/internal/utils.ts b/src/runtime/internal/utils.ts
index d75b38782d..9c41b2e81f 100644
--- a/src/runtime/internal/utils.ts
+++ b/src/runtime/internal/utils.ts
@@ -190,14 +190,13 @@ export function action_destroyer(action_result) {
 	return action_result && is_function(action_result.destroy) ? action_result.destroy : noop;
 }
 
-export function split_css_unit(value: number | string, fallback = 'px'): [number, string] {
+export function split_css_unit(value: number | string): [number, string] {
 	if (typeof value === 'number') {
-		return [value, fallback];
+		return [value, 'px'];
 	}
 	const split = value?.match?.(/^\s*(-?[\d.]+)([^\s]*)\s*$/);
 	if (split) {
-		return [parseFloat(split[1]), split[2] || fallback];
+		return [parseFloat(split[1]), split[2] || 'px'];
 	}
-	console.warn('Failed to split', value);
-	return [parseFloat(value), fallback];
+	return [parseFloat(value), 'px'];
 }
diff --git a/test/utils/index.ts b/test/utils/index.ts
index 77749335f3..37ba63b1c7 100644
--- a/test/utils/index.ts
+++ b/test/utils/index.ts
@@ -21,34 +21,10 @@ describe('utils', () => {
 			assert.deepEqual(split_css_unit('10'), [10, 'px']);
 		});
 
-		it('should use the fallback', () => {
-			assert.deepEqual(split_css_unit(100, '%'), [100, '%']);
-			assert.deepEqual(split_css_unit('100', '%'), [100, '%']);
-		});
-
 		it('should split the css notation into value and unit', () => {
 			assert.deepEqual(split_css_unit('-50%'), [-50, '%']);
 			assert.deepEqual(split_css_unit('0.1rem'), [0.1, 'rem']);
 			assert.deepEqual(split_css_unit('.1rem'), [0.1, 'rem']);
 		});
-
-		it('should complain for invalid input', () => {
-			const warnings = [];
-			const warn = console.warn;
-			console.warn = (...args) => {
-				warnings.push(args);
-			};
-
-			split_css_unit('calc(100vw - 10rem)');
-			split_css_unit(undefined);
-			assert.deepEqual(split_css_unit('100 %'), [100, 'px']);
-			assert.deepEqual(warnings, [
-				['Failed to split', 'calc(100vw - 10rem)'],
-				['Failed to split', undefined],
-				['Failed to split', '100 %']
-			]);
-
-			console.warn = warn;
-		});
 	});
 });