From 103f278cfcaeeca87448428dc9ffd77f2db7b124 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Sat, 5 May 2018 16:48:49 -0400 Subject: [PATCH] update tests --- src/compile/dom/Block.ts | 5 +- src/compile/nodes/Slot.ts | 14 ++- test/cli/samples/basic/expected/Main.js | 20 ++-- .../samples/custom-element/expected/Main.js | 24 ++--- test/cli/samples/dev/expected/Main.js | 20 ++-- .../samples/dir-sourcemap/expected/Main.js | 18 +--- .../dir-sourcemap/expected/Main.js.map | 2 +- .../samples/dir-sourcemap/expected/Widget.js | 20 ++-- .../dir-sourcemap/expected/Widget.js.map | 2 +- test/cli/samples/dir-subdir/expected/Main.js | 18 +--- .../dir-subdir/expected/widget/Widget.js | 20 ++-- test/cli/samples/dir/expected/Main.js | 18 +--- test/cli/samples/dir/expected/Widget.js | 20 ++-- test/cli/samples/globals/expected/Main.js | 24 ++--- .../samples/sourcemap-inline/expected/Main.js | 22 ++--- test/cli/samples/sourcemap/expected/Main.js | 20 ++-- .../samples/sourcemap/expected/Main.js.map | 2 +- test/cli/samples/store/expected/Main.js | 24 ++--- test/js/samples/action/expected-bundle.js | 16 +-- test/js/samples/action/expected.js | 8 +- .../bind-width-height/expected-bundle.js | 19 ++-- test/js/samples/bind-width-height/expected.js | 11 ++- .../expected-bundle.js | 18 ++-- .../expected.js | 12 +-- .../component-static-array/expected-bundle.js | 16 +-- .../component-static-array/expected.js | 8 +- .../expected-bundle.js | 16 +-- .../component-static-immutable/expected.js | 8 +- .../expected-bundle.js | 16 +-- .../component-static-immutable2/expected.js | 8 +- .../component-static/expected-bundle.js | 16 +-- test/js/samples/component-static/expected.js | 8 +- .../computed-collapsed-if/expected-bundle.js | 10 +- .../samples/computed-collapsed-if/expected.js | 2 - .../css-media-query/expected-bundle.js | 18 ++-- test/js/samples/css-media-query/expected.js | 10 +- .../expected-bundle.js | 22 ++--- .../css-shadow-dom-keyframes/expected.js | 14 +-- .../deconflict-builtins/expected-bundle.js | 39 +++----- .../samples/deconflict-builtins/expected.js | 29 +++--- .../deconflict-globals/expected-bundle.js | 10 +- .../js/samples/deconflict-globals/expected.js | 2 - .../expected-bundle.js | 18 ++-- .../expected.js | 12 +-- .../samples/do-use-dataset/expected-bundle.js | 22 ++--- test/js/samples/do-use-dataset/expected.js | 16 +-- .../expected-bundle.js | 22 ++--- .../dont-use-dataset-in-legacy/expected.js | 16 +-- .../expected-bundle.js | 18 ++-- .../dont-use-dataset-in-svg/expected.js | 12 +-- .../expected-bundle.js | 44 ++++----- .../each-block-changed-check/expected.js | 34 +++---- .../event-handlers-custom/expected-bundle.js | 16 +-- .../samples/event-handlers-custom/expected.js | 8 +- .../head-no-whitespace/expected-bundle.js | 14 +-- .../js/samples/head-no-whitespace/expected.js | 6 +- .../if-block-no-update/expected-bundle.js | 43 ++++---- .../js/samples/if-block-no-update/expected.js | 37 ++++--- .../if-block-simple/expected-bundle.js | 33 +++---- test/js/samples/if-block-simple/expected.js | 27 +++--- .../expected-bundle.js | 18 ++-- .../expected.js | 12 +-- .../expected-bundle.js | 18 ++-- .../inline-style-optimized-url/expected.js | 12 +-- .../inline-style-optimized/expected-bundle.js | 18 ++-- .../inline-style-optimized/expected.js | 12 +-- .../expected-bundle.js | 22 ++--- .../inline-style-unoptimized/expected.js | 16 +-- .../expected-bundle.js | 16 +-- .../input-without-blowback-guard/expected.js | 8 +- .../legacy-input-type/expected-bundle.js | 18 ++-- test/js/samples/legacy-input-type/expected.js | 10 +- .../samples/media-bindings/expected-bundle.js | 16 +-- test/js/samples/media-bindings/expected.js | 8 +- .../non-imported-component/expected-bundle.js | 22 ++--- .../non-imported-component/expected.js | 14 ++- .../samples/setup-method/expected-bundle.js | 10 +- test/js/samples/setup-method/expected.js | 2 - test/js/samples/svg-title/expected-bundle.js | 18 ++-- test/js/samples/svg-title/expected.js | 10 +- test/js/samples/title/expected-bundle.js | 10 +- test/js/samples/title/expected.js | 2 - .../expected-bundle.js | 97 ++++++++----------- .../use-elements-as-anchors/expected.js | 91 ++++++++--------- .../window-binding-scroll/expected-bundle.js | 18 ++-- .../samples/window-binding-scroll/expected.js | 10 +- .../samples/await-then-catch-if/main.html | 16 +-- 87 files changed, 576 insertions(+), 975 deletions(-) diff --git a/src/compile/dom/Block.ts b/src/compile/dom/Block.ts index d2193bc1b1..c9010cf702 100644 --- a/src/compile/dom/Block.ts +++ b/src/compile/dom/Block.ts @@ -34,7 +34,6 @@ export default class Block { intro: CodeBuilder; update: CodeBuilder; outro: CodeBuilder; - unmount: CodeBuilder; detachRaw: CodeBuilder; destroy: CodeBuilder; }; @@ -73,7 +72,6 @@ export default class Block { intro: new CodeBuilder(), update: new CodeBuilder(), outro: new CodeBuilder(), - unmount: new CodeBuilder(), detachRaw: new CodeBuilder(), destroy: new CodeBuilder(), }; @@ -161,7 +159,8 @@ export default class Block { this.builders.mount.addLine(`${this.autofocus}.focus();`); } - // minor hack – we need to ensure that any {{{triples}}} are detached first + // minor hack – we need to ensure that any {@html x} blocks are detached first + // (TODO: is this still necessary? or is there a neater approach?) this.builders.destroy.addBlockAtStart(this.builders.detachRaw.toString()); const properties = new CodeBuilder(); diff --git a/src/compile/nodes/Slot.ts b/src/compile/nodes/Slot.ts index 8515f3728a..7e55b02055 100644 --- a/src/compile/nodes/Slot.ts +++ b/src/compile/nodes/Slot.ts @@ -55,13 +55,12 @@ export default class Slot extends Element { if (needsAnchorAfter) block.addVariable(anchorAfter); let mountBefore = block.builders.mount.toString(); - let unmountBefore = block.builders.unmount.toString(); + let destroyBefore = block.builders.destroy.toString(); block.builders.create.pushCondition(`!${content_name}`); block.builders.hydrate.pushCondition(`!${content_name}`); block.builders.mount.pushCondition(`!${content_name}`); block.builders.update.pushCondition(`!${content_name}`); - block.builders.unmount.pushCondition(`!${content_name}`); block.builders.destroy.pushCondition(`!${content_name}`); this.children.forEach((child: Node) => { @@ -72,7 +71,6 @@ export default class Slot extends Element { block.builders.hydrate.popCondition(); block.builders.mount.popCondition(); block.builders.update.popCondition(); - block.builders.unmount.popCondition(); block.builders.destroy.popCondition(); const mountLeadin = block.builders.mount.toString() !== mountBefore @@ -101,30 +99,30 @@ export default class Slot extends Element { // so that it can be reinserted later // TODO so that this can work with public API, component._slotted should // be all fragments, derived from options.slots. Not === options.slots - const unmountLeadin = block.builders.unmount.toString() !== unmountBefore + const unmountLeadin = block.builders.destroy.toString() !== destroyBefore ? `else` : `if (${content_name})`; if (anchorBefore === 'null' && anchorAfter === 'null') { - block.builders.unmount.addBlock(deindent` + block.builders.destroy.addBlock(deindent` ${unmountLeadin} { @reinsertChildren(${parentNode}, ${content_name}); } `); } else if (anchorBefore === 'null') { - block.builders.unmount.addBlock(deindent` + block.builders.destroy.addBlock(deindent` ${unmountLeadin} { @reinsertBefore(${anchorAfter}, ${content_name}); } `); } else if (anchorAfter === 'null') { - block.builders.unmount.addBlock(deindent` + block.builders.destroy.addBlock(deindent` ${unmountLeadin} { @reinsertAfter(${anchorBefore}, ${content_name}); } `); } else { - block.builders.unmount.addBlock(deindent` + block.builders.destroy.addBlock(deindent` ${unmountLeadin} { @reinsertBetween(${anchorBefore}, ${anchorAfter}, ${content_name}); @detachNode(${anchorBefore}); diff --git a/test/cli/samples/basic/expected/Main.js b/test/cli/samples/basic/expected/Main.js index 6514bbbd31..dce010fb4c 100644 --- a/test/cli/samples/basic/expected/Main.js +++ b/test/cli/samples/basic/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -43,7 +43,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -82,8 +81,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -155,10 +153,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/custom-element/expected/Main.js b/test/cli/samples/custom-element/expected/Main.js index e92ada81cd..d1b96c9899 100644 --- a/test/cli/samples/custom-element/expected/Main.js +++ b/test/cli/samples/custom-element/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -16,11 +16,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -57,16 +57,11 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); assign(Main.prototype, { _mount(target, anchor) { target.insertBefore(this, anchor); - }, - - _unmount() { - this.parentNode.removeChild(this); } }); @@ -107,8 +102,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -180,10 +174,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/dev/expected/Main.js b/test/cli/samples/dev/expected/Main.js index 401307fe2e..a2da6346b6 100644 --- a/test/cli/samples/dev/expected/Main.js +++ b/test/cli/samples/dev/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u: function unmount() { - detachNode(p); - }, - - d: noop + d: function destroy(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -46,7 +46,6 @@ assign(Main.prototype, { set: setDev, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -158,10 +157,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } @@ -175,8 +170,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } diff --git a/test/cli/samples/dir-sourcemap/expected/Main.js b/test/cli/samples/dir-sourcemap/expected/Main.js index 7cdd41dd4a..b4a005c0ac 100644 --- a/test/cli/samples/dir-sourcemap/expected/Main.js +++ b/test/cli/samples/dir-sourcemap/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ import Widget from './Widget.html'; @@ -20,12 +20,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - widget._unmount(); - }, - - d() { - widget.destroy(false); + d(detach) { + widget.destroy(detach); } }; } @@ -62,7 +58,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -93,8 +88,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -166,10 +160,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/dir-sourcemap/expected/Main.js.map b/test/cli/samples/dir-sourcemap/expected/Main.js.map index cf890d4435..6e2eb7d0b0 100644 --- a/test/cli/samples/dir-sourcemap/expected/Main.js.map +++ b/test/cli/samples/dir-sourcemap/expected/Main.js.map @@ -1 +1 @@ -{"version":3,"file":"Main.js","sources":["../src/Main.html"],"sourcesContent":["\n\n"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;"} \ No newline at end of file +{"version":3,"file":"Main.js","sources":["../src/Main.html"],"sourcesContent":["\n\n"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;"} \ No newline at end of file diff --git a/test/cli/samples/dir-sourcemap/expected/Widget.js b/test/cli/samples/dir-sourcemap/expected/Widget.js index ad16d7aef5..28223fdd1c 100644 --- a/test/cli/samples/dir-sourcemap/expected/Widget.js +++ b/test/cli/samples/dir-sourcemap/expected/Widget.js @@ -1,4 +1,4 @@ -/* src/Widget.html generated by Svelte v2.3.0 */ +/* src/Widget.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -43,7 +43,6 @@ assign(Widget.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -82,8 +81,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -155,10 +153,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/dir-sourcemap/expected/Widget.js.map b/test/cli/samples/dir-sourcemap/expected/Widget.js.map index d007680a81..8d57bc3c9a 100644 --- a/test/cli/samples/dir-sourcemap/expected/Widget.js.map +++ b/test/cli/samples/dir-sourcemap/expected/Widget.js.map @@ -1 +1 @@ -{"version":3,"file":"Widget.js","sources":["../src/Widget.html"],"sourcesContent":["

widget

"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;"} \ No newline at end of file +{"version":3,"file":"Widget.js","sources":["../src/Widget.html"],"sourcesContent":["

widget

"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;"} \ No newline at end of file diff --git a/test/cli/samples/dir-subdir/expected/Main.js b/test/cli/samples/dir-subdir/expected/Main.js index 52c9caf092..1a595e80dd 100644 --- a/test/cli/samples/dir-subdir/expected/Main.js +++ b/test/cli/samples/dir-subdir/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ import Widget from './widget/Widget.html'; @@ -20,12 +20,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - widget._unmount(); - }, - - d() { - widget.destroy(false); + d(detach) { + widget.destroy(detach); } }; } @@ -62,7 +58,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -93,8 +88,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -166,10 +160,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/dir-subdir/expected/widget/Widget.js b/test/cli/samples/dir-subdir/expected/widget/Widget.js index 66543c808e..7ab7e73f96 100644 --- a/test/cli/samples/dir-subdir/expected/widget/Widget.js +++ b/test/cli/samples/dir-subdir/expected/widget/Widget.js @@ -1,4 +1,4 @@ -/* src/widget/Widget.html generated by Svelte v2.3.0 */ +/* src/widget/Widget.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -43,7 +43,6 @@ assign(Widget.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -82,8 +81,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -155,10 +153,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/dir/expected/Main.js b/test/cli/samples/dir/expected/Main.js index 77a56bf3bf..43ff753eca 100644 --- a/test/cli/samples/dir/expected/Main.js +++ b/test/cli/samples/dir/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ import Widget from './Widget.html'; @@ -20,12 +20,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - widget._unmount(); - }, - - d() { - widget.destroy(false); + d(detach) { + widget.destroy(detach); } }; } @@ -62,7 +58,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -93,8 +88,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -166,10 +160,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/dir/expected/Widget.js b/test/cli/samples/dir/expected/Widget.js index ecb3303e7d..9c62194627 100644 --- a/test/cli/samples/dir/expected/Widget.js +++ b/test/cli/samples/dir/expected/Widget.js @@ -1,4 +1,4 @@ -/* src/Widget.html generated by Svelte v2.3.0 */ +/* src/Widget.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -43,7 +43,6 @@ assign(Widget.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -82,8 +81,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -155,10 +153,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/globals/expected/Main.js b/test/cli/samples/globals/expected/Main.js index 2db0a261a2..968eb228fe 100644 --- a/test/cli/samples/globals/expected/Main.js +++ b/test/cli/samples/globals/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ var Main = (function(answer) { "use strict"; answer = (answer && answer.__esModule) ? answer["default"] : answer; @@ -30,11 +30,11 @@ var Main = (function(answer) { "use strict"; } }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -58,7 +58,6 @@ var Main = (function(answer) { "use strict"; set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -84,8 +83,6 @@ var Main = (function(answer) { "use strict"; node.parentNode.removeChild(node); } - function noop() {} - function init(component, options) { component._handlers = blankObject(); component._bind = options._bind; @@ -105,8 +102,7 @@ var Main = (function(answer) { "use strict"; this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -178,14 +174,12 @@ var Main = (function(answer) { "use strict"; this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } - function _unmount() { - if (this._fragment) this._fragment.u(); - } - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } + function noop() {} + function blankObject() { return Object.create(null); } diff --git a/test/cli/samples/sourcemap-inline/expected/Main.js b/test/cli/samples/sourcemap-inline/expected/Main.js index fe639ac270..3da16e1a57 100644 --- a/test/cli/samples/sourcemap-inline/expected/Main.js +++ b/test/cli/samples/sourcemap-inline/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -43,7 +43,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -82,8 +81,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -155,10 +153,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } @@ -171,4 +165,4 @@ function callAll(fns) { while (fns && fns.length) fns.shift()(); } export default Main; -//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiTWFpbi5qcyIsInNvdXJjZXMiOlsiLi4vc3JjL01haW4uaHRtbCJdLCJzb3VyY2VzQ29udGVudCI6WyI8cD5IZWxsbyB3b3JsZCE8L3A+XG5cbjxzY3JpcHQ+XG5cdGV4cG9ydCBkZWZhdWx0IHtcblx0XHRvbnJlbmRlciAoKSB7XG5cdFx0XHRjb25zb2xlLmxvZyggJ2hlcmUnICk7XG5cdFx0fVxuXHR9O1xuPC9zY3JpcHQ+Il0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiI7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7In0= +//# sourceMappingURL=data:application/json;charset=utf-8;base64,eyJ2ZXJzaW9uIjozLCJmaWxlIjoiTWFpbi5qcyIsInNvdXJjZXMiOlsiLi4vc3JjL01haW4uaHRtbCJdLCJzb3VyY2VzQ29udGVudCI6WyI8cD5IZWxsbyB3b3JsZCE8L3A+XG5cbjxzY3JpcHQ+XG5cdGV4cG9ydCBkZWZhdWx0IHtcblx0XHRvbnJlbmRlciAoKSB7XG5cdFx0XHRjb25zb2xlLmxvZyggJ2hlcmUnICk7XG5cdFx0fVxuXHR9O1xuPC9zY3JpcHQ+Il0sIm5hbWVzIjpbXSwibWFwcGluZ3MiOiI7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7Ozs7In0= diff --git a/test/cli/samples/sourcemap/expected/Main.js b/test/cli/samples/sourcemap/expected/Main.js index 4f303ce506..b44a4b2f27 100644 --- a/test/cli/samples/sourcemap/expected/Main.js +++ b/test/cli/samples/sourcemap/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var p; @@ -15,11 +15,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -43,7 +43,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -82,8 +81,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -155,10 +153,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } diff --git a/test/cli/samples/sourcemap/expected/Main.js.map b/test/cli/samples/sourcemap/expected/Main.js.map index 5133d81436..c8777bdd11 100644 --- a/test/cli/samples/sourcemap/expected/Main.js.map +++ b/test/cli/samples/sourcemap/expected/Main.js.map @@ -1 +1 @@ -{"version":3,"file":"Main.js","sources":["../src/Main.html"],"sourcesContent":["

Hello world!

\n\n"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;"} \ No newline at end of file +{"version":3,"file":"Main.js","sources":["../src/Main.html"],"sourcesContent":["

Hello world!

\n\n"],"names":[],"mappings":";;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;;"} \ No newline at end of file diff --git a/test/cli/samples/store/expected/Main.js b/test/cli/samples/store/expected/Main.js index 3588e60789..320a159497 100644 --- a/test/cli/samples/store/expected/Main.js +++ b/test/cli/samples/store/expected/Main.js @@ -1,4 +1,4 @@ -/* src/Main.html generated by Svelte v2.3.0 */ +/* src/Main.html generated by Svelte v2.4.4 */ function create_main_fragment(component, ctx) { var h1, text, text_1; @@ -22,11 +22,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(h1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(h1); + } + } }; } @@ -53,7 +53,6 @@ assign(Main.prototype, { set: set, _set: _set, _mount: _mount, - _unmount: _unmount, _differs: _differs }); @@ -79,8 +78,6 @@ function detachNode(node) { node.parentNode.removeChild(node); } -function noop() {} - function init(component, options) { component._handlers = blankObject(); component._bind = options._bind; @@ -104,8 +101,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -177,14 +173,12 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - function _differs(a, b) { return a != a ? b == b : a !== b || ((a && typeof a === 'object') || typeof a === 'function'); } +function noop() {} + function blankObject() { return Object.create(null); } diff --git a/test/js/samples/action/expected-bundle.js b/test/js/samples/action/expected-bundle.js index 4814e2fede..49e0372582 100644 --- a/test/js/samples/action/expected-bundle.js +++ b/test/js/samples/action/expected-bundle.js @@ -26,8 +26,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -116,10 +115,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -129,7 +124,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -167,11 +161,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(a); - }, + d(detach) { + if (detach) { + detachNode(a); + } - d() { if (typeof link_action.destroy === 'function') link_action.destroy.call(component); } }; diff --git a/test/js/samples/action/expected.js b/test/js/samples/action/expected.js index 199bf4dffe..f92f3723fe 100644 --- a/test/js/samples/action/expected.js +++ b/test/js/samples/action/expected.js @@ -34,11 +34,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(a); - }, + d(detach) { + if (detach) { + detachNode(a); + } - d() { if (typeof link_action.destroy === 'function') link_action.destroy.call(component); } }; diff --git a/test/js/samples/bind-width-height/expected-bundle.js b/test/js/samples/bind-width-height/expected-bundle.js index 0787252e8d..371f3d2843 100644 --- a/test/js/samples/bind-width-height/expected-bundle.js +++ b/test/js/samples/bind-width-height/expected-bundle.js @@ -58,8 +58,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -148,10 +147,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -161,7 +156,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -188,12 +182,13 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(div); - div_resize_listener.cancel(); - }, + d(detach) { + if (detach) { + detachNode(div); + } - d: noop + div_resize_listener.cancel(); + } }; } diff --git a/test/js/samples/bind-width-height/expected.js b/test/js/samples/bind-width-height/expected.js index 19014886a2..8d9b432ef0 100644 --- a/test/js/samples/bind-width-height/expected.js +++ b/test/js/samples/bind-width-height/expected.js @@ -22,12 +22,13 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(div); - div_resize_listener.cancel(); - }, + d(detach) { + if (detach) { + detachNode(div); + } - d: noop + div_resize_listener.cancel(); + } }; } diff --git a/test/js/samples/collapses-text-around-comments/expected-bundle.js b/test/js/samples/collapses-text-around-comments/expected-bundle.js index 383cf6d7fc..302c1c3aaf 100644 --- a/test/js/samples/collapses-text-around-comments/expected-bundle.js +++ b/test/js/samples/collapses-text-around-comments/expected-bundle.js @@ -34,8 +34,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -124,10 +123,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -137,7 +132,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -174,11 +168,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/collapses-text-around-comments/expected.js b/test/js/samples/collapses-text-around-comments/expected.js index bbc1e187f6..75d00262c0 100644 --- a/test/js/samples/collapses-text-around-comments/expected.js +++ b/test/js/samples/collapses-text-around-comments/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { appendNode, assign, createElement, createText, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { appendNode, assign, createElement, createText, detachNode, init, insertNode, proto } from "svelte/shared.js"; function data() { return { foo: 42 } @@ -33,11 +33,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/component-static-array/expected-bundle.js b/test/js/samples/component-static-array/expected-bundle.js index a210f5ce42..871a50c7cc 100644 --- a/test/js/samples/component-static-array/expected-bundle.js +++ b/test/js/samples/component-static-array/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -104,10 +103,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -117,7 +112,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -144,12 +138,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static-array/expected.js b/test/js/samples/component-static-array/expected.js index cba2d4d947..f07b2d8ed3 100644 --- a/test/js/samples/component-static-array/expected.js +++ b/test/js/samples/component-static-array/expected.js @@ -22,12 +22,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static-immutable/expected-bundle.js b/test/js/samples/component-static-immutable/expected-bundle.js index 01c033904b..93a558f4ac 100644 --- a/test/js/samples/component-static-immutable/expected-bundle.js +++ b/test/js/samples/component-static-immutable/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -108,10 +107,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -121,7 +116,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -148,12 +142,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static-immutable/expected.js b/test/js/samples/component-static-immutable/expected.js index c7e5228e63..c18720c54a 100644 --- a/test/js/samples/component-static-immutable/expected.js +++ b/test/js/samples/component-static-immutable/expected.js @@ -22,12 +22,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static-immutable2/expected-bundle.js b/test/js/samples/component-static-immutable2/expected-bundle.js index 01c033904b..93a558f4ac 100644 --- a/test/js/samples/component-static-immutable2/expected-bundle.js +++ b/test/js/samples/component-static-immutable2/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -108,10 +107,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -121,7 +116,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -148,12 +142,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static-immutable2/expected.js b/test/js/samples/component-static-immutable2/expected.js index c7e5228e63..c18720c54a 100644 --- a/test/js/samples/component-static-immutable2/expected.js +++ b/test/js/samples/component-static-immutable2/expected.js @@ -22,12 +22,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static/expected-bundle.js b/test/js/samples/component-static/expected-bundle.js index 5af6703c7d..bf7121708a 100644 --- a/test/js/samples/component-static/expected-bundle.js +++ b/test/js/samples/component-static/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -104,10 +103,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -117,7 +112,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -144,12 +138,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/component-static/expected.js b/test/js/samples/component-static/expected.js index fd7e83b2f5..2062324182 100644 --- a/test/js/samples/component-static/expected.js +++ b/test/js/samples/component-static/expected.js @@ -22,12 +22,8 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - nested._unmount(); - }, - - d() { - nested.destroy(false); + d(detach) { + nested.destroy(detach); } }; } diff --git a/test/js/samples/computed-collapsed-if/expected-bundle.js b/test/js/samples/computed-collapsed-if/expected-bundle.js index 0ea5200f7d..1a44c576c5 100644 --- a/test/js/samples/computed-collapsed-if/expected-bundle.js +++ b/test/js/samples/computed-collapsed-if/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -104,10 +103,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -117,7 +112,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -140,8 +134,6 @@ function create_main_fragment(component, ctx) { p: noop, - u: noop, - d: noop }; } diff --git a/test/js/samples/computed-collapsed-if/expected.js b/test/js/samples/computed-collapsed-if/expected.js index 5c248bf515..8ca8d597ee 100644 --- a/test/js/samples/computed-collapsed-if/expected.js +++ b/test/js/samples/computed-collapsed-if/expected.js @@ -18,8 +18,6 @@ function create_main_fragment(component, ctx) { p: noop, - u: noop, - d: noop }; } diff --git a/test/js/samples/css-media-query/expected-bundle.js b/test/js/samples/css-media-query/expected-bundle.js index a2a6c24fb0..446ff23202 100644 --- a/test/js/samples/css-media-query/expected-bundle.js +++ b/test/js/samples/css-media-query/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -161,11 +155,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/css-media-query/expected.js b/test/js/samples/css-media-query/expected.js index eb78637655..b307708cb3 100644 --- a/test/js/samples/css-media-query/expected.js +++ b/test/js/samples/css-media-query/expected.js @@ -23,11 +23,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/css-shadow-dom-keyframes/expected-bundle.js b/test/js/samples/css-shadow-dom-keyframes/expected-bundle.js index e826a95e92..86bef96e53 100644 --- a/test/js/samples/css-shadow-dom-keyframes/expected-bundle.js +++ b/test/js/samples/css-shadow-dom-keyframes/expected-bundle.js @@ -26,8 +26,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -116,10 +115,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -129,7 +124,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -151,11 +145,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } @@ -189,10 +183,6 @@ assign(SvelteComponent.prototype, proto); assign(SvelteComponent.prototype, { _mount(target, anchor) { target.insertBefore(this, anchor); - }, - - _unmount() { - this.parentNode.removeChild(this); } }); diff --git a/test/js/samples/css-shadow-dom-keyframes/expected.js b/test/js/samples/css-shadow-dom-keyframes/expected.js index a5df6fa8f8..e86d8a3cb3 100644 --- a/test/js/samples/css-shadow-dom-keyframes/expected.js +++ b/test/js/samples/css-shadow-dom-keyframes/expected.js @@ -17,11 +17,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } @@ -55,10 +55,6 @@ assign(SvelteComponent.prototype, proto); assign(SvelteComponent.prototype, { _mount(target, anchor) { target.insertBefore(this, anchor); - }, - - _unmount() { - this.parentNode.removeChild(this); } }); diff --git a/test/js/samples/deconflict-builtins/expected-bundle.js b/test/js/samples/deconflict-builtins/expected-bundle.js index 060e8d71c9..34f5c45b4a 100644 --- a/test/js/samples/deconflict-builtins/expected-bundle.js +++ b/test/js/samples/deconflict-builtins/expected-bundle.js @@ -17,9 +17,9 @@ function detachNode(node) { node.parentNode.removeChild(node); } -function destroyEach(iterations) { +function destroyEach(iterations, detach) { for (var i = 0; i < iterations.length; i += 1) { - if (iterations[i]) iterations[i].d(); + if (iterations[i]) iterations[i].d(detach); } } @@ -44,8 +44,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -134,10 +133,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -147,7 +142,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -198,23 +192,18 @@ function create_main_fragment(component, ctx) { } for (; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - each_blocks[i].d(); + each_blocks[i].d(1); } each_blocks.length = each_value.length; } }, - u() { - for (var i = 0; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - } - - detachNode(each_anchor); - }, + d(detach) { + destroyEach(each_blocks, detach); - d() { - destroyEach(each_blocks); + if (detach) { + detachNode(each_anchor); + } } }; } @@ -240,11 +229,11 @@ function create_each_block(component, ctx) { } }, - u() { - detachNode(span); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(span); + } + } }; } diff --git a/test/js/samples/deconflict-builtins/expected.js b/test/js/samples/deconflict-builtins/expected.js index dd48b7708e..9888cef868 100644 --- a/test/js/samples/deconflict-builtins/expected.js +++ b/test/js/samples/deconflict-builtins/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { appendNode, assign, createComment, createElement, createText, destroyEach, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { appendNode, assign, createComment, createElement, createText, destroyEach, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var each_anchor; @@ -46,23 +46,18 @@ function create_main_fragment(component, ctx) { } for (; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - each_blocks[i].d(); + each_blocks[i].d(1); } each_blocks.length = each_value.length; } }, - u() { - for (var i = 0; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - } + d(detach) { + destroyEach(each_blocks, detach); - detachNode(each_anchor); - }, - - d() { - destroyEach(each_blocks); + if (detach) { + detachNode(each_anchor); + } } }; } @@ -88,11 +83,11 @@ function create_each_block(component, ctx) { } }, - u() { - detachNode(span); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(span); + } + } }; } diff --git a/test/js/samples/deconflict-globals/expected-bundle.js b/test/js/samples/deconflict-globals/expected-bundle.js index 304b7cd956..06e30f87bc 100644 --- a/test/js/samples/deconflict-globals/expected-bundle.js +++ b/test/js/samples/deconflict-globals/expected-bundle.js @@ -19,8 +19,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -109,10 +108,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -122,7 +117,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -146,8 +140,6 @@ function create_main_fragment(component, ctx) { p: noop, - u: noop, - d: noop }; } diff --git a/test/js/samples/deconflict-globals/expected.js b/test/js/samples/deconflict-globals/expected.js index a12da57b8a..afac48dfbd 100644 --- a/test/js/samples/deconflict-globals/expected.js +++ b/test/js/samples/deconflict-globals/expected.js @@ -20,8 +20,6 @@ function create_main_fragment(component, ctx) { p: noop, - u: noop, - d: noop }; } diff --git a/test/js/samples/dev-warning-missing-data-computed/expected-bundle.js b/test/js/samples/dev-warning-missing-data-computed/expected-bundle.js index bea4d272db..bb93b05841 100644 --- a/test/js/samples/dev-warning-missing-data-computed/expected-bundle.js +++ b/test/js/samples/dev-warning-missing-data-computed/expected-bundle.js @@ -34,8 +34,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -142,10 +141,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var protoDev = { destroy: destroyDev, get, @@ -155,7 +150,6 @@ var protoDev = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -193,11 +187,11 @@ function create_main_fragment(component, ctx) { } }, - u: function unmount() { - detachNode(p); - }, - - d: noop + d: function destroy$$1(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/dev-warning-missing-data-computed/expected.js b/test/js/samples/dev-warning-missing-data-computed/expected.js index 93be0ba0c1..5efb1f0a5e 100644 --- a/test/js/samples/dev-warning-missing-data-computed/expected.js +++ b/test/js/samples/dev-warning-missing-data-computed/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { appendNode, assign, createElement, createText, detachNode, init, insertNode, noop, protoDev } from "svelte/shared.js"; +import { appendNode, assign, createElement, createText, detachNode, init, insertNode, protoDev } from "svelte/shared.js"; function bar({ foo }) { return foo * 2; @@ -33,11 +33,11 @@ function create_main_fragment(component, ctx) { } }, - u: function unmount() { - detachNode(p); - }, - - d: noop + d: function destroy(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/do-use-dataset/expected-bundle.js b/test/js/samples/do-use-dataset/expected-bundle.js index 1c984cec89..e30355de25 100644 --- a/test/js/samples/do-use-dataset/expected-bundle.js +++ b/test/js/samples/do-use-dataset/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -163,13 +157,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - detachNode(text); - detachNode(div_1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + detachNode(text); + detachNode(div_1); + } + } }; } diff --git a/test/js/samples/do-use-dataset/expected.js b/test/js/samples/do-use-dataset/expected.js index 1ccda44fc7..a57edb8483 100644 --- a/test/js/samples/do-use-dataset/expected.js +++ b/test/js/samples/do-use-dataset/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createElement, createText, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { assign, createElement, createText, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div, text, div_1; @@ -25,13 +25,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - detachNode(text); - detachNode(div_1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + detachNode(text); + detachNode(div_1); + } + } }; } diff --git a/test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js b/test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js index 70f961e65f..3cbc5ca530 100644 --- a/test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js +++ b/test/js/samples/dont-use-dataset-in-legacy/expected-bundle.js @@ -34,8 +34,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -124,10 +123,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -137,7 +132,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -167,13 +161,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - detachNode(text); - detachNode(div_1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + detachNode(text); + detachNode(div_1); + } + } }; } diff --git a/test/js/samples/dont-use-dataset-in-legacy/expected.js b/test/js/samples/dont-use-dataset-in-legacy/expected.js index 812d204455..1475687e2d 100644 --- a/test/js/samples/dont-use-dataset-in-legacy/expected.js +++ b/test/js/samples/dont-use-dataset-in-legacy/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createElement, createText, detachNode, init, insertNode, noop, proto, setAttribute } from "svelte/shared.js"; +import { assign, createElement, createText, detachNode, init, insertNode, proto, setAttribute } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div, text, div_1; @@ -25,13 +25,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - detachNode(text); - detachNode(div_1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + detachNode(text); + detachNode(div_1); + } + } }; } diff --git a/test/js/samples/dont-use-dataset-in-svg/expected-bundle.js b/test/js/samples/dont-use-dataset-in-svg/expected-bundle.js index c7e99cee1f..80e1f60366 100644 --- a/test/js/samples/dont-use-dataset-in-svg/expected-bundle.js +++ b/test/js/samples/dont-use-dataset-in-svg/expected-bundle.js @@ -34,8 +34,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -124,10 +123,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -137,7 +132,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -167,11 +161,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(svg); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(svg); + } + } }; } diff --git a/test/js/samples/dont-use-dataset-in-svg/expected.js b/test/js/samples/dont-use-dataset-in-svg/expected.js index 863062dc91..42bc11876e 100644 --- a/test/js/samples/dont-use-dataset-in-svg/expected.js +++ b/test/js/samples/dont-use-dataset-in-svg/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { appendNode, assign, createSvgElement, detachNode, init, insertNode, noop, proto, setAttribute } from "svelte/shared.js"; +import { appendNode, assign, createSvgElement, detachNode, init, insertNode, proto, setAttribute } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var svg, g, g_1; @@ -25,11 +25,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(svg); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(svg); + } + } }; } diff --git a/test/js/samples/each-block-changed-check/expected-bundle.js b/test/js/samples/each-block-changed-check/expected-bundle.js index e7f7e56af1..353346c205 100644 --- a/test/js/samples/each-block-changed-check/expected-bundle.js +++ b/test/js/samples/each-block-changed-check/expected-bundle.js @@ -23,9 +23,9 @@ function detachAfter(before) { } } -function destroyEach(iterations) { +function destroyEach(iterations, detach) { for (var i = 0; i < iterations.length; i += 1) { - if (iterations[i]) iterations[i].d(); + if (iterations[i]) iterations[i].d(detach); } } @@ -46,8 +46,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -136,10 +135,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -149,7 +144,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -204,8 +198,7 @@ function create_main_fragment(component, ctx) { } for (; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - each_blocks[i].d(); + each_blocks[i].d(1); } each_blocks.length = each_value.length; } @@ -215,17 +208,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - for (var i = 0; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - } - - detachNode(text); - detachNode(p); - }, + d(detach) { + destroyEach(each_blocks, detach); - d() { - destroyEach(each_blocks); + if (detach) { + detachNode(text); + detachNode(p); + } } }; } @@ -281,13 +270,16 @@ function create_each_block(component, ctx) { } }, - u() { - detachAfter(raw_before); + d(detach) { + if (detach) { + detachAfter(raw_before); + } - detachNode(div); - }, - d: noop + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/each-block-changed-check/expected.js b/test/js/samples/each-block-changed-check/expected.js index 7febac791f..f368493846 100644 --- a/test/js/samples/each-block-changed-check/expected.js +++ b/test/js/samples/each-block-changed-check/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { appendNode, assign, createElement, createText, destroyEach, detachAfter, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { appendNode, assign, createElement, createText, destroyEach, detachAfter, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var text, p, text_1; @@ -50,8 +50,7 @@ function create_main_fragment(component, ctx) { } for (; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - each_blocks[i].d(); + each_blocks[i].d(1); } each_blocks.length = each_value.length; } @@ -61,17 +60,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - for (var i = 0; i < each_blocks.length; i += 1) { - each_blocks[i].u(); - } + d(detach) { + destroyEach(each_blocks, detach); - detachNode(text); - detachNode(p); - }, - - d() { - destroyEach(each_blocks); + if (detach) { + detachNode(text); + detachNode(p); + } } }; } @@ -127,13 +122,16 @@ function create_each_block(component, ctx) { } }, - u() { - detachAfter(raw_before); + d(detach) { + if (detach) { + detachAfter(raw_before); + } - detachNode(div); - }, - d: noop + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/event-handlers-custom/expected-bundle.js b/test/js/samples/event-handlers-custom/expected-bundle.js index c66153dd23..10715bd84c 100644 --- a/test/js/samples/event-handlers-custom/expected-bundle.js +++ b/test/js/samples/event-handlers-custom/expected-bundle.js @@ -26,8 +26,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -116,10 +115,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -129,7 +124,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -165,11 +159,11 @@ function create_main_fragment(component, ctx) { }, - u() { - detachNode(button); - }, + d(detach) { + if (detach) { + detachNode(button); + } - d() { foo_handler.destroy(); } }; diff --git a/test/js/samples/event-handlers-custom/expected.js b/test/js/samples/event-handlers-custom/expected.js index cc161cadaf..86741c470c 100644 --- a/test/js/samples/event-handlers-custom/expected.js +++ b/test/js/samples/event-handlers-custom/expected.js @@ -32,11 +32,11 @@ function create_main_fragment(component, ctx) { }, - u() { - detachNode(button); - }, + d(detach) { + if (detach) { + detachNode(button); + } - d() { foo_handler.destroy(); } }; diff --git a/test/js/samples/head-no-whitespace/expected-bundle.js b/test/js/samples/head-no-whitespace/expected-bundle.js index bee02e637f..539ea3e5a4 100644 --- a/test/js/samples/head-no-whitespace/expected-bundle.js +++ b/test/js/samples/head-no-whitespace/expected-bundle.js @@ -26,8 +26,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -116,10 +115,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -129,7 +124,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -155,12 +149,10 @@ function create_main_fragment(component, ctx) { p: noop, - u() { + d(detach) { detachNode(meta); detachNode(meta_1); - }, - - d: noop + } }; } diff --git a/test/js/samples/head-no-whitespace/expected.js b/test/js/samples/head-no-whitespace/expected.js index d0eb2ddcd9..58b3f0e311 100644 --- a/test/js/samples/head-no-whitespace/expected.js +++ b/test/js/samples/head-no-whitespace/expected.js @@ -21,12 +21,10 @@ function create_main_fragment(component, ctx) { p: noop, - u() { + d(detach) { detachNode(meta); detachNode(meta_1); - }, - - d: noop + } }; } diff --git a/test/js/samples/if-block-no-update/expected-bundle.js b/test/js/samples/if-block-no-update/expected-bundle.js index ce8d32f624..d54a62c227 100644 --- a/test/js/samples/if-block-no-update/expected-bundle.js +++ b/test/js/samples/if-block-no-update/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -163,21 +157,18 @@ function create_main_fragment(component, ctx) { p(changed, ctx) { if (current_block_type !== (current_block_type = select_block_type(ctx))) { - if_block.u(); - if_block.d(); + if_block.d(1); if_block = current_block_type(component, ctx); if_block.c(); if_block.m(if_block_anchor.parentNode, if_block_anchor); } }, - u() { - if_block.u(); - detachNode(if_block_anchor); - }, - - d() { - if_block.d(); + d(detach) { + if_block.d(detach); + if (detach) { + detachNode(if_block_anchor); + } } }; } @@ -196,11 +187,11 @@ function create_if_block(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -218,11 +209,11 @@ function create_if_block_1(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/if-block-no-update/expected.js b/test/js/samples/if-block-no-update/expected.js index 783c4fc56c..6bed171850 100644 --- a/test/js/samples/if-block-no-update/expected.js +++ b/test/js/samples/if-block-no-update/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createComment, createElement, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { assign, createComment, createElement, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var if_block_anchor; @@ -25,21 +25,18 @@ function create_main_fragment(component, ctx) { p(changed, ctx) { if (current_block_type !== (current_block_type = select_block_type(ctx))) { - if_block.u(); - if_block.d(); + if_block.d(1); if_block = current_block_type(component, ctx); if_block.c(); if_block.m(if_block_anchor.parentNode, if_block_anchor); } }, - u() { - if_block.u(); - detachNode(if_block_anchor); - }, - - d() { - if_block.d(); + d(detach) { + if_block.d(detach); + if (detach) { + detachNode(if_block_anchor); + } } }; } @@ -58,11 +55,11 @@ function create_if_block(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -80,11 +77,11 @@ function create_if_block_1(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/if-block-simple/expected-bundle.js b/test/js/samples/if-block-simple/expected-bundle.js index ee5b87f32c..9a067201fb 100644 --- a/test/js/samples/if-block-simple/expected-bundle.js +++ b/test/js/samples/if-block-simple/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -163,19 +157,16 @@ function create_main_fragment(component, ctx) { if_block.m(if_block_anchor.parentNode, if_block_anchor); } } else if (if_block) { - if_block.u(); - if_block.d(); + if_block.d(1); if_block = null; } }, - u() { - if (if_block) if_block.u(); - detachNode(if_block_anchor); - }, - - d() { - if (if_block) if_block.d(); + d(detach) { + if (if_block) if_block.d(detach); + if (detach) { + detachNode(if_block_anchor); + } } }; } @@ -194,11 +185,11 @@ function create_if_block(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/if-block-simple/expected.js b/test/js/samples/if-block-simple/expected.js index ae583b652a..98458d918f 100644 --- a/test/js/samples/if-block-simple/expected.js +++ b/test/js/samples/if-block-simple/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createComment, createElement, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { assign, createComment, createElement, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var if_block_anchor; @@ -25,19 +25,16 @@ function create_main_fragment(component, ctx) { if_block.m(if_block_anchor.parentNode, if_block_anchor); } } else if (if_block) { - if_block.u(); - if_block.d(); + if_block.d(1); if_block = null; } }, - u() { - if (if_block) if_block.u(); - detachNode(if_block_anchor); - }, - - d() { - if (if_block) if_block.d(); + d(detach) { + if (if_block) if_block.d(detach); + if (detach) { + detachNode(if_block_anchor); + } } }; } @@ -56,11 +53,11 @@ function create_if_block(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/inline-style-optimized-multiple/expected-bundle.js b/test/js/samples/inline-style-optimized-multiple/expected-bundle.js index 64b9e9f612..13da6e5fc0 100644 --- a/test/js/samples/inline-style-optimized-multiple/expected-bundle.js +++ b/test/js/samples/inline-style-optimized-multiple/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -163,11 +157,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/inline-style-optimized-multiple/expected.js b/test/js/samples/inline-style-optimized-multiple/expected.js index d44a56e57a..742da2b3d9 100644 --- a/test/js/samples/inline-style-optimized-multiple/expected.js +++ b/test/js/samples/inline-style-optimized-multiple/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createElement, detachNode, init, insertNode, noop, proto, setStyle } from "svelte/shared.js"; +import { assign, createElement, detachNode, init, insertNode, proto, setStyle } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div; @@ -25,11 +25,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/inline-style-optimized-url/expected-bundle.js b/test/js/samples/inline-style-optimized-url/expected-bundle.js index 9d66c5d9d3..f27fd1f154 100644 --- a/test/js/samples/inline-style-optimized-url/expected-bundle.js +++ b/test/js/samples/inline-style-optimized-url/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -158,11 +152,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/inline-style-optimized-url/expected.js b/test/js/samples/inline-style-optimized-url/expected.js index b6ade43a35..2eb51e0818 100644 --- a/test/js/samples/inline-style-optimized-url/expected.js +++ b/test/js/samples/inline-style-optimized-url/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createElement, detachNode, init, insertNode, noop, proto, setStyle } from "svelte/shared.js"; +import { assign, createElement, detachNode, init, insertNode, proto, setStyle } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div; @@ -20,11 +20,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/inline-style-optimized/expected-bundle.js b/test/js/samples/inline-style-optimized/expected-bundle.js index dea96b427b..1df7465c86 100644 --- a/test/js/samples/inline-style-optimized/expected-bundle.js +++ b/test/js/samples/inline-style-optimized/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -158,11 +152,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/inline-style-optimized/expected.js b/test/js/samples/inline-style-optimized/expected.js index 9574f5d196..9c55bc6e84 100644 --- a/test/js/samples/inline-style-optimized/expected.js +++ b/test/js/samples/inline-style-optimized/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createElement, detachNode, init, insertNode, noop, proto, setStyle } from "svelte/shared.js"; +import { assign, createElement, detachNode, init, insertNode, proto, setStyle } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div; @@ -20,11 +20,11 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + } + } }; } diff --git a/test/js/samples/inline-style-unoptimized/expected-bundle.js b/test/js/samples/inline-style-unoptimized/expected-bundle.js index 3719ea1587..ed8e4fd01c 100644 --- a/test/js/samples/inline-style-unoptimized/expected-bundle.js +++ b/test/js/samples/inline-style-unoptimized/expected-bundle.js @@ -30,8 +30,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -120,10 +119,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -133,7 +128,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -167,13 +161,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - detachNode(text); - detachNode(div_1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + detachNode(text); + detachNode(div_1); + } + } }; } diff --git a/test/js/samples/inline-style-unoptimized/expected.js b/test/js/samples/inline-style-unoptimized/expected.js index a1fc3d49f4..41ffd501e0 100644 --- a/test/js/samples/inline-style-unoptimized/expected.js +++ b/test/js/samples/inline-style-unoptimized/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { assign, createElement, createText, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { assign, createElement, createText, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div, text, div_1, div_1_style_value; @@ -29,13 +29,13 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(div); - detachNode(text); - detachNode(div_1); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(div); + detachNode(text); + detachNode(div_1); + } + } }; } diff --git a/test/js/samples/input-without-blowback-guard/expected-bundle.js b/test/js/samples/input-without-blowback-guard/expected-bundle.js index 6c5b717096..67915bc81b 100644 --- a/test/js/samples/input-without-blowback-guard/expected-bundle.js +++ b/test/js/samples/input-without-blowback-guard/expected-bundle.js @@ -38,8 +38,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -128,10 +127,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -141,7 +136,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -171,11 +165,11 @@ function create_main_fragment(component, ctx) { input.checked = ctx.foo; }, - u() { - detachNode(input); - }, + d(detach) { + if (detach) { + detachNode(input); + } - d() { removeListener(input, "change", input_change_handler); } }; diff --git a/test/js/samples/input-without-blowback-guard/expected.js b/test/js/samples/input-without-blowback-guard/expected.js index 7aee1cb407..635987f16b 100644 --- a/test/js/samples/input-without-blowback-guard/expected.js +++ b/test/js/samples/input-without-blowback-guard/expected.js @@ -25,11 +25,11 @@ function create_main_fragment(component, ctx) { input.checked = ctx.foo; }, - u() { - detachNode(input); - }, + d(detach) { + if (detach) { + detachNode(input); + } - d() { removeListener(input, "change", input_change_handler); } }; diff --git a/test/js/samples/legacy-input-type/expected-bundle.js b/test/js/samples/legacy-input-type/expected-bundle.js index b3469f7864..9f806ed42a 100644 --- a/test/js/samples/legacy-input-type/expected-bundle.js +++ b/test/js/samples/legacy-input-type/expected-bundle.js @@ -32,8 +32,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -122,10 +121,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -135,7 +130,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -156,11 +150,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(input); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(input); + } + } }; } diff --git a/test/js/samples/legacy-input-type/expected.js b/test/js/samples/legacy-input-type/expected.js index 89e31fa479..2e1c279b20 100644 --- a/test/js/samples/legacy-input-type/expected.js +++ b/test/js/samples/legacy-input-type/expected.js @@ -16,11 +16,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(input); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(input); + } + } }; } diff --git a/test/js/samples/media-bindings/expected-bundle.js b/test/js/samples/media-bindings/expected-bundle.js index 8013f2b11f..fbb235a80d 100644 --- a/test/js/samples/media-bindings/expected-bundle.js +++ b/test/js/samples/media-bindings/expected-bundle.js @@ -42,8 +42,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -132,10 +131,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -145,7 +140,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -214,11 +208,11 @@ function create_main_fragment(component, ctx) { if (!audio_updating && !isNaN(ctx.volume)) audio.volume = ctx.volume; }, - u() { - detachNode(audio); - }, + d(detach) { + if (detach) { + detachNode(audio); + } - d() { removeListener(audio, "timeupdate", audio_timeupdate_handler); removeListener(audio, "durationchange", audio_durationchange_handler); removeListener(audio, "play", audio_play_pause_handler); diff --git a/test/js/samples/media-bindings/expected.js b/test/js/samples/media-bindings/expected.js index 2b4c3b627c..f2400877e2 100644 --- a/test/js/samples/media-bindings/expected.js +++ b/test/js/samples/media-bindings/expected.js @@ -64,11 +64,11 @@ function create_main_fragment(component, ctx) { if (!audio_updating && !isNaN(ctx.volume)) audio.volume = ctx.volume; }, - u() { - detachNode(audio); - }, + d(detach) { + if (detach) { + detachNode(audio); + } - d() { removeListener(audio, "timeupdate", audio_timeupdate_handler); removeListener(audio, "durationchange", audio_durationchange_handler); removeListener(audio, "play", audio_play_pause_handler); diff --git a/test/js/samples/non-imported-component/expected-bundle.js b/test/js/samples/non-imported-component/expected-bundle.js index 0611137fb9..bfab868082 100644 --- a/test/js/samples/non-imported-component/expected-bundle.js +++ b/test/js/samples/non-imported-component/expected-bundle.js @@ -28,8 +28,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -118,10 +117,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -131,7 +126,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -165,15 +159,13 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - imported._unmount(); - detachNode(text); - nonimported._unmount(); - }, + d(detach) { + imported.destroy(detach); + if (detach) { + detachNode(text); + } - d() { - imported.destroy(false); - nonimported.destroy(false); + nonimported.destroy(detach); } }; } diff --git a/test/js/samples/non-imported-component/expected.js b/test/js/samples/non-imported-component/expected.js index 4af3611542..c070fa76d4 100644 --- a/test/js/samples/non-imported-component/expected.js +++ b/test/js/samples/non-imported-component/expected.js @@ -30,15 +30,13 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - imported._unmount(); - detachNode(text); - nonimported._unmount(); - }, + d(detach) { + imported.destroy(detach); + if (detach) { + detachNode(text); + } - d() { - imported.destroy(false); - nonimported.destroy(false); + nonimported.destroy(detach); } }; } diff --git a/test/js/samples/setup-method/expected-bundle.js b/test/js/samples/setup-method/expected-bundle.js index 83c58b1f41..30d69d6180 100644 --- a/test/js/samples/setup-method/expected-bundle.js +++ b/test/js/samples/setup-method/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -104,10 +103,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -117,7 +112,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -148,8 +142,6 @@ function create_main_fragment(component, ctx) { p: noop, - u: noop, - d: noop }; } diff --git a/test/js/samples/setup-method/expected.js b/test/js/samples/setup-method/expected.js index cb565b0f74..855e7635b0 100644 --- a/test/js/samples/setup-method/expected.js +++ b/test/js/samples/setup-method/expected.js @@ -26,8 +26,6 @@ function create_main_fragment(component, ctx) { p: noop, - u: noop, - d: noop }; } diff --git a/test/js/samples/svg-title/expected-bundle.js b/test/js/samples/svg-title/expected-bundle.js index c80b95ef78..faf86f14cb 100644 --- a/test/js/samples/svg-title/expected-bundle.js +++ b/test/js/samples/svg-title/expected-bundle.js @@ -34,8 +34,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -124,10 +123,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -137,7 +132,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -161,11 +155,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(svg); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(svg); + } + } }; } diff --git a/test/js/samples/svg-title/expected.js b/test/js/samples/svg-title/expected.js index df05dc331f..96a1ea09d1 100644 --- a/test/js/samples/svg-title/expected.js +++ b/test/js/samples/svg-title/expected.js @@ -19,11 +19,11 @@ function create_main_fragment(component, ctx) { p: noop, - u() { - detachNode(svg); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(svg); + } + } }; } diff --git a/test/js/samples/title/expected-bundle.js b/test/js/samples/title/expected-bundle.js index 10972a30e7..1c4fd5e84f 100644 --- a/test/js/samples/title/expected-bundle.js +++ b/test/js/samples/title/expected-bundle.js @@ -14,8 +14,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -104,10 +103,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -117,7 +112,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -139,8 +133,6 @@ function create_main_fragment(component, ctx) { } }, - u: noop, - d: noop }; } diff --git a/test/js/samples/title/expected.js b/test/js/samples/title/expected.js index 75ef8925a3..f5aa312569 100644 --- a/test/js/samples/title/expected.js +++ b/test/js/samples/title/expected.js @@ -17,8 +17,6 @@ function create_main_fragment(component, ctx) { } }, - u: noop, - d: noop }; } diff --git a/test/js/samples/use-elements-as-anchors/expected-bundle.js b/test/js/samples/use-elements-as-anchors/expected-bundle.js index 90d0e36438..3a3879b91e 100644 --- a/test/js/samples/use-elements-as-anchors/expected-bundle.js +++ b/test/js/samples/use-elements-as-anchors/expected-bundle.js @@ -38,8 +38,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -128,10 +127,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -141,7 +136,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -207,8 +201,7 @@ function create_main_fragment(component, ctx) { if_block.m(div, text); } } else if (if_block) { - if_block.u(); - if_block.d(); + if_block.d(1); if_block = null; } @@ -219,8 +212,7 @@ function create_main_fragment(component, ctx) { if_block_1.m(div, text_3); } } else if (if_block_1) { - if_block_1.u(); - if_block_1.d(); + if_block_1.d(1); if_block_1 = null; } @@ -231,8 +223,7 @@ function create_main_fragment(component, ctx) { if_block_2.m(div, text_4); } } else if (if_block_2) { - if_block_2.u(); - if_block_2.d(); + if_block_2.d(1); if_block_2 = null; } @@ -243,8 +234,7 @@ function create_main_fragment(component, ctx) { if_block_3.m(div, null); } } else if (if_block_3) { - if_block_3.u(); - if_block_3.d(); + if_block_3.d(1); if_block_3 = null; } @@ -255,29 +245,28 @@ function create_main_fragment(component, ctx) { if_block_4.m(if_block_4_anchor.parentNode, if_block_4_anchor); } } else if (if_block_4) { - if_block_4.u(); - if_block_4.d(); + if_block_4.d(1); if_block_4 = null; } }, - u() { - detachNode(div); - if (if_block) if_block.u(); - if (if_block_1) if_block_1.u(); - if (if_block_2) if_block_2.u(); - if (if_block_3) if_block_3.u(); - detachNode(text_8); - if (if_block_4) if_block_4.u(); - detachNode(if_block_4_anchor); - }, + d(detach) { + if (detach) { + detachNode(div); + } - d() { if (if_block) if_block.d(); if (if_block_1) if_block_1.d(); if (if_block_2) if_block_2.d(); if (if_block_3) if_block_3.d(); - if (if_block_4) if_block_4.d(); + if (detach) { + detachNode(text_8); + } + + if (if_block_4) if_block_4.d(detach); + if (detach) { + detachNode(if_block_4_anchor); + } } }; } @@ -296,11 +285,11 @@ function create_if_block(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -318,11 +307,11 @@ function create_if_block_1(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -340,11 +329,11 @@ function create_if_block_2(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -362,11 +351,11 @@ function create_if_block_3(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -384,11 +373,11 @@ function create_if_block_4(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/use-elements-as-anchors/expected.js b/test/js/samples/use-elements-as-anchors/expected.js index 26b782988e..9e33cb6e03 100644 --- a/test/js/samples/use-elements-as-anchors/expected.js +++ b/test/js/samples/use-elements-as-anchors/expected.js @@ -1,5 +1,5 @@ /* generated by Svelte vX.Y.Z */ -import { appendNode, assign, createComment, createElement, createText, detachNode, init, insertNode, noop, proto } from "svelte/shared.js"; +import { appendNode, assign, createComment, createElement, createText, detachNode, init, insertNode, proto } from "svelte/shared.js"; function create_main_fragment(component, ctx) { var div, text, p, text_2, text_3, text_4, p_1, text_6, text_8, if_block_4_anchor; @@ -61,8 +61,7 @@ function create_main_fragment(component, ctx) { if_block.m(div, text); } } else if (if_block) { - if_block.u(); - if_block.d(); + if_block.d(1); if_block = null; } @@ -73,8 +72,7 @@ function create_main_fragment(component, ctx) { if_block_1.m(div, text_3); } } else if (if_block_1) { - if_block_1.u(); - if_block_1.d(); + if_block_1.d(1); if_block_1 = null; } @@ -85,8 +83,7 @@ function create_main_fragment(component, ctx) { if_block_2.m(div, text_4); } } else if (if_block_2) { - if_block_2.u(); - if_block_2.d(); + if_block_2.d(1); if_block_2 = null; } @@ -97,8 +94,7 @@ function create_main_fragment(component, ctx) { if_block_3.m(div, null); } } else if (if_block_3) { - if_block_3.u(); - if_block_3.d(); + if_block_3.d(1); if_block_3 = null; } @@ -109,29 +105,28 @@ function create_main_fragment(component, ctx) { if_block_4.m(if_block_4_anchor.parentNode, if_block_4_anchor); } } else if (if_block_4) { - if_block_4.u(); - if_block_4.d(); + if_block_4.d(1); if_block_4 = null; } }, - u() { - detachNode(div); - if (if_block) if_block.u(); - if (if_block_1) if_block_1.u(); - if (if_block_2) if_block_2.u(); - if (if_block_3) if_block_3.u(); - detachNode(text_8); - if (if_block_4) if_block_4.u(); - detachNode(if_block_4_anchor); - }, + d(detach) { + if (detach) { + detachNode(div); + } - d() { if (if_block) if_block.d(); if (if_block_1) if_block_1.d(); if (if_block_2) if_block_2.d(); if (if_block_3) if_block_3.d(); - if (if_block_4) if_block_4.d(); + if (detach) { + detachNode(text_8); + } + + if (if_block_4) if_block_4.d(detach); + if (detach) { + detachNode(if_block_4_anchor); + } } }; } @@ -150,11 +145,11 @@ function create_if_block(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -172,11 +167,11 @@ function create_if_block_1(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -194,11 +189,11 @@ function create_if_block_2(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -216,11 +211,11 @@ function create_if_block_3(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } @@ -238,11 +233,11 @@ function create_if_block_4(component, ctx) { insertNode(p, target, anchor); }, - u() { - detachNode(p); - }, - - d: noop + d(detach) { + if (detach) { + detachNode(p); + } + } }; } diff --git a/test/js/samples/window-binding-scroll/expected-bundle.js b/test/js/samples/window-binding-scroll/expected-bundle.js index 82f3eaf27a..a26fb90ce5 100644 --- a/test/js/samples/window-binding-scroll/expected-bundle.js +++ b/test/js/samples/window-binding-scroll/expected-bundle.js @@ -34,8 +34,7 @@ function destroy(detach) { this.fire('destroy'); this.set = noop; - if (detach !== false) this._fragment.u(); - this._fragment.d(); + this._fragment.d(detach !== false); this._fragment = null; this._state = {}; } @@ -124,10 +123,6 @@ function _mount(target, anchor) { this._fragment[this._fragment.i ? 'i' : 'm'](target, anchor || null); } -function _unmount() { - if (this._fragment) this._fragment.u(); -} - var proto = { destroy, get, @@ -137,7 +132,6 @@ var proto = { _recompute: noop, _set, _mount, - _unmount, _differs }; @@ -185,12 +179,12 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(p); - }, - - d() { + d(detach) { window.removeEventListener("scroll", onwindowscroll); + + if (detach) { + detachNode(p); + } } }; } diff --git a/test/js/samples/window-binding-scroll/expected.js b/test/js/samples/window-binding-scroll/expected.js index 2416e70f94..ce8a8213b6 100644 --- a/test/js/samples/window-binding-scroll/expected.js +++ b/test/js/samples/window-binding-scroll/expected.js @@ -43,12 +43,12 @@ function create_main_fragment(component, ctx) { } }, - u() { - detachNode(p); - }, - - d() { + d(detach) { window.removeEventListener("scroll", onwindowscroll); + + if (detach) { + detachNode(p); + } } }; } diff --git a/test/runtime/samples/await-then-catch-if/main.html b/test/runtime/samples/await-then-catch-if/main.html index f9684c8257..bdeb5a7f5e 100644 --- a/test/runtime/samples/await-then-catch-if/main.html +++ b/test/runtime/samples/await-then-catch-if/main.html @@ -1,11 +1,11 @@ {#if show} -{#await thePromise} -

loading...

-{:then theValue} -

the value is {theValue}

-{:catch theError} -

oh no! {theError.message}

-{/await} + {#await thePromise} +

loading...

+ {:then theValue} +

the value is {theValue}

+ {:catch theError} +

oh no! {theError.message}

+ {/await} {:else} -

Else

+

Else

{/if}