From 08a61a8ff435fad8b2fdec9db743995e993f4c40 Mon Sep 17 00:00:00 2001 From: Timothy Johnson Date: Tue, 10 Dec 2019 14:47:37 -0800 Subject: [PATCH] Fixes sveltejs/svelte#4061 --- .../compile/render_dom/wrappers/InlineComponent/index.ts | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts b/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts index 13c96d0065..631c172576 100644 --- a/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts +++ b/src/compiler/compile/render_dom/wrappers/InlineComponent/index.ts @@ -182,11 +182,9 @@ export default class InlineComponentWrapper extends Wrapper { }); }); - const non_let_dependencies = Array.from(fragment_dependencies).filter(name => !this.node.scope.is_let(name)); - const dynamic_attributes = this.node.attributes.filter(a => a.get_dependencies().length > 0); - if (!uses_spread && (dynamic_attributes.length > 0 || this.node.bindings.length > 0 || non_let_dependencies.length > 0)) { + if (!uses_spread && (dynamic_attributes.length > 0 || this.node.bindings.length > 0 || fragment_dependencies.size > 0)) { updates.push(b`const ${name_changes} = {};`); } @@ -266,9 +264,9 @@ export default class InlineComponentWrapper extends Wrapper { } } - if (non_let_dependencies.length > 0) { + if (fragment_dependencies.size > 0) { updates.push(b` - if (${renderer.dirty(non_let_dependencies)}) { + if (${renderer.dirty(Array.from(fragment_dependencies))}) { ${name_changes}.$$scope = { dirty: #dirty, ctx: #ctx }; }`); }