Merge pull request #242 from sveltejs/gh-231

make yield renderer names globally unique
pull/244/head
Rich Harris 9 years ago committed by GitHub
commit 00db8419d2

@ -83,7 +83,7 @@ class DomGenerator extends Generator {
properties.addBlock( deindent`
teardown: function ( detach ) {
${fragment.builders.teardown}
},
}
` );
}

@ -31,7 +31,7 @@ export default {
// Component has children, put them in a separate {{yield}} block
if ( hasChildren ) {
const yieldName = generator.current.getUniqueName( `render${name}YieldFragment` );
const yieldName = generator.getUniqueName( `render${name}YieldFragment` );
generator.generateBlock( node, yieldName );

@ -0,0 +1,14 @@
export default {
solo: true,
html: `
<div><p class='widget'>Hello</p></div>
`,
test ( assert, component, target ) {
component.set({ arriving: false });
assert.htmlEqual( target.innerHTML, `<div><p class='widget'>Goodbye</p></div>` );
component.teardown();
}
};

@ -0,0 +1,23 @@
<div>
{{#if arriving}}
<Widget>Hello</Widget>
{{else}}
<Widget>Goodbye</Widget>
{{/if}}
</div>
<script>
import Widget from './Widget.html';
export default {
data () {
return {
arriving: true
}
},
components: {
Widget
}
};
</script>
Loading…
Cancel
Save