UT: improve test coverage for load balancer unit test (#325)

* improve test coverage for load-balancer

* modify CHANGELOG.md

Co-authored-by: lapplelei <lapplelei@tencent.com>
pull/328/head
lapple 3 years ago committed by GitHub
parent f88a342c4d
commit ff94e2ed46
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23

@ -20,3 +20,4 @@
- [Use jdk constants instead of magic variables](https://github.com/Tencent/spring-cloud-tencent/pull/313)
- [Fix the current limiting effect is that other requests cannot be processed when queuing at a constant speed](https://github.com/Tencent/spring-cloud-tencent/pull/316)
- [Fix config file format misspell](https://github.com/Tencent/spring-cloud-tencent/pull/319)
- [UT: improve test coverage for load balancer unit test](https://github.com/Tencent/spring-cloud-tencent/pull/325)

@ -49,6 +49,13 @@
<artifactId>spring-boot-starter-test</artifactId>
<scope>test</scope>
</dependency>
<dependency>
<groupId>org.mockito</groupId>
<artifactId>mockito-inline</artifactId>
<scope>test</scope>
</dependency>
</dependencies>
</project>
</project>

@ -0,0 +1,187 @@
/*
* Tencent is pleased to support the open source community by making Spring Cloud Tencent available.
*
* Copyright (C) 2019 THL A29 Limited, a Tencent company. All rights reserved.
*
* Licensed under the BSD 3-Clause License (the "License");
* you may not use this file except in compliance with the License.
* You may obtain a copy of the License at
*
* https://opensource.org/licenses/BSD-3-Clause
*
* Unless required by applicable law or agreed to in writing, software distributed
* under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
* CONDITIONS OF ANY KIND, either express or implied. See the License for the
* specific language governing permissions and limitations under the License.
*/
// CHECKSTYLE:OFF
package com.tencent.cloud.polaris.loadbalancer;
import java.util.List;
import java.util.stream.Collectors;
import java.util.stream.Stream;
import com.netflix.client.config.DefaultClientConfigImpl;
import com.netflix.client.config.IClientConfig;
import com.netflix.loadbalancer.DummyPing;
import com.netflix.loadbalancer.Server;
import com.netflix.loadbalancer.ServerList;
import com.tencent.cloud.common.util.ApplicationContextAwareUtils;
import com.tencent.cloud.polaris.loadbalancer.config.PolarisLoadBalancerProperties;
import com.tencent.polaris.api.core.ConsumerAPI;
import com.tencent.polaris.api.pojo.DefaultInstance;
import com.tencent.polaris.api.pojo.DefaultServiceInstances;
import com.tencent.polaris.api.pojo.Instance;
import com.tencent.polaris.api.pojo.ServiceInstances;
import com.tencent.polaris.api.pojo.ServiceKey;
import com.tencent.polaris.api.rpc.InstancesResponse;
import com.tencent.polaris.router.api.core.RouterAPI;
import com.tencent.polaris.router.api.rpc.ProcessLoadBalanceResponse;
import org.junit.Assert;
import org.junit.Test;
import org.junit.runner.RunWith;
import org.mockito.Mock;
import org.mockito.MockedStatic;
import org.mockito.Mockito;
import org.mockito.junit.MockitoJUnitRunner;
import org.springframework.cloud.netflix.ribbon.StaticServerList;
import static org.mockito.ArgumentMatchers.any;
import static org.mockito.Mockito.when;
/**
* Test for {@link PolarisLoadBalancer}.
*
* @author lapple.lei 2022-06-28
*/
@RunWith(MockitoJUnitRunner.class)
public class PolarisLoadBalancerTest {
private static final String CLIENT_NAME = "polaris-test-server";
private static final String NS = "testNamespace";
private static final String[] HOST_LIST = new String[] {
"127.0.0.1",
"127.0.0.2",
"127.0.0.3",
"127.0.0.4",
"127.0.0.5",
};
@Mock
private RouterAPI routerAPI;
@Mock
private ConsumerAPI consumerAPI;
@Test
public void testPolarisLoadBalancer() {
//mock consumerAPI
when(consumerAPI.getHealthyInstancesInstance(any())).thenReturn(this.assembleInstanceResp());
//mock routerAPI for rule
when(routerAPI.processLoadBalance(any())).thenReturn(assembleProcessLoadBalanceResp());
PolarisWeightedRule rule = new PolarisWeightedRule(routerAPI);
// clientConfig
IClientConfig config = new DefaultClientConfigImpl();
config.loadProperties(CLIENT_NAME);
//mock for MetadataContext
try (MockedStatic<ApplicationContextAwareUtils> mockedCtxUtils = Mockito
.mockStatic(ApplicationContextAwareUtils.class)) {
mockedCtxUtils.when(() -> ApplicationContextAwareUtils.getProperties("spring.cloud.polaris.namespace"))
.thenReturn(NS);
mockedCtxUtils.when(() -> ApplicationContextAwareUtils.getProperties("spring.cloud.polaris.service"))
.thenReturn("TestServer");
PolarisLoadBalancerProperties properties = new PolarisLoadBalancerProperties();
ServerList<Server> emptyServerList = new StaticServerList<>();
PolarisLoadBalancer balancer = new PolarisLoadBalancer(config, rule, new DummyPing(), emptyServerList,
consumerAPI, properties);
String host = balancer.choose(null);
System.out.println(host);
Assert.assertNotNull(host);
Assert.assertEquals("127.0.0.1:8080", host);
}
}
@Test
public void testExtendDiscoveryServiceInstance() {
//mock routerAPI for rule
when(routerAPI.processLoadBalance(any())).thenReturn(assembleProcessLoadBalanceResp());
PolarisWeightedRule rule = new PolarisWeightedRule(routerAPI);
// clientConfig
IClientConfig config = new DefaultClientConfigImpl();
config.loadProperties(CLIENT_NAME);
//mock for MetadataContext
try (MockedStatic<ApplicationContextAwareUtils> mockedCtxUtils = Mockito
.mockStatic(ApplicationContextAwareUtils.class)) {
mockedCtxUtils.when(() -> ApplicationContextAwareUtils.getProperties("spring.cloud.polaris.namespace"))
.thenReturn(NS);
mockedCtxUtils.when(() -> ApplicationContextAwareUtils.getProperties("spring.cloud.polaris.service"))
.thenReturn("TestServer");
PolarisLoadBalancerProperties properties = new PolarisLoadBalancerProperties();
properties.setDiscoveryType("TEST");
ServerList<Server> staticServerList = assembleServerList();
PolarisLoadBalancer balancer = new PolarisLoadBalancer(config, rule, new DummyPing(), staticServerList,
consumerAPI, properties);
String host = balancer.choose(null);
System.out.println(host);
}
}
private ServerList<Server> assembleServerList() {
return new StaticServerList<>(Stream.of(HOST_LIST).map(this::convertServer).toArray(Server[]::new));
}
private ProcessLoadBalanceResponse assembleProcessLoadBalanceResp() {
ServiceInstances serviceInstances = assembleServiceInstances();
return new ProcessLoadBalanceResponse(serviceInstances.getInstances().get(0));
}
private InstancesResponse assembleInstanceResp() {
return new InstancesResponse(assembleServiceInstances());
}
private ServiceInstances assembleServiceInstances() {
ServiceKey serviceKey = new ServiceKey(NS, CLIENT_NAME);
List<Instance> instances = Stream.of(HOST_LIST).map(this::convertInstance).collect(Collectors.toList());
return new DefaultServiceInstances(serviceKey, instances);
}
private Instance convertInstance(String host) {
DefaultInstance instance = new DefaultInstance();
instance.setHost(host);
instance.setPort(8080);
return instance;
}
private Server convertServer(String host) {
return new Server("http", host, 8080);
}
}
Loading…
Cancel
Save