From db29d774d3e0d9fbd63751099f367b8f475894ac Mon Sep 17 00:00:00 2001 From: Fishtail <49390359+fuyuwei01@users.noreply.github.com> Date: Thu, 17 Jul 2025 19:18:09 +0800 Subject: [PATCH] fix: fix ConfigChangeListener ut bug (#1661) --- CHANGELOG.md | 1 + .../polaris/config/listener/ConfigChangeListenerTest.java | 5 ++++- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9eb572b2d..a7b3cf61f 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -7,3 +7,4 @@ - [feat:Add log output and test scenarios in the FaultToleranceService file.](https://github.com/Tencent/spring-cloud-tencent/pull/1652) - [fix: fix ConfigChangeListener and unit test](https://github.com/Tencent/spring-cloud-tencent/pull/1656) - [feat: support spring-retry and feign config refresh and feign eager load support schema](https://github.com/Tencent/spring-cloud-tencent/pull/1651) +- [fix: fix ConfigChangeListener ut bug](https://github.com/Tencent/spring-cloud-tencent/pull/1661) diff --git a/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/listener/ConfigChangeListenerTest.java b/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/listener/ConfigChangeListenerTest.java index 6898bb331..5a445e5c7 100644 --- a/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/listener/ConfigChangeListenerTest.java +++ b/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/listener/ConfigChangeListenerTest.java @@ -57,7 +57,7 @@ import static org.springframework.boot.test.context.SpringBootTest.WebEnvironmen }) public class ConfigChangeListenerTest { - private static final CountDownLatch hits = new CountDownLatch(2); + private static CountDownLatch hits = new CountDownLatch(2); @Autowired private ApplicationEventPublisher applicationEventPublisher; @Autowired @@ -85,13 +85,16 @@ public class ConfigChangeListenerTest { Set ketSet = new HashSet<>(); ketSet.add("timeout"); for (int i = 2; i <= 1000; i++) { + // Reset hits for each iteration //submit change event System.setProperty("timeout", String.valueOf(i * 1000)); EnvironmentChangeEvent event = new EnvironmentChangeEvent(applicationContext, ketSet); applicationEventPublisher.publishEvent(event); + //after change boolean ret = hits.await(2, TimeUnit.SECONDS); Assertions.assertThat(ret).isEqualTo(true); + hits = new CountDownLatch(2); Assertions.assertThat(testConfig.getChangeCnt()).isEqualTo(2 * i - 2); Assertions.assertThat(testConfig.getSyncChangeCnt()).isEqualTo(2 * i - 2); Assertions.assertThat(testConfig.getTimeout()).isEqualTo(i * 1000);