diff --git a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/annotation/PolarisProcessor.java b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/annotation/PolarisProcessor.java index 2b95379c4..3058e5eb8 100644 --- a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/annotation/PolarisProcessor.java +++ b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/annotation/PolarisProcessor.java @@ -12,7 +12,7 @@ import org.springframework.core.PriorityOrdered; import org.springframework.util.ReflectionUtils; /** - * Get spring bean properties and methods + * Get spring bean properties and methods. * * @author weihubeats 2022-7-10 */ @@ -37,12 +37,18 @@ public abstract class PolarisProcessor implements BeanPostProcessor, PriorityOrd } /** - * subclass should implement this method to process field + * subclass should implement this method to process field. + * @param bean bean + * @param beanName beanName + * @param field field */ protected abstract void processField(Object bean, String beanName, Field field); /** - * subclass should implement this method to process method + * subclass should implement this method to process method. + * @param bean bean + * @param beanName beanName + * @param method method */ protected abstract void processMethod(Object bean, String beanName, Method method); diff --git a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/PlaceholderHelper.java b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/PlaceholderHelper.java index 9aae5a0c7..0caf41b1d 100644 --- a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/PlaceholderHelper.java +++ b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/PlaceholderHelper.java @@ -47,9 +47,10 @@ public class PlaceholderHelper { /** * Resolve placeholder property values, e.g. - *
- *
- * "${somePropertyValue}" -> "the actual property value" + * @param beanFactory beanFactory + * @param beanName beanName + * @param placeholder placeholder + * @return "${somePropertyValue}" -> "the actual property value" */ public Object resolvePropertyValue(ConfigurableBeanFactory beanFactory, String beanName, String placeholder) { // resolve string value @@ -74,15 +75,16 @@ public class PlaceholderHelper { } /** + * + * @param propertyString propertyString + * @return * Extract keys from placeholder, e.g. - * */ public Set extractPlaceholderKeys(String propertyString) { Set placeholderKeys = Sets.newHashSet(); diff --git a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/SpringValueDefinitionProcessor.java b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/SpringValueDefinitionProcessor.java index 5dfa95c1c..4b814266a 100644 --- a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/SpringValueDefinitionProcessor.java +++ b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/spring/property/SpringValueDefinitionProcessor.java @@ -45,7 +45,7 @@ import org.springframework.beans.factory.support.BeanDefinitionRegistryPostProce * <property name="batch" value="${batch:100}"/> * </bean> * - * + * * * SpringValueDefinitionProcessor * @@ -121,4 +121,4 @@ public class SpringValueDefinitionProcessor implements BeanDefinitionRegistryPos } } } -} \ No newline at end of file +} diff --git a/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/adapter/PolarisPropertiesSourceAutoRefresherTest.java b/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/adapter/PolarisPropertiesSourceAutoRefresherTest.java index 36360257a..d64fcf848 100644 --- a/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/adapter/PolarisPropertiesSourceAutoRefresherTest.java +++ b/spring-cloud-starter-tencent-polaris-config/src/test/java/com/tencent/cloud/polaris/config/adapter/PolarisPropertiesSourceAutoRefresherTest.java @@ -45,7 +45,6 @@ import org.springframework.context.ConfigurableApplicationContext; import static org.mockito.ArgumentMatchers.any; import static org.mockito.Mockito.mock; -import static org.mockito.Mockito.verify; import static org.mockito.Mockito.when; /** @@ -73,7 +72,7 @@ public class PolarisPropertiesSourceAutoRefresherTest { private PlaceholderHelper placeholderHelper; @Test - public void testConfigFileChanged() throws Exception{ + public void testConfigFileChanged() throws Exception { PolarisPropertySourceAutoRefresher refresher = new PolarisPropertySourceAutoRefresher(polarisConfigProperties, polarisPropertySourceManager, springValueRegistry, placeholderHelper);