diff --git a/changes/changes-1.12.0.md b/changes/changes-1.12.0.md index afe21b73..44ef6cf8 100644 --- a/changes/changes-1.12.0.md +++ b/changes/changes-1.12.0.md @@ -28,3 +28,4 @@ - [fix:upgrade spring version.](https://github.com/Tencent/spring-cloud-tencent/pull/1085) - [fix:Update README-zh.md](https://github.com/Tencent/spring-cloud-tencent/pull/1094). - [feature: support Polaris configuration center extension plugin interface and support dynamic modification of log levels.](https://github.com/Tencent/spring-cloud-tencent/pull/1105) +- fix:fix system env variable read bug. diff --git a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/listener/PolarisConfigChangeEventListener.java b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/listener/PolarisConfigChangeEventListener.java index e77b5901..e05a939d 100644 --- a/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/listener/PolarisConfigChangeEventListener.java +++ b/spring-cloud-starter-tencent-polaris-config/src/main/java/com/tencent/cloud/polaris/config/listener/PolarisConfigChangeEventListener.java @@ -26,6 +26,8 @@ import java.util.concurrent.atomic.AtomicBoolean; import com.google.common.collect.Maps; import com.tencent.cloud.polaris.config.spring.event.ConfigChangeSpringEvent; import com.tencent.polaris.configuration.api.core.ConfigPropertyChangeInfo; +import org.slf4j.Logger; +import org.slf4j.LoggerFactory; import org.springframework.boot.context.event.ApplicationStartedEvent; import org.springframework.cloud.context.environment.EnvironmentChangeEvent; @@ -37,6 +39,7 @@ import org.springframework.context.ConfigurableApplicationContext; import org.springframework.core.env.ConfigurableEnvironment; import org.springframework.core.env.Environment; import org.springframework.core.env.MutablePropertySources; +import org.springframework.core.env.StandardEnvironment; import org.springframework.lang.NonNull; import static com.tencent.cloud.polaris.config.listener.PolarisConfigListenerContext.fireConfigChange; @@ -50,6 +53,8 @@ import static com.tencent.cloud.polaris.config.listener.PolarisConfigListenerCon */ public final class PolarisConfigChangeEventListener implements ApplicationListener, ApplicationEventPublisherAware { + private static final Logger LOG = LoggerFactory.getLogger(PolarisConfigChangeEventListener.class); + private static final AtomicBoolean started = new AtomicBoolean(); private ApplicationEventPublisher eventPublisher; @@ -95,12 +100,23 @@ public final class PolarisConfigChangeEventListener implements ApplicationListen Map ret = Maps.newHashMap(); MutablePropertySources sources = environment.getPropertySources(); sources.iterator().forEachRemaining(propertySource -> { + // Don't read system env variable. + if (StandardEnvironment.SYSTEM_ENVIRONMENT_PROPERTY_SOURCE_NAME.equals(propertySource.getName())) { + return; + } + Object o = propertySource.getSource(); if (o instanceof Map) { for (Map.Entry entry : ((Map) o).entrySet()) { String key = entry.getKey(); - String value = environment.getProperty(key); - ret.put(key, value); + try { + String value = environment.getProperty(key); + ret.put(key, value); + } + catch (Exception e) { + LOG.warn("Read property from {} with key {} failed.", propertySource.getName(), key, e); + } + } } else if (o instanceof Collection) {