if we register a destroy hook for RemoteConfigFileRepo on the class instance , the static thread pool may be terminated by the bootstrap context closing ,Therefore,it's better to register the destroy hook when the application is prepared, or when the application fails to start, in order to properly destroy resourcespull/1110/head
parent
049154a5d8
commit
884bdffcd3
@ -1,3 +1,4 @@
|
||||
# Change Log
|
||||
---
|
||||
|
||||
- [fix:the polaris config relation non-daemon thread should stop when application fails to start.](https://github.com/Tencent/spring-cloud-tencent/pull/1106)
|
@ -0,0 +1,57 @@
|
||||
/*
|
||||
* Tencent is pleased to support the open source community by making Spring Cloud Tencent available.
|
||||
*
|
||||
* Copyright (C) 2019 THL A29 Limited, a Tencent company. All rights reserved.
|
||||
*
|
||||
* Licensed under the BSD 3-Clause License (the "License");
|
||||
* you may not use this file except in compliance with the License.
|
||||
* You may obtain a copy of the License at
|
||||
*
|
||||
* https://opensource.org/licenses/BSD-3-Clause
|
||||
*
|
||||
* Unless required by applicable law or agreed to in writing, software distributed
|
||||
* under the License is distributed on an "AS IS" BASIS, WITHOUT WARRANTIES OR
|
||||
* CONDITIONS OF ANY KIND, either express or implied. See the License for the
|
||||
* specific language governing permissions and limitations under the License.
|
||||
*
|
||||
*/
|
||||
|
||||
package com.tencent.cloud.polaris.context.listener;
|
||||
|
||||
import com.tencent.cloud.polaris.context.PolarisSDKContextManager;
|
||||
import com.tencent.polaris.configuration.client.internal.RemoteConfigFileRepo;
|
||||
|
||||
import org.springframework.boot.context.event.ApplicationFailedEvent;
|
||||
import org.springframework.boot.context.event.ApplicationPreparedEvent;
|
||||
import org.springframework.context.ApplicationEvent;
|
||||
import org.springframework.context.ApplicationListener;
|
||||
import org.springframework.lang.NonNull;
|
||||
|
||||
/*
|
||||
* Polaris config non-daemon thread stop listener
|
||||
*
|
||||
* @author shuiqingliu
|
||||
* @since 2023/8/29
|
||||
**/
|
||||
public class PolarisContextApplicationEventListener implements ApplicationListener<ApplicationEvent> {
|
||||
|
||||
private final PolarisSDKContextManager polarisSDKContextManager;
|
||||
|
||||
public PolarisContextApplicationEventListener(PolarisSDKContextManager polarisSDKContextManager) {
|
||||
this.polarisSDKContextManager = polarisSDKContextManager;
|
||||
}
|
||||
|
||||
@Override
|
||||
public void onApplicationEvent(@NonNull ApplicationEvent event) {
|
||||
if (event instanceof ApplicationPreparedEvent) {
|
||||
RemoteConfigFileRepo.registerRepoDestroyHook(polarisSDKContextManager.getSDKContext());
|
||||
}
|
||||
|
||||
if (event instanceof ApplicationFailedEvent) {
|
||||
RemoteConfigFileRepo.registerRepoDestroyHook(polarisSDKContextManager.getSDKContext());
|
||||
//implicit invoke 'destroy' when the spring application fails to start, in order to stop non-daemon threads.
|
||||
polarisSDKContextManager.getSDKContext().destroy();
|
||||
}
|
||||
}
|
||||
|
||||
}
|
Loading…
Reference in new issue