From 8272386040682f19f100bde739bb42fe3078a80c Mon Sep 17 00:00:00 2001 From: Fishtail <49390359+fuyuwei01@users.noreply.github.com> Date: Fri, 4 Jul 2025 16:33:18 +0800 Subject: [PATCH] fix:fix PolarisContextProperties instantiated twice causing NPE. (#1641) Co-authored-by: Haotian Zhang --- CHANGELOG.md | 1 + .../context/config/PolarisContextAutoConfiguration.java | 8 +++++++- .../polaris/context/config/PolarisContextProperties.java | 2 +- 3 files changed, 9 insertions(+), 2 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 06c1f8175..9ff46c436 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ # Change Log --- +- [fix:fix PolarisContextProperties instantiated twice causing NPE.](https://github.com/Tencent/spring-cloud-tencent/pull/1641) diff --git a/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextAutoConfiguration.java b/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextAutoConfiguration.java index 5a9e63031..9c8bd38ae 100644 --- a/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextAutoConfiguration.java +++ b/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextAutoConfiguration.java @@ -46,9 +46,15 @@ import org.springframework.core.env.Environment; * @author Haotian Zhang */ @ConditionalOnPolarisEnabled -@EnableConfigurationProperties({PolarisContextProperties.class}) +@EnableConfigurationProperties public class PolarisContextAutoConfiguration { + @Bean + @ConditionalOnMissingBean + public PolarisContextProperties polarisContextProperties() { + return new PolarisContextProperties(); + } + @Bean(initMethod = "init") @ConditionalOnMissingBean public PolarisSDKContextManager polarisSDKContextManager(PolarisContextProperties properties, Environment environment, List modifierList) throws PolarisException { diff --git a/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextProperties.java b/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextProperties.java index 84db65234..25f5a891a 100644 --- a/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextProperties.java +++ b/spring-cloud-tencent-polaris-context/src/main/java/com/tencent/cloud/polaris/context/config/PolarisContextProperties.java @@ -68,7 +68,7 @@ public class PolarisContextProperties { /** * current server local port. */ - @Value("${spring.cloud.polaris.localPort:}") + @Value("${spring.cloud.polaris.localPort:0}") private Integer localPort; /**