From 6c8bbb36e8bd8a0dfc8a042500bc50c20cb80926 Mon Sep 17 00:00:00 2001 From: Haotian Zhang <928016560@qq.com> Date: Thu, 3 Nov 2022 10:19:01 +0800 Subject: [PATCH] docs:update PR template. --- .github/PULL_REQUEST_TEMPLATE.md | 12 ++++++++---- CHANGELOG.md | 1 + .../ratelimit/RateLimitRuleLabelResolverTest.java | 2 +- .../endpoint/PolarisRateLimitRuleEndpointTests.java | 2 +- spring-cloud-tencent-dependencies/pom.xml | 2 +- 5 files changed, 12 insertions(+), 7 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index b89266620..bddc361d1 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -13,16 +13,20 @@ Other... Please describe: ## Adding the issue link (#xxx) if possible. + + ## Note ## Checklist -- [ ] Add copyright holder at the beginning of .class file if it is new. -- [ ] Add information of this PR to CHANGELOG.md in root of project. +- [ ] Add junit tests for adding or updating code. - [ ] All junit tests passing. -- [ ] Coverage from `Codecov Report` should not decrease. +- [ ] Add copyright holder at the beginning of .java file if it is new. +- [ ] Add information of this PR to CHANGELOG.md in root of project. ## Checklist (Optional) - [ ] Will Pull Request to branch of 2020.0 and hoxton. -- [ ] Add documentation in javadoc in code or comment below the PR if necessary. +- [ ] Add documentation in javadoc or comment below the PR if necessary. diff --git a/CHANGELOG.md b/CHANGELOG.md index b1d7e74be..6b553130d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -4,3 +4,4 @@ - [Optimize:optimize SpringValueProcessor.](https://github.com/Tencent/spring-cloud-tencent/pull/668) - [Optimize: Register the service with the ProviderAPI#registerInstance method.](https://github.com/Tencent/spring-cloud-tencent/pull/685) - [Optimize:optimize spring annotation.](https://github.com/Tencent/spring-cloud-tencent/pull/688) +- [docs:update PR template.](https://github.com/Tencent/spring-cloud-tencent/pull/691) diff --git a/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/RateLimitRuleLabelResolverTest.java b/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/RateLimitRuleLabelResolverTest.java index 96b73cea9..c9abe032d 100644 --- a/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/RateLimitRuleLabelResolverTest.java +++ b/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/RateLimitRuleLabelResolverTest.java @@ -61,7 +61,7 @@ public class RateLimitRuleLabelResolverTest { } else { ModelProto.MatchString matchString = ModelProto.MatchString.newBuilder() - .setType(ModelProto.MatchString.MatchStringType.EXACT) + .setType(ModelProto.Operation.EXACT) .setValue(StringValue.of("value")) .setValueType(ModelProto.MatchString.ValueType.TEXT).build(); RateLimitProto.Rule rule = RateLimitProto.Rule.newBuilder() diff --git a/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/endpoint/PolarisRateLimitRuleEndpointTests.java b/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/endpoint/PolarisRateLimitRuleEndpointTests.java index 33edd0b36..d157c1e0a 100644 --- a/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/endpoint/PolarisRateLimitRuleEndpointTests.java +++ b/spring-cloud-starter-tencent-polaris-ratelimit/src/test/java/com/tencent/cloud/polaris/ratelimit/endpoint/PolarisRateLimitRuleEndpointTests.java @@ -83,7 +83,7 @@ public class PolarisRateLimitRuleEndpointTests { } else { ModelProto.MatchString matchString = ModelProto.MatchString.newBuilder() - .setType(ModelProto.MatchString.MatchStringType.EXACT) + .setType(ModelProto.Operation.EXACT) .setValue(StringValue.of("value")) .setValueType(ModelProto.MatchString.ValueType.TEXT).build(); RateLimitProto.Rule rule = RateLimitProto.Rule.newBuilder() diff --git a/spring-cloud-tencent-dependencies/pom.xml b/spring-cloud-tencent-dependencies/pom.xml index dd1d3bc23..e38aa3ec5 100644 --- a/spring-cloud-tencent-dependencies/pom.xml +++ b/spring-cloud-tencent-dependencies/pom.xml @@ -73,7 +73,7 @@ 1.9.0-2020.0.5-SNAPSHOT - 1.9.1 + 1.10.0-SNAPSHOT 1.2.11 4.5.1 1.12.10