From 422f45f5ba39f182e5ca1be92a72127c77d01d79 Mon Sep 17 00:00:00 2001 From: Haotian Zhang <928016560@qq.com> Date: Mon, 13 Feb 2023 17:05:46 +0800 Subject: [PATCH] docs:Add code coverage blocking. (#836) --- .github/PULL_REQUEST_TEMPLATE.md | 7 +++---- .github/workflows/codecov.yml | 3 ++- CHANGELOG.md | 1 + pom.xml | 17 +++++++++-------- 4 files changed, 15 insertions(+), 13 deletions(-) diff --git a/.github/PULL_REQUEST_TEMPLATE.md b/.github/PULL_REQUEST_TEMPLATE.md index f262be83f..5acc60650 100644 --- a/.github/PULL_REQUEST_TEMPLATE.md +++ b/.github/PULL_REQUEST_TEMPLATE.md @@ -21,12 +21,11 @@ fixes # ## Checklist -- [ ] Coverage from `Codecov Report` should not decrease (which means adding junit tests for adding or updating code). -- [ ] All junit tests passing. - [ ] Add copyright holder at the beginning of .java file if it is new. - [ ] Add information of this PR to CHANGELOG.md in root of project. +- [ ] Add documentation in javadoc or comment below the PR if necessary. ## Checklist (Optional) -- [ ] Will Pull Request to branch of 2022.0 and 2020.0. -- [ ] Add documentation in javadoc or comment below the PR if necessary. +- [ ] Will pull request to branch of 2020.0. +- [ ] Will pull request to branch of 2022.0. diff --git a/.github/workflows/codecov.yml b/.github/workflows/codecov.yml index 655cd5aaf..7f635f05f 100644 --- a/.github/workflows/codecov.yml +++ b/.github/workflows/codecov.yml @@ -31,4 +31,5 @@ jobs: - name: Upload coverage to Codecov uses: codecov/codecov-action@v3 with: - file: ${{ github.workspace }}/target/site/jacoco/jacoco.xml + token: ${{ secrets.CODECOV_TOKEN }} + files: ${{ github.workspace }}/target/site/jacoco/jacoco.xml diff --git a/CHANGELOG.md b/CHANGELOG.md index 06c1f8175..1ba07663d 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,3 +1,4 @@ # Change Log --- +- [docs:Add code coverage blocking.](https://github.com/Tencent/spring-cloud-tencent/pull/836) diff --git a/pom.xml b/pom.xml index 3173106d7..90de85c10 100644 --- a/pom.xml +++ b/pom.xml @@ -124,15 +124,16 @@ import - + - org.springframework.cloud - spring-cloud-dependencies - ${spring.cloud.version} + org.springframework + spring-framework-bom + ${spring.framework.version} pom import + org.springframework.boot spring-boot-dependencies @@ -141,11 +142,11 @@ import - + - org.springframework - spring-framework-bom - ${spring.framework.version} + org.springframework.cloud + spring-cloud-dependencies + ${spring.cloud.version} pom import