msb-public
/
samples
mirror of https://github.com/flutter/samples.git
1
0
Code Issues Projects Releases Wiki Activity

Add `unawaited_futures` (#1148)

Browse Source
pull/1149/head
Brett Morgan 3 years ago committed by GitHub
parent 802026f4ea
commit f998c9577e
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
12 changed files with 26 additions and 23 deletions
Show Stats Download Patch File Download Diff File

2
add_to_app/android_view/flutter_module_using_plugin/lib/main.dart
Unescape View File

@ -167,7 +167,7 @@ class Contents extends StatelessWidget {
// a browser.
final url = Uri.parse('https://flutter.dev/docs');
if (await launcher.canLaunchUrl(url)) {
launcher.launchUrl(url);
await launcher.launchUrl(url);
}
},
child: const Text('Open Flutter Docs'),

2
add_to_app/multiple_flutters/multiple_flutters_module/lib/main.dart
Unescape View File

@ -97,7 +97,7 @@ class _MyHomePageState extends State<MyHomePage> {
// a browser.
final url = Uri.parse('https://flutter.dev/docs');
if (await launcher.canLaunchUrl(url)) {
launcher.launchUrl(url);
await launcher.launchUrl(url);
}
},
child: const Text('Open Flutter Docs'),

2
add_to_app/plugin/flutter_module_using_plugin/lib/main.dart
Unescape View File

@ -166,7 +166,7 @@ class Contents extends StatelessWidget {
// a browser.
final url = Uri.parse('https://flutter.dev/docs');
if (await launcher.canLaunchUrl(url)) {
launcher.launchUrl(url);
await launcher.launchUrl(url);
}
},
child: const Text('Open Flutter Docs'),

1
analysis_options.yaml
Unescape View File

@ -16,4 +16,5 @@ linter:
package_prefixed_library_names: true
test_types_in_equals: true
throw_in_finally: true
unawaited_futures: true
unnecessary_statements: true

5
desktop_photo_search/fluent_ui/lib/src/unsplash/unsplash.dart
Unescape View File

@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'dart:convert';
import 'dart:typed_data';
@ -86,10 +87,10 @@ class Unsplash {
});
_log.info('GET ${photo.links!.downloadLocation}');
http.get(Uri.parse(photo.links!.downloadLocation!), headers: {
unawaited(http.get(Uri.parse(photo.links!.downloadLocation!), headers: {
'Accept-Version': 'v1',
'Authorization': 'Client-ID $_accessKey',
});
}));
return futureBytes;
}

5
desktop_photo_search/material/lib/src/unsplash/unsplash.dart
Unescape View File

@ -2,6 +2,7 @@
// Use of this source code is governed by a BSD-style license that can be
// found in the LICENSE file.
import 'dart:async';
import 'dart:convert';
import 'dart:typed_data';
@ -86,10 +87,10 @@ class Unsplash {
});
_log.info('GET ${photo.links!.downloadLocation}');
http.get(Uri.parse(photo.links!.downloadLocation!), headers: {
unawaited(http.get(Uri.parse(photo.links!.downloadLocation!), headers: {
'Accept-Version': 'v1',
'Authorization': 'Client-ID $_accessKey',
});
}));
return futureBytes;
}

2
experimental/linting_tool/lib/model/profiles_store.dart
Unescape View File

@ -144,7 +144,7 @@ class ProfilesStore extends ChangeNotifier {
/// Save file to disk if path was provided.
if (savePath != null) {
file.saveTo(savePath);
await file.saveTo(savePath);
return true;
}

2
experimental/linting_tool/lib/pages/saved_lints_page.dart
Unescape View File

@ -104,7 +104,7 @@ class SavedLintsPage extends StatelessWidget {
break;
case 'Delete':
profilesStore.deleteProfile(profile);
await profilesStore.deleteProfile(profile);
break;
default:
}

8
experimental/linting_tool/lib/repository/hive_service.dart
Unescape View File

@ -13,7 +13,7 @@ class HiveService {
List<T> existingProducts = await getBoxes(boxName);
if (!existingProducts.contains(item)) {
openBox.add(item);
await openBox.add(item);
return true;
}
return false;
@ -28,7 +28,7 @@ class HiveService {
for (var item in items) {
if (!existingProducts.contains(item)) {
openBox.add(item);
await openBox.add(item);
}
}
}
@ -42,7 +42,7 @@ class HiveService {
for (var box in boxes) {
if (box == item) {
openBox.deleteAt(boxes.indexOf(item));
await openBox.deleteAt(boxes.indexOf(item));
}
}
}
@ -56,7 +56,7 @@ class HiveService {
for (var box in boxes) {
if (box == item) {
openBox.putAt(boxes.indexOf(item), newItem);
await openBox.putAt(boxes.indexOf(item), newItem);
}
}
}

4
experimental/linting_tool/lib/widgets/lint_expansion_tile.dart
Unescape View File

@ -139,7 +139,7 @@ class _LintExpansionTileState extends State<LintExpansionTile> {
},
);
if (destinationProfileType == ProfileType.newProfile) {
showDialog<String>(
await showDialog<String>(
context: context,
builder: (context) {
return _NewProfileDialog(rule: rule);
@ -147,7 +147,7 @@ class _LintExpansionTileState extends State<LintExpansionTile> {
);
} else if (destinationProfileType ==
ProfileType.existingProfile) {
showDialog<String>(
await showDialog<String>(
context: context,
builder: (context) {
return _ExistingProfileDialog(rule: rule);

2
navigation_and_routing/lib/src/screens/navigator.dart
Unescape View File

@ -79,7 +79,7 @@ class _BookstoreNavigatorState extends State<BookstoreNavigator> {
var signedIn = await authState.signIn(
credentials.username, credentials.password);
if (signedIn) {
routeState.go('/books/popular');
await routeState.go('/books/popular');
}
},
),

14
web/particle_background/lib/simple_animations_package.dart
Unescape View File

@ -372,7 +372,7 @@ class _ControlledAnimationState<T> extends State<ControlledAnimation>
await Future.delayed(widget.delay!);
}
_waitForDelay = false;
executeInstruction();
await executeInstruction();
}
@override
@ -391,23 +391,23 @@ class _ControlledAnimationState<T> extends State<ControlledAnimation>
_controller.stop();
}
if (widget.playback == Playback.PLAY_FORWARD) {
_controller.forward();
await _controller.forward();
}
if (widget.playback == Playback.PLAY_REVERSE) {
_controller.reverse();
await _controller.reverse();
}
if (widget.playback == Playback.START_OVER_FORWARD) {
_controller.forward(from: 0.0);
await _controller.forward(from: 0.0);
}
if (widget.playback == Playback.START_OVER_REVERSE) {
_controller.reverse(from: 1.0);
await _controller.reverse(from: 1.0);
}
if (widget.playback == Playback.LOOP) {
_controller.repeat();
await _controller.repeat();
}
if (widget.playback == Playback.MIRROR && !_isCurrentlyMirroring) {
_isCurrentlyMirroring = true;
_controller.repeat(reverse: true);
await _controller.repeat(reverse: true);
}
if (widget.playback != Playback.MIRROR) {

Write Preview
Loading…
Cancel
Save