From dc37f37b5cff9b65005f766256402757780d7e46 Mon Sep 17 00:00:00 2001 From: Kevin Moore Date: Thu, 25 Jan 2024 18:37:01 -0800 Subject: [PATCH] [web/_tool/verify_packages] skip analyze when pub upgrade fails (#2148) --- web/_tool/verify_packages.dart | 12 ++++++++++-- 1 file changed, 10 insertions(+), 2 deletions(-) diff --git a/web/_tool/verify_packages.dart b/web/_tool/verify_packages.dart index e15273868..d5e1457f6 100644 --- a/web/_tool/verify_packages.dart +++ b/web/_tool/verify_packages.dart @@ -19,12 +19,20 @@ void main() async { for (var i = 0; i < packageDirs.length; i++) { final dir = packageDirs[i]; logWrapped(ansiMagenta, '\n$dir (${i + 1} of ${packageDirs.length})'); - results.add(await run(dir, 'flutter', [ + + final upgradeResult = await run(dir, 'flutter', [ 'pub', 'pub', 'upgrade', '--no-precompile', - ])); + ]); + + results.add(upgradeResult); + if (!upgradeResult) { + // skipping analyze when `pub upgrade` fails. + results.add(false); + continue; + } results.add(await run( dir, 'dart',