mirror of https://github.com/flutter/samples.git
fix: replace scrollableBuilder with builder in CupertinoSheetRoute fo… (#2834)
The CupertinoSheetRoute now correctly implements the required builder
signature according to the Flutter API.
```
// Before
CupertinoSheetRoute<void>(
scrollableBuilder: (BuildContext context, ScrollController controller) {
// ...
},
)
// After
CupertinoSheetRoute<void>(
builder: (BuildContext context) {
// ...
},
)
```
**Changes made:**
- Updated the CupertinoSheetRoute constructor to use the correct builder
parameter instead of the undefined scrollableBuilder parameter.
- Refactored the builder function to remove the unused ScrollController
and simplified the internal structure for better readability.
------
## Pre-launch Checklist
- [✓] I read the [Flutter Style Guide] _recently_, and have followed its
advice.
- [✓] I signed the [CLA].
- [✓] I read the [Contributors Guide].
- [✓] I have added sample code updates to the [changelog].
- [✓] I updated/added relevant documentation (doc comments with `///`).
If you need help, consider asking for advice on the #hackers-devrel
channel on [Discord].
<!-- Links -->
[Flutter Style Guide]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Style-guide-for-Flutter-repo.md
[CLA]: https://cla.developers.google.com/
[Discord]:
https://github.com/flutter/flutter/blob/master/docs/contributing/Chat.md
[Contributors Guide]:
https://github.com/flutter/samples/blob/main/CONTRIBUTING.md
[changelog]: ../CHANGELOG.md
Co-authored-by: Eric Windmill <eric@ericwindmill.com>
pull/2866/head
parent
8bfffd4a84
commit
b538521864