From 87b42f92e3a9ae4f0cb47308a335f7a0d6a4e09a Mon Sep 17 00:00:00 2001 From: Brett Morgan Date: Wed, 3 Jul 2019 06:35:36 +1000 Subject: [PATCH] Analysis_options, format and fixups. (#103) --- isolate_example/analysis_options.yaml | 30 +++++++++++++++++++++ isolate_example/lib/main.dart | 2 +- isolate_example/lib/page_one.dart | 10 +++---- isolate_example/lib/page_two.dart | 38 +++++++++++++++------------ isolate_example/pubspec.lock | 8 +++--- isolate_example/pubspec.yaml | 1 + isolate_example/test/widget_test.dart | 2 +- 7 files changed, 63 insertions(+), 28 deletions(-) create mode 100644 isolate_example/analysis_options.yaml diff --git a/isolate_example/analysis_options.yaml b/isolate_example/analysis_options.yaml new file mode 100644 index 000000000..f117e8a5f --- /dev/null +++ b/isolate_example/analysis_options.yaml @@ -0,0 +1,30 @@ +include: package:pedantic/analysis_options.yaml + +analyzer: + strong-mode: + implicit-casts: false + implicit-dynamic: false + +linter: + rules: + - avoid_types_on_closure_parameters + - avoid_void_async + - await_only_futures + - camel_case_types + - cancel_subscriptions + - close_sinks + - constant_identifier_names + - control_flow_in_finally + - empty_statements + - hash_and_equals + - implementation_imports + - non_constant_identifier_names + - package_api_docs + - package_names + - package_prefixed_library_names + - test_types_in_equals + - throw_in_finally + - unnecessary_brace_in_string_interps + - unnecessary_getters_setters + - unnecessary_new + - unnecessary_statements diff --git a/isolate_example/lib/main.dart b/isolate_example/lib/main.dart index 85b066dd0..b4662a4c4 100644 --- a/isolate_example/lib/main.dart +++ b/isolate_example/lib/main.dart @@ -18,7 +18,7 @@ import 'page_one.dart'; import 'page_two.dart'; import 'page_three.dart'; -void main() => runApp(new MaterialApp(home: new StartApp())); +void main() => runApp(MaterialApp(home: StartApp())); class StartApp extends StatelessWidget { @override diff --git a/isolate_example/lib/page_one.dart b/isolate_example/lib/page_one.dart index 1e311404b..fa3231deb 100644 --- a/isolate_example/lib/page_one.dart +++ b/isolate_example/lib/page_one.dart @@ -37,7 +37,7 @@ class _PerformancePageState extends State { children: [ FutureBuilder( future: computeFuture, - builder: (BuildContext context, AsyncSnapshot snapshot) { + builder: (context, snapshot) { return RaisedButton( child: const Text('Compute on Main'), elevation: 8.0, @@ -47,7 +47,7 @@ class _PerformancePageState extends State { ), FutureBuilder( future: computeFuture, - builder: (BuildContext context, AsyncSnapshot snapshot) { + builder: (context, snapshot) { return RaisedButton( child: const Text('Compute on Secondary'), elevation: 8.0, @@ -133,7 +133,7 @@ class SmoothAnimationWidget extends StatefulWidget { class SmoothAnimationWidgetState extends State with TickerProviderStateMixin { AnimationController _controller; - var borderRadius; + Animation borderRadius; @override void initState() { @@ -168,10 +168,10 @@ class SmoothAnimationWidgetState extends State Widget build(BuildContext context) { return AnimatedBuilder( animation: borderRadius, - builder: (BuildContext context, Widget child) { + builder: (context, child) { return Center( child: Container( - child: new FlutterLogo( + child: FlutterLogo( size: 200, ), alignment: Alignment.bottomCenter, diff --git a/isolate_example/lib/page_two.dart b/isolate_example/lib/page_two.dart index 07779ba17..338cf2161 100644 --- a/isolate_example/lib/page_two.dart +++ b/isolate_example/lib/page_two.dart @@ -40,7 +40,7 @@ class InfiniteProcessPage extends StatelessWidget { 'Summation Results', style: Theme.of(context).textTheme.title, ), - padding: new EdgeInsets.all(8), + padding: EdgeInsets.all(8), ), Expanded(child: RunningList()), SafeArea( @@ -97,7 +97,7 @@ class InfiniteProcessIsolateController extends ChangeNotifier { } void listen() { - mIceRP.listen((message) { + mIceRP.listen((dynamic message) { if (message is SendPort) { newIceSP = message; newIceSP.send(_currentMultiplier); @@ -166,7 +166,7 @@ class RunningList extends StatelessWidget { decoration: BoxDecoration( color: Colors.grey[200], ), - child: new ListView.builder( + child: ListView.builder( itemCount: sums.length, itemBuilder: (context, index) { return Column( @@ -198,7 +198,7 @@ Future _secondIsolateEntryPoint(SendPort callerSP) async { ReceivePort newIceRP = ReceivePort(); callerSP.send(newIceRP.sendPort); - newIceRP.listen((message) { + newIceRP.listen((dynamic message) { if (message is int) multiplyValue = message; }); @@ -216,7 +216,7 @@ Future _secondIsolateEntryPoint(SendPort callerSP) async { } Future brokenUpComputation(int num) { - Random rng = new Random(); + Random rng = Random(); return Future(() { int sum = 0; @@ -228,7 +228,7 @@ Future brokenUpComputation(int num) { }); } -Widget newButtons(context) { +Widget newButtons(BuildContext context) { final controller = Provider.of(context, listen: false); @@ -249,30 +249,34 @@ Widget newButtons(context) { ); } -Widget radioButtonWidget(context) { +Widget radioButtonWidget(BuildContext context) { final controller = Provider.of(context); - return new Row( + return Row( mainAxisAlignment: MainAxisAlignment.center, children: [ - new Radio( + Radio( value: 1, groupValue: controller.multiplier, - onChanged: (_) => controller.setMultiplier(1), + // The following is a result of https://github.com/dart-lang/linter/issues/695 + // ignore: avoid_types_on_closure_parameters + onChanged: (int _) => controller.setMultiplier(1), ), - new Text('1x'), - new Radio( + Text('1x'), + Radio( value: 2, groupValue: controller.multiplier, - onChanged: (_) => controller.setMultiplier(2), + // ignore: avoid_types_on_closure_parameters + onChanged: (int _) => controller.setMultiplier(2), ), - new Text('2x'), - new Radio( + Text('2x'), + Radio( value: 3, groupValue: controller.multiplier, - onChanged: (_) => controller.setMultiplier(3), + // ignore: avoid_types_on_closure_parameters + onChanged: (int _) => controller.setMultiplier(3), ), - new Text('3x'), + Text('3x'), ], ); } diff --git a/isolate_example/pubspec.lock b/isolate_example/pubspec.lock index 287a5e174..7774e55cc 100644 --- a/isolate_example/pubspec.lock +++ b/isolate_example/pubspec.lock @@ -7,7 +7,7 @@ packages: name: async url: "https://pub.dartlang.org" source: hosted - version: "2.1.0" + version: "2.2.0" boolean_selector: dependency: transitive description: @@ -68,7 +68,7 @@ packages: source: hosted version: "1.6.2" pedantic: - dependency: transitive + dependency: "direct dev" description: name: pedantic url: "https://pub.dartlang.org" @@ -87,7 +87,7 @@ packages: name: quiver url: "https://pub.dartlang.org" source: hosted - version: "2.0.2" + version: "2.0.3" sky_engine: dependency: transitive description: flutter @@ -134,7 +134,7 @@ packages: name: test_api url: "https://pub.dartlang.org" source: hosted - version: "0.2.4" + version: "0.2.5" typed_data: dependency: transitive description: diff --git a/isolate_example/pubspec.yaml b/isolate_example/pubspec.yaml index e9d8c264b..6e6e69cb3 100644 --- a/isolate_example/pubspec.yaml +++ b/isolate_example/pubspec.yaml @@ -14,6 +14,7 @@ dependencies: dev_dependencies: flutter_test: sdk: flutter + pedantic: ^1.5.0 flutter: diff --git a/isolate_example/test/widget_test.dart b/isolate_example/test/widget_test.dart index d90e8bac7..0ab1c19b3 100644 --- a/isolate_example/test/widget_test.dart +++ b/isolate_example/test/widget_test.dart @@ -15,7 +15,7 @@ import 'package:flutter_test/flutter_test.dart'; void main() { - testWidgets('This test will always pass', (WidgetTester tester) async { + testWidgets('This test will always pass', (tester) async { return true; }); }