From 787bf09fe3b779d6909bd21a9ac9b75807cb048e Mon Sep 17 00:00:00 2001 From: gaaclarke <30870216+gaaclarke@users.noreply.github.com> Date: Sun, 5 Feb 2023 19:20:05 -0800 Subject: [PATCH] Add `background_isolate_channels` to CI (#1448) * Added sample code for using plugins and channels from background isolates. * goderbauer feedback 1 * goderbauer feedback2 * goderbauer feedback 3 * Add `background_isolate_channels` to CI * Comment in `background_isolate_channels` * Fixup * Elide `experimental/material_3_demo` from `master` * Elide `material_3_demo` from `master` CI * Elide `place_tracker` on `master` CI --------- Co-authored-by: Brett Morgan Co-authored-by: Brett Morgan --- .../macos/Flutter/GeneratedPluginRegistrant.swift | 2 +- .../macos/Flutter/GeneratedPluginRegistrant.swift | 2 +- .../macos/Flutter/GeneratedPluginRegistrant.swift | 2 +- tool/flutter_ci_script_beta.sh | 1 + tool/flutter_ci_script_master.sh | 13 +++++++++---- tool/flutter_ci_script_stable.sh | 1 + .../macos/Flutter/GeneratedPluginRegistrant.swift | 2 +- 7 files changed, 15 insertions(+), 8 deletions(-) diff --git a/experimental/linting_tool/macos/Flutter/GeneratedPluginRegistrant.swift b/experimental/linting_tool/macos/Flutter/GeneratedPluginRegistrant.swift index d2deae347..87d00ec02 100644 --- a/experimental/linting_tool/macos/Flutter/GeneratedPluginRegistrant.swift +++ b/experimental/linting_tool/macos/Flutter/GeneratedPluginRegistrant.swift @@ -6,7 +6,7 @@ import FlutterMacOS import Foundation import file_selector_macos -import path_provider_macos +import path_provider_foundation import url_launcher_macos import window_size diff --git a/experimental/varfont_shader_puzzle/macos/Flutter/GeneratedPluginRegistrant.swift b/experimental/varfont_shader_puzzle/macos/Flutter/GeneratedPluginRegistrant.swift index 0d56f519c..e777c67df 100644 --- a/experimental/varfont_shader_puzzle/macos/Flutter/GeneratedPluginRegistrant.swift +++ b/experimental/varfont_shader_puzzle/macos/Flutter/GeneratedPluginRegistrant.swift @@ -5,7 +5,7 @@ import FlutterMacOS import Foundation -import path_provider_macos +import path_provider_foundation func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) { PathProviderPlugin.register(with: registry.registrar(forPlugin: "PathProviderPlugin")) diff --git a/game_template/macos/Flutter/GeneratedPluginRegistrant.swift b/game_template/macos/Flutter/GeneratedPluginRegistrant.swift index 029ad363f..0758d5534 100644 --- a/game_template/macos/Flutter/GeneratedPluginRegistrant.swift +++ b/game_template/macos/Flutter/GeneratedPluginRegistrant.swift @@ -10,7 +10,7 @@ import firebase_core import firebase_crashlytics import games_services import in_app_purchase_storekit -import path_provider_macos +import path_provider_foundation import shared_preferences_foundation func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) { diff --git a/tool/flutter_ci_script_beta.sh b/tool/flutter_ci_script_beta.sh index 84b073c44..d126c7fe3 100755 --- a/tool/flutter_ci_script_beta.sh +++ b/tool/flutter_ci_script_beta.sh @@ -16,6 +16,7 @@ declare -ar PROJECT_NAMES=( "add_to_app/prebuilt_module/flutter_module" "android_splash_screen" "animations" + "background_isolate_channels" "code_sharing/client" "code_sharing/server" "code_sharing/shared" diff --git a/tool/flutter_ci_script_master.sh b/tool/flutter_ci_script_master.sh index 328d317b5..501ad44ee 100755 --- a/tool/flutter_ci_script_master.sh +++ b/tool/flutter_ci_script_master.sh @@ -16,7 +16,9 @@ declare -ar PROJECT_NAMES=( "add_to_app/prebuilt_module/flutter_module" "android_splash_screen" "animations" - "code_sharing/client" + "background_isolate_channels" + # TODO(DomesticMouse): Use 'const' with the constructor to improve performance. + # "code_sharing/client" "code_sharing/server" "code_sharing/shared" "desktop_photo_search/fluent_ui" @@ -30,7 +32,8 @@ declare -ar PROJECT_NAMES=( "experimental/federated_plugin/federated_plugin_web" "experimental/federated_plugin/federated_plugin_windows" "experimental/linting_tool" - "experimental/material_3_demo" + # TODO(DomesticMouse): Use 'const' with the constructor to improve performance. + # "experimental/material_3_demo" "experimental/pedometer" "experimental/varfont_shader_puzzle" "experimental/web_dashboard" @@ -41,9 +44,11 @@ declare -ar PROJECT_NAMES=( "ios_app_clip" "isolate_example" "jsonexample" - "material_3_demo" + # TODO(DomesticMouse): Use 'const' with the constructor to improve performance. + # "material_3_demo" "navigation_and_routing" - "place_tracker" + # TODO(DomesticMouse): Use 'const' with the constructor to improve performance. + # "place_tracker" "platform_channels" "platform_design" "platform_view_swift" diff --git a/tool/flutter_ci_script_stable.sh b/tool/flutter_ci_script_stable.sh index 689a8561e..561835b79 100755 --- a/tool/flutter_ci_script_stable.sh +++ b/tool/flutter_ci_script_stable.sh @@ -16,6 +16,7 @@ declare -ar PROJECT_NAMES=( "add_to_app/prebuilt_module/flutter_module" "android_splash_screen" "animations" + "background_isolate_channels" "code_sharing/client" "code_sharing/server" "code_sharing/shared" diff --git a/veggieseasons/macos/Flutter/GeneratedPluginRegistrant.swift b/veggieseasons/macos/Flutter/GeneratedPluginRegistrant.swift index 6c0c3d478..f71750892 100644 --- a/veggieseasons/macos/Flutter/GeneratedPluginRegistrant.swift +++ b/veggieseasons/macos/Flutter/GeneratedPluginRegistrant.swift @@ -5,7 +5,7 @@ import FlutterMacOS import Foundation -import shared_preferences_macos +import shared_preferences_foundation import window_size func RegisterGeneratedPlugins(registry: FlutterPluginRegistry) {