From 56c1eb92d5567474697182246909f0bbe4680ab9 Mon Sep 17 00:00:00 2001 From: rami-a <2364772+rami-a@users.noreply.github.com> Date: Wed, 22 Jan 2020 18:34:05 +0000 Subject: [PATCH] Remove extra semantic node from shrine app bar (#248) --- .../gallery/lib/studies/shrine/backdrop.dart | 57 +++++++++---------- gallery/gallery/macos/Podfile.lock | 38 +++++++++++++ 2 files changed, 65 insertions(+), 30 deletions(-) create mode 100644 gallery/gallery/macos/Podfile.lock diff --git a/gallery/gallery/lib/studies/shrine/backdrop.dart b/gallery/gallery/lib/studies/shrine/backdrop.dart index 8c606b4b6..5a1077395 100644 --- a/gallery/gallery/lib/studies/shrine/backdrop.dart +++ b/gallery/gallery/lib/studies/shrine/backdrop.dart @@ -142,38 +142,35 @@ class _BackdropTitle extends AnimatedWidget { ), // Here, we do a custom cross fade between backTitle and frontTitle. // This makes a smooth animation between the two texts. - Semantics( - container: true, - child: Stack( - children: [ - Opacity( - opacity: CurvedAnimation( - parent: ReverseAnimation(animation), - curve: const Interval(0.5, 1), - ).value, - child: FractionalTranslation( - translation: Tween( - begin: Offset.zero, - end: Offset(0.5 * textDirectionScalar, 0), - ).evaluate(animation), - child: backTitle, - ), + Stack( + children: [ + Opacity( + opacity: CurvedAnimation( + parent: ReverseAnimation(animation), + curve: const Interval(0.5, 1), + ).value, + child: FractionalTranslation( + translation: Tween( + begin: Offset.zero, + end: Offset(0.5 * textDirectionScalar, 0), + ).evaluate(animation), + child: backTitle, ), - Opacity( - opacity: CurvedAnimation( - parent: animation, - curve: const Interval(0.5, 1), - ).value, - child: FractionalTranslation( - translation: Tween( - begin: Offset(-0.25 * textDirectionScalar, 0), - end: Offset.zero, - ).evaluate(animation), - child: frontTitle, - ), + ), + Opacity( + opacity: CurvedAnimation( + parent: animation, + curve: const Interval(0.5, 1), + ).value, + child: FractionalTranslation( + translation: Tween( + begin: Offset(-0.25 * textDirectionScalar, 0), + end: Offset.zero, + ).evaluate(animation), + child: frontTitle, ), - ], - ), + ), + ], ), ]), ); diff --git a/gallery/gallery/macos/Podfile.lock b/gallery/gallery/macos/Podfile.lock new file mode 100644 index 000000000..109fd9a69 --- /dev/null +++ b/gallery/gallery/macos/Podfile.lock @@ -0,0 +1,38 @@ +PODS: + - FlutterMacOS (1.0.0) + - shared_preferences (0.0.1) + - shared_preferences_macos (0.0.1): + - FlutterMacOS + - url_launcher (0.0.1) + - url_launcher_macos (0.0.1): + - FlutterMacOS + +DEPENDENCIES: + - FlutterMacOS (from `Flutter/ephemeral/.symlinks/flutter/darwin-x64-release`) + - shared_preferences (from `Flutter/ephemeral/.symlinks/plugins/shared_preferences/macos`) + - shared_preferences_macos (from `Flutter/ephemeral/.symlinks/plugins/shared_preferences_macos/macos`) + - url_launcher (from `Flutter/ephemeral/.symlinks/plugins/url_launcher/macos`) + - url_launcher_macos (from `Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos`) + +EXTERNAL SOURCES: + FlutterMacOS: + :path: Flutter/ephemeral/.symlinks/flutter/darwin-x64-release + shared_preferences: + :path: Flutter/ephemeral/.symlinks/plugins/shared_preferences/macos + shared_preferences_macos: + :path: Flutter/ephemeral/.symlinks/plugins/shared_preferences_macos/macos + url_launcher: + :path: Flutter/ephemeral/.symlinks/plugins/url_launcher/macos + url_launcher_macos: + :path: Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos + +SPEC CHECKSUMS: + FlutterMacOS: 15bea8a44d2fa024068daa0140371c020b4b6ff9 + shared_preferences: 9fec34d1bd906196a4da48fcf6c3ad521cc00b8d + shared_preferences_macos: 5e5c2839894accb56b7d23328905b757f2bafaf6 + url_launcher: af78307ef9bafff91273b34f1c6c0c86a0004fd7 + url_launcher_macos: 76867a28e24e0b6b98bfd65f157b64108e6d477a + +PODFILE CHECKSUM: d8ba9b3e9e93c62c74a660b46c6fcb09f03991a7 + +COCOAPODS: 1.7.5