From 428041b2539d63e17dd747619038372a7177ae68 Mon Sep 17 00:00:00 2001
From: Brett Morgan <brett.morgan@gmail.com>
Date: Wed, 11 Dec 2019 08:09:29 +1100
Subject: [PATCH] Drop build.yaml and simplify url_launcher usage (#177)

---
 experimental/desktop_photo_search/README.md       |  3 +--
 experimental/desktop_photo_search/build.yaml      | 15 ---------------
 .../desktop_photo_search/macos/Podfile.lock       |  5 +++++
 experimental/desktop_photo_search/pubspec.lock    |  4 ++--
 experimental/desktop_photo_search/pubspec.yaml    |  3 +--
 5 files changed, 9 insertions(+), 21 deletions(-)
 delete mode 100644 experimental/desktop_photo_search/build.yaml

diff --git a/experimental/desktop_photo_search/README.md b/experimental/desktop_photo_search/README.md
index 72af8eed1..5eca7d712 100644
--- a/experimental/desktop_photo_search/README.md
+++ b/experimental/desktop_photo_search/README.md
@@ -13,7 +13,7 @@ desktop specific plugins:
   - [file_choser] to enable the application user to select where to save a photo
     from the Unsplash API.
   - [menubar] for exposing Image Search functionality through the menu bar.
-  - [url_launcher_fde] and [url_launcher] plugin, which are used to open external links.
+  - [url_launcher] to open external links.
 
 The Unsplash API client entry point is in the [Unsplash] class, and is built
 atop [http], [built_value] and [built_collection] for JSON Rest API access.
@@ -53,4 +53,3 @@ and how to switch between Flutter release channels.
 [macOS-security]: https://github.com/google/flutter-desktop-embedding/blob/master/macOS-Security.md
 [menubar]: https://github.com/google/flutter-desktop-embedding/tree/master/plugins/menubar
 [url_launcher]: https://pub.dev/packages/url_launcher
-[url_launcher_fde]: https://github.com/google/flutter-desktop-embedding/tree/master/plugins/flutter_plugins/url_launcher_fde
diff --git a/experimental/desktop_photo_search/build.yaml b/experimental/desktop_photo_search/build.yaml
deleted file mode 100644
index cb16bb040..000000000
--- a/experimental/desktop_photo_search/build.yaml
+++ /dev/null
@@ -1,15 +0,0 @@
-targets:
-  $default:
-    builders:
-      built_value_generator|built_value:
-        enabled: true
-
-builders:
-  built_value:
-    target: ":built_value_generator"
-    import: "package:built_value_generator/builder.dart"
-    builder_factories: ["builtValue"]
-    build_extensions: {".dart": [".built_value.g.part"]}
-    auto_apply: dependents
-    build_to: cache
-    applies_builders: ["source_gen|combining_builder"]
diff --git a/experimental/desktop_photo_search/macos/Podfile.lock b/experimental/desktop_photo_search/macos/Podfile.lock
index 3a96c41cd..52943c185 100644
--- a/experimental/desktop_photo_search/macos/Podfile.lock
+++ b/experimental/desktop_photo_search/macos/Podfile.lock
@@ -4,6 +4,7 @@ PODS:
   - FlutterMacOS (1.0.0)
   - menubar (0.0.2):
     - FlutterMacOS
+  - url_launcher (0.0.1)
   - url_launcher_macos (0.0.1):
     - FlutterMacOS
 
@@ -11,6 +12,7 @@ DEPENDENCIES:
   - file_chooser (from `Flutter/ephemeral/.symlinks/plugins/file_chooser/macos`)
   - FlutterMacOS (from `Flutter/ephemeral/.symlinks/flutter/darwin-x64`)
   - menubar (from `Flutter/ephemeral/.symlinks/plugins/menubar/macos`)
+  - url_launcher (from `Flutter/ephemeral/.symlinks/plugins/url_launcher/macos`)
   - url_launcher_macos (from `Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos`)
 
 EXTERNAL SOURCES:
@@ -20,6 +22,8 @@ EXTERNAL SOURCES:
     :path: Flutter/ephemeral/.symlinks/flutter/darwin-x64
   menubar:
     :path: Flutter/ephemeral/.symlinks/plugins/menubar/macos
+  url_launcher:
+    :path: Flutter/ephemeral/.symlinks/plugins/url_launcher/macos
   url_launcher_macos:
     :path: Flutter/ephemeral/.symlinks/plugins/url_launcher_macos/macos
 
@@ -27,6 +31,7 @@ SPEC CHECKSUMS:
   file_chooser: 24432cf5dc836722b05c11c2a0a30d19c3c9b996
   FlutterMacOS: 15bea8a44d2fa024068daa0140371c020b4b6ff9
   menubar: 4e3d461d62d775540277ce6639acafe2a111a231
+  url_launcher: af78307ef9bafff91273b34f1c6c0c86a0004fd7
   url_launcher_macos: 77182d012b6b515c0955d24ed22b38f79b82a99d
 
 PODFILE CHECKSUM: d8ba9b3e9e93c62c74a660b46c6fcb09f03991a7
diff --git a/experimental/desktop_photo_search/pubspec.lock b/experimental/desktop_photo_search/pubspec.lock
index 90de8a718..6adc7be4b 100644
--- a/experimental/desktop_photo_search/pubspec.lock
+++ b/experimental/desktop_photo_search/pubspec.lock
@@ -605,9 +605,9 @@ packages:
       name: url_launcher
       url: "https://pub.dartlang.org"
     source: hosted
-    version: "5.3.0"
+    version: "5.4.0"
   url_launcher_macos:
-    dependency: "direct main"
+    dependency: transitive
     description:
       name: url_launcher_macos
       url: "https://pub.dartlang.org"
diff --git a/experimental/desktop_photo_search/pubspec.yaml b/experimental/desktop_photo_search/pubspec.yaml
index cdf9395ea..256b869a9 100644
--- a/experimental/desktop_photo_search/pubspec.yaml
+++ b/experimental/desktop_photo_search/pubspec.yaml
@@ -26,8 +26,7 @@ dependencies:
   provider: ^3.2.0
   transparent_image: ^1.0.0
   uuid: ^2.0.4
-  url_launcher: ^5.3.0
-  url_launcher_macos: ^0.0.1
+  url_launcher: ^5.4.0
 
 dev_dependencies:
   flutter_test: