From 296fbac814ac00ba7341df9a4f943947bac3f891 Mon Sep 17 00:00:00 2001 From: ColdPaleLight <31977171+ColdPaleLight@users.noreply.github.com> Date: Wed, 5 Jan 2022 05:13:42 +0800 Subject: [PATCH] Ensure that the engine is destroyed when 'EngineBindings.detach' in the multiple_flutters example on Android (#969) --- .../main/java/dev/flutter/multipleflutters/EngineBindings.kt | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt b/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt index 6c0ac0d17..5c5003f68 100644 --- a/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt +++ b/add_to_app/multiple_flutters/multiple_flutters_android/app/src/main/java/dev/flutter/multipleflutters/EngineBindings.kt @@ -74,8 +74,7 @@ class EngineBindings(activity: Activity, delegate: EngineBindingsDelegate, entry * This tears down the messaging connections on the platform channel and the DataModel. */ fun detach() { - // TODO: Uncomment after https://github.com/flutter/engine/pull/24644 is on stable. - // engine.destroy(); + engine.destroy(); DataModel.instance.removeObserver(this) channel.setMethodCallHandler(null) }