From fa4829acc779ba62bafdfeaad371cce0024dc5a2 Mon Sep 17 00:00:00 2001 From: RuiAlonso Date: Thu, 21 Apr 2022 09:06:49 +0200 Subject: [PATCH] chore: changed visibility, some comments --- .../lib/src/components/spaceship_ramp.dart | 19 +++++++++---------- 1 file changed, 9 insertions(+), 10 deletions(-) diff --git a/packages/pinball_components/lib/src/components/spaceship_ramp.dart b/packages/pinball_components/lib/src/components/spaceship_ramp.dart index 3e118da8..c1a731fd 100644 --- a/packages/pinball_components/lib/src/components/spaceship_ramp.dart +++ b/packages/pinball_components/lib/src/components/spaceship_ramp.dart @@ -125,7 +125,10 @@ class _SpaceshipRampBackground extends BodyComponent class _SpaceshipRampBackgroundRailingSpriteComponent extends SpriteComponent with HasGameRef { _SpaceshipRampBackgroundRailingSpriteComponent() - : super(priority: RenderPriority.spaceshipRampBackgroundRailing); + : super( + position: Vector2(-11.7, -54.3), + priority: RenderPriority.spaceshipRampBackgroundRailing, + ); @override Future onLoad() async { await super.onLoad(); @@ -135,7 +138,6 @@ class _SpaceshipRampBackgroundRailingSpriteComponent extends SpriteComponent this.sprite = sprite; size = sprite.originalSize / 10; anchor = Anchor.center; - position = Vector2(-11.7, -54.3); } } @@ -144,7 +146,6 @@ class _SpaceshipRampBackgroundRampSpriteComponent extends SpriteComponent @override Future onLoad() async { await super.onLoad(); - // TODO(ruimiguel): update asset correctly cut from the ramp opening. final sprite = await gameRef.loadSprite( Assets.images.spaceship.ramp.main.keyName, ); @@ -176,10 +177,7 @@ enum SpaceshipRampArrowSpriteState { active5, } -/// Helps obtaining the arrow asset corresponding to each enum -/// [SpaceshipRampArrowSpriteState]. -extension SpaceshipRampArrowSpriteStateX on SpaceshipRampArrowSpriteState { - /// Gives path to the arrow asset, depending on its enum. +extension on SpaceshipRampArrowSpriteState { String get path { switch (this) { case SpaceshipRampArrowSpriteState.inactive: @@ -202,7 +200,10 @@ class _SpaceshipRampArrowSpriteComponent extends SpriteGroupComponent with HasGameRef { _SpaceshipRampArrowSpriteComponent() - : super(priority: RenderPriority.spaceshipRampBackgroundRailing); + : super( + position: Vector2(-3.9, -56.5), + priority: RenderPriority.spaceshipRampBackgroundRailing, + ); @override Future onLoad() async { @@ -216,7 +217,6 @@ class _SpaceshipRampArrowSpriteComponent current = SpaceshipRampArrowSpriteState.inactive; size = sprites[current]!.originalSize / 10; anchor = Anchor.center; - position = Vector2(-3.9, -56.5); } } @@ -225,7 +225,6 @@ class _SpaceshipRampBoardOpeningSpriteComponent extends SpriteComponent @override Future onLoad() async { await super.onLoad(); - // TODO(ruimiguel): update asset correctly cut from the ramp background. final sprite = await gameRef.loadSprite( Assets.images.spaceship.ramp.boardOpening.keyName, );