From ee1a5a53681d62f0ed52c6fe146a91178f333ff0 Mon Sep 17 00:00:00 2001 From: Erick Zanardo Date: Fri, 11 Mar 2022 17:19:38 -0300 Subject: [PATCH] fix: flaky test --- test/game/components/ball_test.dart | 5 +++-- test/game/components/bonus_word_test.dart | 2 +- test/game/components/plunger_test.dart | 2 +- test/helpers/builders.dart | 4 ++-- 4 files changed, 7 insertions(+), 6 deletions(-) diff --git a/test/game/components/ball_test.dart b/test/game/components/ball_test.dart index 294a6f60..8ac32212 100644 --- a/test/game/components/ball_test.dart +++ b/test/game/components/ball_test.dart @@ -89,9 +89,10 @@ void main() { }); group('resetting a ball', () { - final gameBloc = MockGameBloc(); + late GameBloc gameBloc; setUp(() { + gameBloc = MockGameBloc(); whenListen( gameBloc, const Stream.empty(), @@ -99,7 +100,7 @@ void main() { ); }); - final tester = flameBlocTester(gameBloc: gameBloc); + final tester = flameBlocTester(gameBloc: () => gameBloc); tester.widgetTest( 'adds BallLost to GameBloc', diff --git a/test/game/components/bonus_word_test.dart b/test/game/components/bonus_word_test.dart index 33aec998..ca18e123 100644 --- a/test/game/components/bonus_word_test.dart +++ b/test/game/components/bonus_word_test.dart @@ -145,7 +145,7 @@ void main() { ); }); - final tester = flameBlocTester(gameBloc: gameBloc); + final tester = flameBlocTester(gameBloc: () => gameBloc); tester.widgetTest( 'adds BonusLetterActivated to GameBloc when not activated', diff --git a/test/game/components/plunger_test.dart b/test/game/components/plunger_test.dart index 02330b31..1ca29e85 100644 --- a/test/game/components/plunger_test.dart +++ b/test/game/components/plunger_test.dart @@ -227,7 +227,7 @@ void main() { ); }); - final flameTester = flameBlocTester(gameBloc: gameBloc); + final flameTester = flameBlocTester(gameBloc: () => gameBloc); group('initializes with', () { flameTester.test( diff --git a/test/helpers/builders.dart b/test/helpers/builders.dart index c77e55c5..d8ffd715 100644 --- a/test/helpers/builders.dart +++ b/test/helpers/builders.dart @@ -5,14 +5,14 @@ import 'package:pinball/game/game.dart'; import 'helpers.dart'; FlameTester flameBlocTester({ - required GameBloc gameBloc, + required GameBloc Function() gameBloc, }) { return FlameTester( PinballGameTest.create, pumpWidget: (gameWidget, tester) async { await tester.pumpWidget( BlocProvider.value( - value: gameBloc, + value: gameBloc(), child: gameWidget, ), );