From 5dfb171130050810eb7eb06fda2bf4d98551f59b Mon Sep 17 00:00:00 2001 From: Erick Date: Thu, 14 Apr 2022 10:42:09 -0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- .../lib/src/components/backboard/backboard.dart | 4 ++-- .../lib/src/flame/keyboard_input_controller.dart | 2 +- .../test/src/components/backboard_test.dart | 6 +++--- 3 files changed, 6 insertions(+), 6 deletions(-) diff --git a/packages/pinball_components/lib/src/components/backboard/backboard.dart b/packages/pinball_components/lib/src/components/backboard/backboard.dart index 07530fa4..c5c4ac17 100644 --- a/packages/pinball_components/lib/src/components/backboard/backboard.dart +++ b/packages/pinball_components/lib/src/components/backboard/backboard.dart @@ -55,7 +55,7 @@ class Backboard extends PositionComponent with HasGameRef { /// Puts the Backboard in waiting mode, where the scoreboard is shown. Future waitingMode() async { - children.removeWhere((element) => true); + children.removeWhere((_) => true); await add(BackboardWaiting()); } @@ -64,7 +64,7 @@ class Backboard extends PositionComponent with HasGameRef { required int score, BackboardOnSubmit? onSubmit, }) async { - children.removeWhere((element) => true); + children.removeWhere((_) => true); await add( BackboardGameOver( score: score, diff --git a/packages/pinball_components/lib/src/flame/keyboard_input_controller.dart b/packages/pinball_components/lib/src/flame/keyboard_input_controller.dart index d6a67459..8249e599 100644 --- a/packages/pinball_components/lib/src/flame/keyboard_input_controller.dart +++ b/packages/pinball_components/lib/src/flame/keyboard_input_controller.dart @@ -5,7 +5,7 @@ import 'package:flutter/services.dart'; typedef KeyHandlerCallback = bool Function(); /// {@template keyboard_input_controller} -/// A that receives keyboard input and execute registered methods +/// A [Component] that receives keyboard input and executes registered methods. /// {@endtemplate} class KeyboardInputController extends Component with KeyboardHandler { /// {@macro keyboard_input_controller} diff --git a/packages/pinball_components/test/src/components/backboard_test.dart b/packages/pinball_components/test/src/components/backboard_test.dart index 54d65570..5e868bfc 100644 --- a/packages/pinball_components/test/src/components/backboard_test.dart +++ b/packages/pinball_components/test/src/components/backboard_test.dart @@ -101,7 +101,7 @@ void main() { String? submitedInitials; tester.testGameWidget( - 'submits the initial', + 'submits the initials', setUp: (game, tester) async { final backboard = Backboard.gameOver( position: Vector2(0, 15), @@ -147,7 +147,7 @@ void main() { ); tester.testGameWidget( - "does nothing when don't have focus", + "does nothing when it doesn't have focus", setUp: (game, tester) async { await game.ensureAdd( BackboardLetterPrompt(position: Vector2.zero()), @@ -162,7 +162,7 @@ void main() { ); tester.testGameWidget( - 'blinks the promp when have focus', + 'blinks the prompt when it has the focus', setUp: (game, tester) async { await game.ensureAdd( BackboardLetterPrompt(position: Vector2.zero(), hasFocus: true),