From db177b1afed007a54b16bd16344af1f698807fd3 Mon Sep 17 00:00:00 2001 From: RuiAlonso Date: Thu, 28 Apr 2022 20:58:48 +0200 Subject: [PATCH] refactor: changed toggle to next at multipliers --- .../behaviors/multipliers_behavior.dart | 2 +- .../multiplier/cubit/multiplier_cubit.dart | 2 +- .../stories/multipliers/multipliers_game.dart | 2 +- .../multiplier/cubit/multiplier_cubit_test.dart | 16 ++++++++-------- .../behaviors/multipliers_behavior_test.dart | 4 ++-- 5 files changed, 13 insertions(+), 13 deletions(-) diff --git a/lib/game/components/multipliers/behaviors/multipliers_behavior.dart b/lib/game/components/multipliers/behaviors/multipliers_behavior.dart index b3f78dd8..5266e58f 100644 --- a/lib/game/components/multipliers/behaviors/multipliers_behavior.dart +++ b/lib/game/components/multipliers/behaviors/multipliers_behavior.dart @@ -19,7 +19,7 @@ class MultipliersBehavior extends Component final multipliers = parent.children.whereType(); for (final multiplier in multipliers) { - multiplier.bloc.toggle(state.multiplier); + multiplier.bloc.next(state.multiplier); } } }); diff --git a/packages/pinball_components/lib/src/components/multiplier/cubit/multiplier_cubit.dart b/packages/pinball_components/lib/src/components/multiplier/cubit/multiplier_cubit.dart index af0da7b1..35c565f3 100644 --- a/packages/pinball_components/lib/src/components/multiplier/cubit/multiplier_cubit.dart +++ b/packages/pinball_components/lib/src/components/multiplier/cubit/multiplier_cubit.dart @@ -16,7 +16,7 @@ class MultiplierCubit extends Cubit { ); /// Event added when the game current multiplier changes. - void toggle(int multiplier) { + void next(int multiplier) { if (state.equalsTo(multiplier)) { if (state.spriteState == MultiplierSpriteState.dimmed) { emit(state.copyWith(spriteState: MultiplierSpriteState.lit)); diff --git a/packages/pinball_components/sandbox/lib/stories/multipliers/multipliers_game.dart b/packages/pinball_components/sandbox/lib/stories/multipliers/multipliers_game.dart index 18e18a12..792d4954 100644 --- a/packages/pinball_components/sandbox/lib/stories/multipliers/multipliers_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/multipliers/multipliers_game.dart @@ -86,7 +86,7 @@ class MultipliersGame extends BallGame with KeyboardEvents { } for (final multiplier in multipliers) { - multiplier.bloc.toggle(currentMultiplier); + multiplier.bloc.next(currentMultiplier); } return KeyEventResult.handled; diff --git a/packages/pinball_components/test/src/components/multiplier/cubit/multiplier_cubit_test.dart b/packages/pinball_components/test/src/components/multiplier/cubit/multiplier_cubit_test.dart index 2ad3acea..f61edacc 100644 --- a/packages/pinball_components/test/src/components/multiplier/cubit/multiplier_cubit_test.dart +++ b/packages/pinball_components/test/src/components/multiplier/cubit/multiplier_cubit_test.dart @@ -9,9 +9,9 @@ void main() { 'MultiplierCubit', () { blocTest( - 'emits [lit] when toggle dimmed with same multiplier value', + "emits [lit] when 'next' on dimmed with same multiplier value", build: () => MultiplierCubit(MultiplierValue.x2), - act: (bloc) => bloc.toggle(2), + act: (bloc) => bloc.next(2), expect: () => [ isA() ..having( @@ -23,13 +23,13 @@ void main() { ); blocTest( - 'emits [dimmed] when toggle lit with different multiplier value', + "emits [dimmed] when 'next' on lit with different multiplier value", build: () => MultiplierCubit(MultiplierValue.x2), seed: () => MultiplierState( value: MultiplierValue.x2, spriteState: MultiplierSpriteState.lit, ), - act: (bloc) => bloc.toggle(3), + act: (bloc) => bloc.next(3), expect: () => [ isA() ..having( @@ -41,20 +41,20 @@ void main() { ); blocTest( - 'emits nothing when toggle lit with same multiplier value', + "emits nothing when 'next' on lit with same multiplier value", build: () => MultiplierCubit(MultiplierValue.x2), seed: () => MultiplierState( value: MultiplierValue.x2, spriteState: MultiplierSpriteState.lit, ), - act: (bloc) => bloc.toggle(2), + act: (bloc) => bloc.next(2), expect: () => [], ); blocTest( - 'emits nothing when toggle dimmed with different multiplier value', + "emits nothing when 'next' on dimmed with different multiplier value", build: () => MultiplierCubit(MultiplierValue.x2), - act: (bloc) => bloc.toggle(3), + act: (bloc) => bloc.next(3), expect: () => [], ); }, diff --git a/test/game/components/multipliers/behaviors/multipliers_behavior_test.dart b/test/game/components/multipliers/behaviors/multipliers_behavior_test.dart index 43f0d1ee..3ec10cf1 100644 --- a/test/game/components/multipliers/behaviors/multipliers_behavior_test.dart +++ b/test/game/components/multipliers/behaviors/multipliers_behavior_test.dart @@ -47,7 +47,7 @@ void main() { ); flameBlocTester.testGameWidget( - 'calls toggle once per each multiplier when GameBloc emit state', + "calls 'next' once per each multiplier when GameBloc emit state", setUp: (game, tester) async { final multiplierCubit = MockMultiplierCubit(); final behavior = MultipliersBehavior(); @@ -85,7 +85,7 @@ void main() { for (final multiplier in multipliers) { verify( - () => multiplier.bloc.toggle(any()), + () => multiplier.bloc.next(any()), ).called(1); } },