From ca1317231284a8ae7ea2cac8923a0696dd756fb8 Mon Sep 17 00:00:00 2001 From: arturplaczek Date: Thu, 28 Apr 2022 20:46:00 +0200 Subject: [PATCH] fix: apply self review --- lib/select_character/select_character.dart | 1 + lib/select_character/widgets/character_icon.dart | 3 +-- lib/select_character/widgets/selected_character.dart | 5 +++-- lib/select_character/widgets/star_animation.dart | 4 ++-- test/select_character/widgets/selected_character_test.dart | 3 ++- 5 files changed, 9 insertions(+), 7 deletions(-) diff --git a/lib/select_character/select_character.dart b/lib/select_character/select_character.dart index 40699840..827be100 100644 --- a/lib/select_character/select_character.dart +++ b/lib/select_character/select_character.dart @@ -1,2 +1,3 @@ export 'cubit/character_theme_cubit.dart'; export 'view/view.dart'; +export 'widgets/widgets.dart'; diff --git a/lib/select_character/widgets/character_icon.dart b/lib/select_character/widgets/character_icon.dart index aa697201..3da77903 100644 --- a/lib/select_character/widgets/character_icon.dart +++ b/lib/select_character/widgets/character_icon.dart @@ -4,13 +4,12 @@ import 'package:pinball/select_character/select_character.dart'; import 'package:pinball_theme/pinball_theme.dart' hide Assets; /// {@template character_icon} -/// Widget for displaying character icon. +/// Widget to display character icon. /// /// On tap changes selected character in [CharacterThemeCubit]. /// {@endtemplate} class CharacterIcon extends StatelessWidget { /// {@macro character_icon} - const CharacterIcon( CharacterTheme characterTheme, { Key? key, diff --git a/lib/select_character/widgets/selected_character.dart b/lib/select_character/widgets/selected_character.dart index 0e9dd430..0b6fc758 100644 --- a/lib/select_character/widgets/selected_character.dart +++ b/lib/select_character/widgets/selected_character.dart @@ -11,7 +11,8 @@ import 'package:pinball_theme/pinball_theme.dart'; /// Widget to display the selected character based on the [CharacterThemeCubit] /// state. /// -/// Displays a looped [SpriteAnimationWidget]. +/// Displays the looped [SpriteAnimationWidget] and the character name on the +/// list. /// {@endtemplate} class SelectedCharacter extends StatefulWidget { /// {@macro selected_character} @@ -22,7 +23,7 @@ class SelectedCharacter extends StatefulWidget { @override State createState() => _SelectedCharacterState(); - /// Returns a list of assets to be loaded + /// Returns a list of assets to be loaded. static List loadAssets() { Flame.images.prefix = ''; diff --git a/lib/select_character/widgets/star_animation.dart b/lib/select_character/widgets/star_animation.dart index 662420fb..62b0de4a 100644 --- a/lib/select_character/widgets/star_animation.dart +++ b/lib/select_character/widgets/star_animation.dart @@ -7,7 +7,7 @@ import 'package:pinball/gen/gen.dart'; /// {@template star_animation} /// Widget to display a looped the star animation. /// -/// For animation is using [SpriteAnimationWidget]. +/// For animation uses [SpriteAnimationWidget]. /// {@endtemplate} class StarAnimation extends StatelessWidget { const StarAnimation._({ @@ -60,7 +60,7 @@ class StarAnimation extends StatelessWidget { final int _rows; final double _stepTime; - /// Returns a list of assets to be loaded + /// Returns a list of assets to be loaded. static Future loadAssets() { Flame.images.prefix = ''; diff --git a/test/select_character/widgets/selected_character_test.dart b/test/select_character/widgets/selected_character_test.dart index 8e379ebd..70ccf3fc 100644 --- a/test/select_character/widgets/selected_character_test.dart +++ b/test/select_character/widgets/selected_character_test.dart @@ -11,6 +11,7 @@ import '../../helpers/helpers.dart'; void main() { TestWidgetsFlutterBinding.ensureInitialized(); + late CharacterThemeCubit characterThemeCubit; setUpAll(() async { @@ -29,7 +30,7 @@ void main() { }); group('SelectedCharacter', () { - testWidgets('loadAssets returns list of futures', (tester) async { + testWidgets('loadAssets method returns list of futures', (tester) async { expect(SelectedCharacter.loadAssets(), isList); });