From b1cf5249353e986f531a6837ddfea6d2547e3246 Mon Sep 17 00:00:00 2001 From: RuiAlonso Date: Tue, 26 Apr 2022 20:51:23 +0200 Subject: [PATCH] chore: unused import --- lib/game/components/controlled_multiball.dart | 4 +- .../test/src/components/multiball_test.dart | 76 +++++++++++++------ .../components/controlled_multiball_test.dart | 1 - 3 files changed, 56 insertions(+), 25 deletions(-) diff --git a/lib/game/components/controlled_multiball.dart b/lib/game/components/controlled_multiball.dart index cdebea24..cf36a1a3 100644 --- a/lib/game/components/controlled_multiball.dart +++ b/lib/game/components/controlled_multiball.dart @@ -41,9 +41,9 @@ class MultiballController extends ComponentController @override void onNewState(GameState state) { - final isMultiball = state.bonusHistory.contains(GameBonus.dashNest); + final hasMultiball = state.bonusHistory.contains(GameBonus.dashNest); - if (isMultiball) { + if (hasMultiball) { component.children.whereType().forEach((element) { element.animate(); }); diff --git a/packages/pinball_components/test/src/components/multiball_test.dart b/packages/pinball_components/test/src/components/multiball_test.dart index 7f47c9a2..4d39c130 100644 --- a/packages/pinball_components/test/src/components/multiball_test.dart +++ b/packages/pinball_components/test/src/components/multiball_test.dart @@ -22,30 +22,62 @@ void main() { final flameTester = FlameTester(() => TestGame(assets)); group('Multiball', () { - flameTester.test('"a" loads correctly', (game) async { - final multiball = Multiball.a(); - await game.ensureAdd(multiball); - - expect(game.contains(multiball), isTrue); - }); - - flameTester.test('"b" loads correctly', (game) async { - final multiball = Multiball.b(); - await game.ensureAdd(multiball); - expect(game.contains(multiball), isTrue); + group('loads correctly', () { + flameTester.test('"a"', (game) async { + final multiball = Multiball.a(); + await game.ensureAdd(multiball); + + expect(game.contains(multiball), isTrue); + }); + + flameTester.test('"b"', (game) async { + final multiball = Multiball.b(); + await game.ensureAdd(multiball); + expect(game.contains(multiball), isTrue); + }); + + flameTester.test('"c"', (game) async { + final multiball = Multiball.c(); + await game.ensureAdd(multiball); + + expect(game.contains(multiball), isTrue); + }); + + flameTester.test('"d"', (game) async { + final multiball = Multiball.d(); + await game.ensureAdd(multiball); + expect(game.contains(multiball), isTrue); + }); }); - flameTester.test('"c" loads correctly', (game) async { - final multiball = Multiball.c(); - await game.ensureAdd(multiball); - - expect(game.contains(multiball), isTrue); - }); - - flameTester.test('"d" loads correctly', (game) async { - final multiball = Multiball.d(); - await game.ensureAdd(multiball); - expect(game.contains(multiball), isTrue); + group('renders correctly', () { + flameTester.testGameWidget( + "'a'", + setUp: (game, tester) async { + await game.images.loadAll(assets); + final multiball = Multiball.d(); + await game.ensureAdd(multiball); + + multiball.animate(); + await tester.pump(); + + expect( + multiball.children + .whereType() + .first + .current, + MultiballSpriteState.active, + ); + + game.camera.followVector2(Vector2.zero()); + }, + verify: (game, tester) async { + await expectLater( + find.byGame(), + matchesGoldenFile('golden/multiball/a-active.png'), + ); + }, + ); }); flameTester.test('animate switches between on and off sprites', diff --git a/test/game/components/controlled_multiball_test.dart b/test/game/components/controlled_multiball_test.dart index 49768a7d..ad02095e 100644 --- a/test/game/components/controlled_multiball_test.dart +++ b/test/game/components/controlled_multiball_test.dart @@ -2,7 +2,6 @@ import 'package:flame_test/flame_test.dart'; import 'package:flutter_test/flutter_test.dart'; -import 'package:mocktail/mocktail.dart'; import 'package:pinball/game/game.dart'; import 'package:pinball_components/pinball_components.dart';