From a20c2141e56dabd07c434b6086e11fad1b87f8b7 Mon Sep 17 00:00:00 2001 From: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> Date: Sun, 8 May 2022 19:14:13 -0500 Subject: [PATCH] fix: commas in share score (#423) --- lib/game/components/backbox/backbox.dart | 2 +- lib/l10n/arb/app_en.arb | 2 +- test/game/components/backbox/backbox_test.dart | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/lib/game/components/backbox/backbox.dart b/lib/game/components/backbox/backbox.dart index dad2c118..3b3b2614 100644 --- a/lib/game/components/backbox/backbox.dart +++ b/lib/game/components/backbox/backbox.dart @@ -109,7 +109,7 @@ class Backbox extends PositionComponent with ZIndex, HasGameRef { ShareDisplay( onShare: (platform) { final message = readProvider() - .iGotScoreAtPinball(state.score); + .iGotScoreAtPinball(state.score.formatScore()); final url = _shareRepository.shareText( value: message, platform: platform, diff --git a/lib/l10n/arb/app_en.arb b/lib/l10n/arb/app_en.arb index a9b12291..64093ac6 100644 --- a/lib/l10n/arb/app_en.arb +++ b/lib/l10n/arb/app_en.arb @@ -218,7 +218,7 @@ "description": "Text to share score on Social Network", "placeholders": { "score": { - "type": "int" + "type": "String" } } } diff --git a/test/game/components/backbox/backbox_test.dart b/test/game/components/backbox/backbox_test.dart index cfc2437a..6fb87c7c 100644 --- a/test/game/components/backbox/backbox_test.dart +++ b/test/game/components/backbox/backbox_test.dart @@ -161,7 +161,7 @@ class _MockAppLocalizations extends Mock implements AppLocalizations { String get leaderboardErrorMessage => ''; @override - String iGotScoreAtPinball(int _) => ''; + String iGotScoreAtPinball(String _) => ''; } void main() {