From 9a5284f84bafcc50563676386516fe086859e83b Mon Sep 17 00:00:00 2001 From: Alejandro Santiago Date: Tue, 12 Apr 2022 09:02:00 +0100 Subject: [PATCH] refactor(sandbox): made BasicBallGame color optional (#171) --- .../sandbox/lib/stories/ball/ball_booster_game.dart | 2 +- .../sandbox/lib/stories/ball/basic_ball_game.dart | 2 +- .../sandbox/lib/stories/boundaries/boundaries_game.dart | 2 -- .../sandbox/lib/stories/effects/fire_effect_game.dart | 2 +- .../sandbox/lib/stories/flipper/flipper_game.dart | 2 -- .../stories/flutter_forest/big_dash_nest_bumper_game.dart | 3 --- .../lib/stories/flutter_forest/flutter_sign_post_game.dart | 3 --- .../flutter_forest/small_dash_nest_bumper_a_game.dart | 3 --- .../flutter_forest/small_dash_nest_bumper_b_game.dart | 3 --- .../sandbox/lib/stories/kicker/kicker_game.dart | 2 -- .../sandbox/lib/stories/layer/basic_layer_game.dart | 2 +- .../sandbox/lib/stories/slingshot/slingshot_game.dart | 2 -- .../sandbox/lib/stories/spaceship/basic_spaceship_game.dart | 2 +- .../lib/stories/sparky_bumper/sparky_bumper_game.dart | 4 +--- .../sandbox/lib/stories/zoom/basic_zoom_game.dart | 5 +++-- 15 files changed, 9 insertions(+), 30 deletions(-) diff --git a/packages/pinball_components/sandbox/lib/stories/ball/ball_booster_game.dart b/packages/pinball_components/sandbox/lib/stories/ball/ball_booster_game.dart index 3b8fe149..2fa4462e 100644 --- a/packages/pinball_components/sandbox/lib/stories/ball/ball_booster_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/ball/ball_booster_game.dart @@ -7,7 +7,7 @@ class BallBoosterGame extends LineGame { static const info = ''' Shows how a Ball with a boost works. - Drag to launch a boosted Ball. + - Drag to launch a boosted Ball. '''; @override diff --git a/packages/pinball_components/sandbox/lib/stories/ball/basic_ball_game.dart b/packages/pinball_components/sandbox/lib/stories/ball/basic_ball_game.dart index 4fbeae1b..17bd0723 100644 --- a/packages/pinball_components/sandbox/lib/stories/ball/basic_ball_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/ball/basic_ball_game.dart @@ -5,7 +5,7 @@ import 'package:sandbox/common/common.dart'; class BasicBallGame extends BasicGame with TapDetector, Traceable { BasicBallGame({ - required this.color, + this.color = Colors.blue, this.ballPriority = 0, this.ballLayer = Layer.all, }); diff --git a/packages/pinball_components/sandbox/lib/stories/boundaries/boundaries_game.dart b/packages/pinball_components/sandbox/lib/stories/boundaries/boundaries_game.dart index a98fb7b9..0bc2755d 100644 --- a/packages/pinball_components/sandbox/lib/stories/boundaries/boundaries_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/boundaries/boundaries_game.dart @@ -4,8 +4,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class BoundariesGame extends BasicBallGame with Traceable { - BoundariesGame() : super(color: const Color(0xFFFF0000)); - static const info = ''' Shows how Boundaries are rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/effects/fire_effect_game.dart b/packages/pinball_components/sandbox/lib/stories/effects/fire_effect_game.dart index ecc22910..9e2acaf4 100644 --- a/packages/pinball_components/sandbox/lib/stories/effects/fire_effect_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/effects/fire_effect_game.dart @@ -6,7 +6,7 @@ class FireEffectGame extends LineGame { static const info = ''' Shows how the FireEffect renders. - Drag a line to define the trail direction. + - Drag a line to define the trail direction. '''; @override diff --git a/packages/pinball_components/sandbox/lib/stories/flipper/flipper_game.dart b/packages/pinball_components/sandbox/lib/stories/flipper/flipper_game.dart index 5a9e1787..c0dfee24 100644 --- a/packages/pinball_components/sandbox/lib/stories/flipper/flipper_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/flipper/flipper_game.dart @@ -7,8 +7,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class FlipperGame extends BasicBallGame with KeyboardEvents, Traceable { - FlipperGame() : super(color: Colors.blue); - static const info = ''' Shows how Flippers are rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/flutter_forest/big_dash_nest_bumper_game.dart b/packages/pinball_components/sandbox/lib/stories/flutter_forest/big_dash_nest_bumper_game.dart index c1407819..e74abe35 100644 --- a/packages/pinball_components/sandbox/lib/stories/flutter_forest/big_dash_nest_bumper_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/flutter_forest/big_dash_nest_bumper_game.dart @@ -1,5 +1,4 @@ import 'dart:async'; -import 'dart:ui'; import 'package:flame_forge2d/flame_forge2d.dart'; import 'package:pinball_components/pinball_components.dart'; @@ -7,8 +6,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class BigDashNestBumperGame extends BasicBallGame with Traceable { - BigDashNestBumperGame() : super(color: const Color(0xFF0000FF)); - static const info = ''' Shows how a BigDashNestBumper is rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/flutter_forest/flutter_sign_post_game.dart b/packages/pinball_components/sandbox/lib/stories/flutter_forest/flutter_sign_post_game.dart index f3ba7bda..3efb83fe 100644 --- a/packages/pinball_components/sandbox/lib/stories/flutter_forest/flutter_sign_post_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/flutter_forest/flutter_sign_post_game.dart @@ -1,5 +1,4 @@ import 'dart:async'; -import 'dart:ui'; import 'package:flame_forge2d/flame_forge2d.dart'; import 'package:pinball_components/pinball_components.dart'; @@ -7,8 +6,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class FlutterSignPostGame extends BasicBallGame with Traceable { - FlutterSignPostGame() : super(color: const Color(0xFF0000FF)); - static const info = ''' Shows how a FlutterSignPost is rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_a_game.dart b/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_a_game.dart index a8499581..4ef99b21 100644 --- a/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_a_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_a_game.dart @@ -1,5 +1,4 @@ import 'dart:async'; -import 'dart:ui'; import 'package:flame_forge2d/flame_forge2d.dart'; import 'package:pinball_components/pinball_components.dart'; @@ -7,8 +6,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class SmallDashNestBumperAGame extends BasicBallGame with Traceable { - SmallDashNestBumperAGame() : super(color: const Color(0xFF0000FF)); - static const info = ''' Shows how a SmallDashNestBumper ("a") is rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_b_game.dart b/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_b_game.dart index 91b2a383..625b8e5c 100644 --- a/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_b_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/flutter_forest/small_dash_nest_bumper_b_game.dart @@ -1,5 +1,4 @@ import 'dart:async'; -import 'dart:ui'; import 'package:flame_forge2d/flame_forge2d.dart'; import 'package:pinball_components/pinball_components.dart'; @@ -7,8 +6,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class SmallDashNestBumperBGame extends BasicBallGame with Traceable { - SmallDashNestBumperBGame() : super(color: const Color(0xFF0000FF)); - static const info = ''' Shows how a SmallDashNestBumper ("b") is rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/kicker/kicker_game.dart b/packages/pinball_components/sandbox/lib/stories/kicker/kicker_game.dart index 1b29c3f9..add7b205 100644 --- a/packages/pinball_components/sandbox/lib/stories/kicker/kicker_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/kicker/kicker_game.dart @@ -4,8 +4,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class KickerGame extends BasicBallGame with Traceable { - KickerGame() : super(color: const Color(0xFFFF0000)); - static const info = ''' Shows how Kickers are rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/layer/basic_layer_game.dart b/packages/pinball_components/sandbox/lib/stories/layer/basic_layer_game.dart index a6361094..60d72ff3 100644 --- a/packages/pinball_components/sandbox/lib/stories/layer/basic_layer_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/layer/basic_layer_game.dart @@ -10,7 +10,7 @@ class BasicLayerGame extends BasicGame with TapDetector { static const info = ''' Shows how Layers work when a Ball hits other components. - Tap anywhere on the screen to spawn a Ball into the game. + - Tap anywhere on the screen to spawn a Ball into the game. '''; final Color color; diff --git a/packages/pinball_components/sandbox/lib/stories/slingshot/slingshot_game.dart b/packages/pinball_components/sandbox/lib/stories/slingshot/slingshot_game.dart index 8d54f391..dd1df4de 100644 --- a/packages/pinball_components/sandbox/lib/stories/slingshot/slingshot_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/slingshot/slingshot_game.dart @@ -4,8 +4,6 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class SlingshotGame extends BasicBallGame with Traceable { - SlingshotGame() : super(color: const Color(0xFFFF0000)); - static const info = ''' Shows how Slingshots are rendered. diff --git a/packages/pinball_components/sandbox/lib/stories/spaceship/basic_spaceship_game.dart b/packages/pinball_components/sandbox/lib/stories/spaceship/basic_spaceship_game.dart index 97124c3f..95afcd7f 100644 --- a/packages/pinball_components/sandbox/lib/stories/spaceship/basic_spaceship_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/spaceship/basic_spaceship_game.dart @@ -9,7 +9,7 @@ class BasicSpaceshipGame extends BasicGame with TapDetector { static const info = ''' Shows how a Spaceship works. - Tap anywhere on the screen to spawn a Ball into the game. + - Tap anywhere on the screen to spawn a Ball into the game. '''; @override diff --git a/packages/pinball_components/sandbox/lib/stories/sparky_bumper/sparky_bumper_game.dart b/packages/pinball_components/sandbox/lib/stories/sparky_bumper/sparky_bumper_game.dart index a57beb8d..37537952 100644 --- a/packages/pinball_components/sandbox/lib/stories/sparky_bumper/sparky_bumper_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/sparky_bumper/sparky_bumper_game.dart @@ -6,12 +6,10 @@ import 'package:sandbox/common/common.dart'; import 'package:sandbox/stories/ball/basic_ball_game.dart'; class SparkyBumperGame extends BasicBallGame with Traceable { - SparkyBumperGame() : super(color: const Color(0xFF0000FF)); - static const info = ''' Shows how a SparkyBumper is rendered. - Activate the "trace" parameter to overlay the body. + - Activate the "trace" parameter to overlay the body. '''; @override diff --git a/packages/pinball_components/sandbox/lib/stories/zoom/basic_zoom_game.dart b/packages/pinball_components/sandbox/lib/stories/zoom/basic_zoom_game.dart index 276dd39c..7e6d035f 100644 --- a/packages/pinball_components/sandbox/lib/stories/zoom/basic_zoom_game.dart +++ b/packages/pinball_components/sandbox/lib/stories/zoom/basic_zoom_game.dart @@ -5,8 +5,9 @@ import 'package:sandbox/common/common.dart'; class BasicCameraZoomGame extends BasicGame with TapDetector { static const info = ''' - Simple game to demonstrate how the CameraZoom can be used. - Tap to zoom in/out + Shows how CameraZoom can be used. + + - Tap to zoom in/out. '''; bool zoomApplied = false;