From 8075457b9184a7707ad163664784b3ccbf3c250b Mon Sep 17 00:00:00 2001 From: Jonathan Daniels Date: Mon, 25 Apr 2022 12:31:02 -0700 Subject: [PATCH] chore: addressed review feedback --- .../lib/src/leaderboard_repository.dart | 10 +++------- .../test/src/leaderboard_repository_test.dart | 2 +- 2 files changed, 4 insertions(+), 8 deletions(-) diff --git a/packages/leaderboard_repository/lib/src/leaderboard_repository.dart b/packages/leaderboard_repository/lib/src/leaderboard_repository.dart index af7383b7..9d8b2434 100644 --- a/packages/leaderboard_repository/lib/src/leaderboard_repository.dart +++ b/packages/leaderboard_repository/lib/src/leaderboard_repository.dart @@ -180,13 +180,9 @@ class LeaderboardRepository { .collection('prohibitedInitials') .doc('list') .get(); - final prohibitedInitials = List.from( - document.get('prohibitedInitials') as List, - ); - final isProhibited = prohibitedInitials.contains( - initials.trim().toLowerCase(), - ); - return !isProhibited; + final prohibitedInitials = + document.get('prohibitedInitials') as List; + return !prohibitedInitials.contains(initials); } on Exception catch (error, stackTrace) { throw FetchProhibitedInitialsException(error, stackTrace); } diff --git a/packages/leaderboard_repository/test/src/leaderboard_repository_test.dart b/packages/leaderboard_repository/test/src/leaderboard_repository_test.dart index 8ecb7103..9d31983f 100644 --- a/packages/leaderboard_repository/test/src/leaderboard_repository_test.dart +++ b/packages/leaderboard_repository/test/src/leaderboard_repository_test.dart @@ -246,7 +246,7 @@ void main() { when(() => documentReference.get()) .thenAnswer((_) async => documentSnapshot); when(() => documentSnapshot.get('prohibitedInitials')) - .thenReturn(['bad']); + .thenReturn(['BAD']); }); test('returns true if initials are three letters and allowed', () async {