From 7e0d2c6cac7f2ea4ac9e2cd5a48c7442c305c982 Mon Sep 17 00:00:00 2001
From: alestiago <dev@alestiago.com>
Date: Tue, 10 May 2022 10:46:53 +0100
Subject: [PATCH] test: made overlays test more robust

---
 test/game/view/pinball_game_page_test.dart | 14 ++++++++------
 1 file changed, 8 insertions(+), 6 deletions(-)

diff --git a/test/game/view/pinball_game_page_test.dart b/test/game/view/pinball_game_page_test.dart
index 4defb5b6..3f343dfe 100644
--- a/test/game/view/pinball_game_page_test.dart
+++ b/test/game/view/pinball_game_page_test.dart
@@ -302,15 +302,16 @@ void main() {
     });
 
     testWidgets('mobile controls when the overlay is added', (tester) async {
+      const targetOverlay = PinballGame.mobileControlsOverlay;
       await tester.pumpApp(
         PinballGameView(game),
         gameBloc: gameBloc,
         startGameBloc: startGameBloc,
       );
 
-      game.overlays.remove(PinballGame.playButtonOverlay);
-      game.overlays.add(PinballGame.mobileControlsOverlay);
-
+      game.overlays.clear();
+      await tester.pump();
+      game.overlays.add(targetOverlay);
       await tester.pump();
 
       expect(find.byType(MobileControls), findsOneWidget);
@@ -319,15 +320,16 @@ void main() {
     testWidgets(
       'ReplayButtonOverlay when the overlay is added',
       (tester) async {
+        const targetOverlay = PinballGame.replayButtonOverlay;
         await tester.pumpApp(
           PinballGameView(game),
           gameBloc: gameBloc,
           startGameBloc: startGameBloc,
         );
 
-        game.overlays.remove(PinballGame.playButtonOverlay);
-        game.overlays.add(PinballGame.replayButtonOverlay);
-
+        game.overlays.clear();
+        await tester.pump();
+        game.overlays.add(targetOverlay);
         await tester.pump();
 
         expect(find.byType(ReplayButtonOverlay), findsOneWidget);