Merge branch 'main' into feat/kicker-sound

lib/assets_manager/cubit/assets_manager_cubit.dart

@@ -18,7 +18,7 @@ class AssetsManagerCubit extends Cubit<AssetsManagerState> {
     /// delay here, which is a bit random in duration but enough to let the UI
     /// do its job without adding too much delay for the user, we are letting
     /// the UI paint first, and then we start loading the assets.
-    await Future<void>.delayed(const Duration(milliseconds: 300));
+    await Future<void>.delayed(const Duration(seconds: 1));
     emit(
       state.copyWith(
         loadables: [

lib/game/bloc/game_bloc.dart

@@ -16,6 +16,8 @@ class GameBloc extends Bloc<GameEvent, GameState> {
     on<GameStarted>(_onGameStarted);
   }
 
+  static const _maxScore = 9999999999;
+
   void _onGameStarted(GameStarted _, Emitter emit) {
     emit(state.copyWith(status: GameStatus.playing));
   }
@@ -25,7 +27,10 @@ class GameBloc extends Bloc<GameEvent, GameState> {
   }
 
   void _onRoundLost(RoundLost event, Emitter emit) {
-    final score = state.totalScore + state.roundScore * state.multiplier;
+    final score = math.min(
+      state.totalScore + state.roundScore * state.multiplier,
+      _maxScore,
+    );
     final roundsLeft = math.max(state.rounds - 1, 0);
 
     emit(
@@ -41,9 +46,11 @@ class GameBloc extends Bloc<GameEvent, GameState> {
 
   void _onScored(Scored event, Emitter emit) {
     if (state.status.isPlaying) {
-      emit(
-        state.copyWith(roundScore: state.roundScore + event.points),
+      final combinedScore = math.min(
+        state.totalScore + state.roundScore + event.points,
+        _maxScore,
       );
+      emit(state.copyWith(roundScore: combinedScore - state.totalScore));
     }
   }
 

lib/game/components/android_acres/android_acres.dart

@@ -47,6 +47,7 @@ class AndroidAcres extends Component {
                 AndroidBumper.cow(
                   children: [
                     ScoringContactBehavior(points: Points.twentyThousand),
+                    BumperNoiseBehavior(),
                     CowBumperNoiseBehavior(),
                   ],
                 )..initialPosition = Vector2(-20.7, -13),

test/app/view/app_test.dart

@@ -41,7 +41,7 @@ void main() {
           pinballAudioPlayer: pinballAudioPlayer,
         ),
       );
-      await tester.pump(const Duration(milliseconds: 400));
+      await tester.pump(const Duration(milliseconds: 1100));
       expect(find.byType(PinballGamePage), findsOneWidget);
     });
   });

test/game/bloc/game_bloc_test.dart

@@ -91,6 +91,28 @@ void main() {
         ],
       );
 
+      blocTest<GameBloc, GameState>(
+        "multiplier doesn't increase score above the max score",
+        build: GameBloc.new,
+        seed: () => const GameState(
+          totalScore: 9999999998,
+          roundScore: 1,
+          multiplier: 2,
+          rounds: 1,
+          bonusHistory: [],
+          status: GameStatus.playing,
+        ),
+        act: (bloc) => bloc.add(const RoundLost()),
+        expect: () => [
+          isA<GameState>()
+            ..having(
+              (state) => state.totalScore,
+              'totalScore',
+              9999999999,
+            )
+        ],
+      );
+
       blocTest<GameBloc, GameState>(
         'resets multiplier when round is lost',
         build: GameBloc.new,
@@ -167,6 +189,23 @@ void main() {
             ),
         ],
       );
+
+      blocTest<GameBloc, GameState>(
+        "doesn't increase score above the max score",
+        build: GameBloc.new,
+        seed: () => const GameState(
+          totalScore: 9999999998,
+          roundScore: 0,
+          multiplier: 1,
+          rounds: 1,
+          bonusHistory: [],
+          status: GameStatus.playing,
+        ),
+        act: (bloc) => bloc.add(const Scored(points: 2)),
+        expect: () => [
+          isA<GameState>()..having((state) => state.roundScore, 'roundScore', 1)
+        ],
+      );
     });
 
     group('MultiplierIncreased', () {

test/game/components/android_acres/android_acres_test.dart

@@ -117,18 +117,16 @@ void main() {
       );
 
       flameTester.test(
-        'two AndroidBumpers with BumperNoiseBehavior',
+        'three AndroidBumpers with BumperNoiseBehavior',
         (game) async {
           await game.pump(AndroidAcres());
           final bumpers = game.descendants().whereType<AndroidBumper>();
-          var behaviorCount = 0;
           for (final bumper in bumpers) {
-            if (bumper.firstChild<BumperNoiseBehavior>() != null) {
-              behaviorCount++;
-            }
+            expect(
+              bumper.firstChild<BumperNoiseBehavior>(),
+              isA<BumperNoiseBehavior>(),
+            );
           }
-
-          expect(behaviorCount, equals(2));
         },
       );