From 43ceb0db327f5266e96834d01aab96ef34dff404 Mon Sep 17 00:00:00 2001 From: Jorge Coca Date: Mon, 9 May 2022 11:02:29 -0500 Subject: [PATCH 1/3] fix: await firebase init and anonymous auth (#439) --- lib/main.dart | 9 ++------- 1 file changed, 2 insertions(+), 7 deletions(-) diff --git a/lib/main.dart b/lib/main.dart index 877843ee..11bf35aa 100644 --- a/lib/main.dart +++ b/lib/main.dart @@ -1,5 +1,3 @@ -import 'dart:async'; - import 'package:authentication_repository/authentication_repository.dart'; import 'package:firebase_core/firebase_core.dart'; import 'package:leaderboard_repository/leaderboard_repository.dart'; @@ -17,11 +15,8 @@ void main() { final authenticationRepository = AuthenticationRepository(firebaseAuth); final pinballAudioPlayer = PinballAudioPlayer(); final platformHelper = PlatformHelper(); - unawaited( - Firebase.initializeApp().then( - (_) => authenticationRepository.authenticateAnonymously(), - ), - ); + await Firebase.initializeApp(); + await authenticationRepository.authenticateAnonymously(); return App( authenticationRepository: authenticationRepository, leaderboardRepository: leaderboardRepository, From 03c472837274afe1f13a2c248d63d754fa52fb91 Mon Sep 17 00:00:00 2001 From: Jorge Coca Date: Mon, 9 May 2022 11:52:36 -0500 Subject: [PATCH 2/3] fix: open source link not opening on mobile (#440) --- .../components/backbox/displays/game_over_info_display.dart | 2 +- .../backbox/displays/game_over_info_display_test.dart | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/game/components/backbox/displays/game_over_info_display.dart b/lib/game/components/backbox/displays/game_over_info_display.dart index 52939345..0ac160ee 100644 --- a/lib/game/components/backbox/displays/game_over_info_display.dart +++ b/lib/game/components/backbox/displays/game_over_info_display.dart @@ -290,7 +290,7 @@ class OpenSourceTextComponent extends TextComponent with HasGameRef, Tappable { ); @override - bool onTapDown(TapDownInfo info) { + bool onTapUp(TapUpInfo info) { openLink(ShareRepository.openSourceCode); return true; } diff --git a/test/game/components/backbox/displays/game_over_info_display_test.dart b/test/game/components/backbox/displays/game_over_info_display_test.dart index 2bee4005..bb092347 100644 --- a/test/game/components/backbox/displays/game_over_info_display_test.dart +++ b/test/game/components/backbox/displays/game_over_info_display_test.dart @@ -176,7 +176,7 @@ void main() { final openSourceLink = component.descendants().whereType().first; - openSourceLink.onTapDown(_MockTapDownInfo()); + openSourceLink.onTapUp(_MockTapUpInfo()); await game.ready(); From 0d52fcd72a2c3100563c0065376c6166d8d858e2 Mon Sep 17 00:00:00 2001 From: Elizabeth Gaston Date: Mon, 9 May 2022 12:36:59 -0500 Subject: [PATCH 3/3] chore: Update text for sharing to social media (#429) * chore: Update text for sharing to social media * Update app_en.arb * Adding line break Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> --- lib/l10n/arb/app_en.arb | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/l10n/arb/app_en.arb b/lib/l10n/arb/app_en.arb index 64093ac6..6b6e55aa 100644 --- a/lib/l10n/arb/app_en.arb +++ b/lib/l10n/arb/app_en.arb @@ -213,7 +213,7 @@ "@socialMediaAccount": { "description": "Text displayed on share screen for description" }, - "iGotScoreAtPinball": "I got {score} at the #IOPinball machine, can you beat my score? See you at #GoogleIO!", + "iGotScoreAtPinball": "I got {score} points in #IOPinball, can you beat my score? \nSee you at #GoogleIO!", "@iGotScoreAtPinball": { "description": "Text to share score on Social Network", "placeholders": {