From 61ed719bc540aadd2bb13289f50edde21d4531c1 Mon Sep 17 00:00:00 2001
From: Alejandro Santiago <dev@alestiago.com>
Date: Thu, 28 Apr 2022 21:50:57 +0100
Subject: [PATCH] fix: flipper not fully locking (#175)

* fix: waited for game to unlock

* fix: flipper lock

Co-authored-by: Allison Ryan <allisonryan0002@gmail.com>
Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com>
---
 .../lib/src/components/flipper.dart             | 17 +++++++++++------
 1 file changed, 11 insertions(+), 6 deletions(-)

diff --git a/packages/pinball_components/lib/src/components/flipper.dart b/packages/pinball_components/lib/src/components/flipper.dart
index dccd7ce7..bb982e96 100644
--- a/packages/pinball_components/lib/src/components/flipper.dart
+++ b/packages/pinball_components/lib/src/components/flipper.dart
@@ -55,7 +55,6 @@ class Flipper extends BodyComponent with KeyboardHandler, InitialPosition {
     );
     final joint = _FlipperJoint(jointDef);
     world.createJoint(joint);
-    unawaited(mounted.whenComplete(joint.unlock));
   }
 
   List<FixtureDef> _createFixtureDefs() {
@@ -132,6 +131,15 @@ class Flipper extends BodyComponent with KeyboardHandler, InitialPosition {
 
     return body;
   }
+
+  @override
+  void onMount() {
+    super.onMount();
+
+    gameRef.ready().whenComplete(
+          () => body.joints.whereType<_FlipperJoint>().first.unlock(),
+        );
+  }
 }
 
 class _FlipperSpriteComponent extends SpriteComponent with HasGameRef {
@@ -215,11 +223,8 @@ class _FlipperJoint extends RevoluteJoint {
   /// The joint is locked when initialized in order to force the [Flipper]
   /// at its resting position.
   void lock() {
-    const angle = _halfSweepingAngle;
-    setLimits(
-      angle * side.direction,
-      angle * side.direction,
-    );
+    final angle = _halfSweepingAngle * side.direction;
+    setLimits(angle, angle);
   }
 
   /// Unlocks the [Flipper] from its resting position.