From 61744cf0dd8d1cc3047698457ebf35fa680af862 Mon Sep 17 00:00:00 2001 From: Erick Zanardo Date: Thu, 14 Apr 2022 11:41:45 -0300 Subject: [PATCH] feat: pr suggestions --- .../src/components/backboard/backboard_game_over.dart | 5 +---- .../lib/src/extensions/extensions.dart | 1 + .../pinball_components/lib/src/extensions/score.dart | 11 +++++++++++ .../lib/src/pinball_components.dart | 1 + 4 files changed, 14 insertions(+), 4 deletions(-) create mode 100644 packages/pinball_components/lib/src/extensions/extensions.dart create mode 100644 packages/pinball_components/lib/src/extensions/score.dart diff --git a/packages/pinball_components/lib/src/components/backboard/backboard_game_over.dart b/packages/pinball_components/lib/src/components/backboard/backboard_game_over.dart index 55f4786a..05f89217 100644 --- a/packages/pinball_components/lib/src/components/backboard/backboard_game_over.dart +++ b/packages/pinball_components/lib/src/components/backboard/backboard_game_over.dart @@ -3,7 +3,6 @@ import 'dart:math'; import 'package:flame/components.dart'; import 'package:flutter/services.dart'; -import 'package:intl/intl.dart'; import 'package:pinball_components/pinball_components.dart'; /// Signature for the callback called when the used has @@ -25,8 +24,6 @@ class BackboardGameOver extends PositionComponent with HasGameRef { final int _score; final BackboardOnSubmit? _onSubmit; - final _numberFormat = NumberFormat('#,###,###'); - @override Future onLoad() async { final backgroundSprite = await gameRef.loadSprite( @@ -61,7 +58,7 @@ class BackboardGameOver extends PositionComponent with HasGameRef { unawaited( add( TextComponent( - text: _numberFormat.format(_score), + text: _score.formatScore(), position: Vector2(-22, -46.5), anchor: Anchor.center, textRenderer: Backboard.textPaint, diff --git a/packages/pinball_components/lib/src/extensions/extensions.dart b/packages/pinball_components/lib/src/extensions/extensions.dart new file mode 100644 index 00000000..4be86fd3 --- /dev/null +++ b/packages/pinball_components/lib/src/extensions/extensions.dart @@ -0,0 +1 @@ +export 'score.dart'; diff --git a/packages/pinball_components/lib/src/extensions/score.dart b/packages/pinball_components/lib/src/extensions/score.dart new file mode 100644 index 00000000..2b3cec40 --- /dev/null +++ b/packages/pinball_components/lib/src/extensions/score.dart @@ -0,0 +1,11 @@ + import 'package:intl/intl.dart'; + +final _numberFormat = NumberFormat('#,###,###'); + +/// Adds score related extensions to int +extension ScoreX on int { + /// Formats this number as a score value + String formatScore() { + return _numberFormat.format(this); + } +} diff --git a/packages/pinball_components/lib/src/pinball_components.dart b/packages/pinball_components/lib/src/pinball_components.dart index bd8f99de..50dee227 100644 --- a/packages/pinball_components/lib/src/pinball_components.dart +++ b/packages/pinball_components/lib/src/pinball_components.dart @@ -1,2 +1,3 @@ export 'components/components.dart'; +export 'extensions/extensions.dart'; export 'flame/flame.dart';