From 4a199aa9081ab431529db1a3366c9ff67f9de338 Mon Sep 17 00:00:00 2001 From: Jorge Coca Date: Sun, 8 May 2022 14:03:21 -0500 Subject: [PATCH] perf: remove Info icon and use material icon instead (#413) --- assets/images/link_box/info_icon.png | Bin 6389 -> 0 bytes lib/game/view/pinball_game_page.dart | 3 +-- lib/gen/assets.gen.dart | 9 --------- pubspec.yaml | 1 - test/game/view/pinball_game_page_test.dart | 3 +-- 5 files changed, 2 insertions(+), 14 deletions(-) delete mode 100644 assets/images/link_box/info_icon.png diff --git a/assets/images/link_box/info_icon.png b/assets/images/link_box/info_icon.png deleted file mode 100644 index 78556be0ace02fc55dd02cbe062547453d5b1601..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 6389 zcmVY?mK~#7F?Okb% zTvc{HRn=bc)@Jbru?Nh=-~k2*GcZgP_!E-ML_$iC!zuv+B_R-tB*Ymh0Sm({OFiIeVP{X0-uBFSlJyWya?Kd9Xv*o*LaukLJM}%5I5dXWB z=lX2DcrGL8XoR{P22d{b2ucV8#7DFcYIodmM}}B{UGt(&BIy5#ID(~@>31p!DuukB_kHI zJ)<7^Ue!o}^isX}1{3*;pbX*CM)njU^~4iToWgT0Q+=5?Z(b~VJ*9Zo6Uh@Wsw|T% z#{^MDdFc>mFT9I8s)$nP`s5P2hD78S+-^wEIF<;PHX@HH$}}s-AAkHbe_fV2bLQ~* zsrr9Y`92nXKfg7xkdCCLih6fbO{0qdg{zoxy(>MYzom`*h;V6hcS5uxdHQqDJ@>6` z+qV75&Ye4dym#;3NBjEv{=L7y|9_j!=DRGsX5l?Pvt`Sc%U^r#weQWIJ$nZKU*8uA zVbY=mPQ(zWqRdv15G=+}-E72YfGU-fAzs=IEcJLqx^iqp_&xXBa}p8$#TQ>Z)@rpr z3kL`!4&T9d@twyVcbpL;5yaaL7N-)ET9U#(9Ck@4b-t@m((_K&d!y=+KgE!)h?%}| zGuNhGv0pt?cbvc35N*yEfNCXo+*Qb@aoA3;nk9tgcM8g7}{z{4kaXxuTVLe|E`{g z>G`B)P-Z;;{PSn*+qdu8aF}5C?%j`*5VRG_3}(2enz1GWDHHklq*1i}(5NF)Idn#} z-n~pl))23vJ(UJkjVcY}tQ|XctQZMZ^HqU%;=>O={8Jf}2G%WlQ06sBTP0Q5g@%h2 z3@;;=#;8i5nX8#xOs8^;>&a2Z^)pwkTD6e6IE*r2oq)_mN{D2r%{C}QO)O#uF9})N zB^>NHA*hEF+LX2rC$-~T%*6Ss@5xy+*REZA7CA1AQefSle){P%dwYA$HcT_S;8l{S zG#C+vNM#&U@HzLoOM3OVTuo+Z&Bzk@Yu2p!_Gm`F0qaOc5miZSgO9W&H_%mXs&`Hf zI`X~RF%B?KXJYB)Xd`-`dg`e$fqVnjl?*crpuwC;f*I$@CJAIbi=2zx(TETr^L9#u zD;iWe&Yv~bkZ<55q1RNBGFDXtov9+}p4J{dgw6z8hp#U#vZc;Y=bd+cV=N-y zfOTK7V#Ud93yGj!TxJuD050&%q#%3^W1J<}BsaPi;Trc(p@_1A6j_QcemfR^_UbUk zVb`u*tJxNmUdt^N0h@PGGa?jt96p3D*-dG?n?AywtQ9iOr?}33|NZy>EF2-Qef#zw zu}vt^CXmq_5uz$GH@vh5auB2-3%I<;BdYhE#}kpidiCnF2L=Y-3r7erV0`3}N6wis zV@4!`GMd?gLPk7z} zF2XzSyhDr2>md24jz~nFRF5&JfKWuck{jNrdMwaFnWnn27vbtn(s>ponxFjpxy=fkzzVT#GnS%lV1422OlKj zAg@!0c-E#(n^s@8Y}o^Hgu>FLOaBV^p_IpVfBf;s5eKjb5hriF@kZ^XmtKnM=gB9Z zl$9%2CRel@_jeG0<77<#a9j-mRE^KQ`s%BhI)WI+V_8e*FnAVg%tM$|xrIy}PooHA;}pW-qxbqSRcK+Y%SlmMh^y00IJFNF@Q zqayXsKmWWA?yrIS|5A={IQ7(1e;0=aklvup6D0ubo^0B*DPDt7`Dh$GrvKJ8BC8x3 z2gC;(r3UV=xo2zk5qlQMkE-YT>#y&{@pt412Qb{STW`H}CZr$*rmBiOmlJRC#I#80 z(vRHDELXWu^@@@LkGI}>>k3H6eKNxE?$+J%$9KF^dGCpPerv?MAP<{2Z(e@NDW^Pv z(@Js*sG6WSqez zmt1lI4s|3PBfjVj>MhUd9SONGREj#d9xqY#OTZYL9N@Pm8ww;qV$lOV=- z!AkZBpNa2Qd1Y#Ebn*Nu;;35(RmcEK$bs2{MB$C@BUch_;h7=$_;s@#Z8f_+! zAJY;*zPGQL1SI4I9p`xa?YBo=g!Ds->R@EEZ@Xg+`4Q$w7RWdQaQk$$y9PB>+p}kn zF=E8Ywr$%4u4+6l@@FzQt|0(p)-!%UKN_D!5VlLk8K5(2 ztDYu&At{#yT_tdD)5r*{eGOhu`WLOhRvBl2Hh&;( z?vKbNZlEQC`#trc6zZqb2AC0clcnQ7stQUkG%7;{m6aJ+04CfDHN;bIWXZqmsEXIL z0h9nG zB;zs_#AB(eXaf*f1X2BlI3PG9oIV7x`?-u0Ks-c=j|ew445p0ug9=I>5dSciq8qw& z>C))ttD{pH3CE)&fcdiV21h{P<@T{u8R)?#n%v?|1IZ=!{>QW`BwzxFkj(>z6!dJ|xba5|7cRU~ zMi35nHWd8;&n#H5;BRo+k1_xz8~_nwMpS>Z&iN*A*W9#eQ@o}Pa2@n5lY)*&n1A@7 zM#2FvkVc~s>h*dsBMjvGF_7^&O2I3yymG|bfmN$k{Ueyo>v=0J%>^aA5O+-HNY3b? zG7?s)NTTAhp@L)_4Y6phJ2NuUrg*sg^2^twt8#-Jp@6o%`rv~PGUyDn0n#3fO9(E@ znSST+6f(1Me|*rXprJCE)*nDmDAREW#)4Y?052eM0FUd|t@|fALgDWKko0KtU;|>i zp?(s_tCQjlv8DD0FWMb4ojqcqJtRHr5u*q(*#vJW_Ktx7J@`=U9fKk6!Mz5EFaiJH zgGxnvuzmaX`;k4pNJaqS@bnkE3{Ss!cNp$8T%5l~wjIt2r6zIm&P|m#Rrkj2U zqrEd6ApkDldh^XU{{U?~6YX1q<6ErWf+U5BM~5J4aE^MK<# zFdY|UGht@wN9RBaI6&#wNC1>yM_Gz;_WJef?+Hf;y!hgacc4w*2J+dqZ=#%x!l5{9 zyN!;^X3ls5xQW~yIL}fM&WME46SChe9zbcq4z!?xlG`QD1v~G&^B#xsUMFK5(1vF( zzWCyw0{JcIelxD67ibW`{qc9j8OMi)*I$1<>&Er}(2Xlbsc`p)nAIca7*8QrhuHyKgq|5c#Vi3wBxW5VAAJ3tp1G^###2K9! zPSj8jD7ZywhlEHa8yjkNfFfnnlH63(G&olVMe-Xci)jmRJY&Ly3Fq8+N81QluCU z#D79irb(y7{on}WdgRMJ063 zkSy1I^Aoe9ORD2UDU$OcqV$L;rr!hsPN!R{Vm#`Jz`9*~?X`c1x^k4?Ig0$KdbCY! zn;({*h9h#WbeH7|i~v%F{3>dszF}!6=Y-R65Mb3g6Ob>(2kS^r#Kp7GN6_FTJtYv$G@eyUMZJwX0R+BW+A*=T4RjBCC>9Tzvj#V_75 zdY|$v4 zQW$#QR8a$5)X+Rpwj8}3;cG9r@4ox~8piA_IRt=U@_!zC?6H4dzI^$A<8lDVr^+!; z$CqYNEYIUrP!=CZp?WHg8B}INgW3QcBP7xp^<~$v2TiL4#4}Zhi7HkW$Y+2?oob1! zepdz_ee}@}AjZqDzWVB`AQArtWbBcH416ad(zW;BfB#>=Wd!b*zuME&(?58tzmN5R zlqTeZc_NabdJ^)P1(v~CkrCObb84#vUXmkxNaPbLB_QNRxIAVBQc$N9aO|k{m~kpU z2k=53!MDtKCQe7)ny6dG`5fa9??9VXNiu0Owt(iLVbB2v5*^22PLY-Zj;HU=GkrW#? z@Hwb}29TAhFA{|3B+6~K-FC`pr=2!;$&w|Dp{7m%BIZyO1wk0L)%;^6`MRZ^1Y!@$c8YzRt( zuOrF-FCo<(%`Vit5F@@zrJ{x-Cp`G~ z+qXl}j!=}usnqi_=w6x*_Z%OI114#KNg_eOIOJmHyIOFwTOe+H7m(i~@+-bmrSpfC z_vwcGc%K9)46;W+8MHAzVE1J|KwTu8jelnbj{KVzrBm~H(ukVd)EQV=kzQk=-K`v+{syBiB$Z^!AAOiC#-plC6y9bmLX%zdUZJ;^!qYsGe)8DfKB=?o~ zfoLAT#BcU4zPC@kob-OD>*G<4Z9F&Rv+g`SGcc80Dg+`;{xvZ%MEo(fZOr9%J5~9GRkq~xd0fG&Q><-Kj&!Q2m zFMawBBdmEj>72!emN31{Ba*%BYK+K68)wPa{K@#5-Mjvk>Bd=?MF>5BX5nuB0rJK{G~LhO6N#_8K=Wg9Ak z=i`yRR~$Z~K7F8v1EgEv7<3`NO2caB4751LN3X@^{(9tuK~*s<#AgUS04M`Ae_pS6 zrp~FZnzpEOzA@{n^J+_kS9v=%=?n%rGP!0*=D7@Vp^eoc5a~httqJVMw$a^@<2jyR zJC~?(n5HPx3L;L`K-E&(gAF(5sAmp0vFTmI$##BS$dKZ;@yJ$Gw*_9sE$VH{-AKDb z#};~>rP;;VI>Lb6oF`~uur<$>`C2$Pd4Z0~@MWHM7xLNIZK$0mOrjmDh2OGK3~AGb za;bXJ{Q@N4-YQ!odN>KU{UP&!zzlO}uL|hj#mYsSVaA!dlWNHYZT4Ko*<6W*1HWJ= z`0l!!c^H9_HIGmsmDS=OnHe(|e_n{Yt9GU|2@D z3MyiRtTHB|MdeyRz7KB7tYQnukH0hW1o8$T8CiOO29rewlVh<+p1mBfxP$2f`;E(r zLB*u^?AWn`_mjiGv;y+^LH+xb=OF{JEza1s)aLnM>wu7dP$1+T4cXR(CbGqzk#SQT zx8!}cpBP8qv5(a)fuGb=d8FD>)iulgK2ulpnxQ#++sw_jtxB6QI921fuCk?>vwdRx zj!9AxjUOl+6pInslaIZtnvUci4o=cJ2mU^vk5Wk0#JrEalldSn2dOH;zpttdK@F%l zL(19x>`INC%f+VPi6vD+Zr`+NQ@mF7*v-Gsn(B_VLuGXL3!!?8zs%JXm52&M?e}!d zHhS~LZ6jhvJQm%vz)ITS)BewG?%8z@NpE09vaN2*y}}L}=Z_S0a~pjWTxLN1Hiv$n z;7LU(x3J9!WLpxtXVb2%ZV%#)Ep5w9pS=nVof}e*DM&6_DE1yJwz%~hA9QTyEXt|Q zZWwVqkvcYYb_k#7mfSD*0rMl*eCK&pOft5%IS-v1zLkMgrk=z}g;!J3=F+rdlN38< z`*XJ=cS8ye=XuHHQW5+)-(LK0GL|9ao14{!D2X7Zi;G>aJ?AzGgm)m@{Z showMoreInformationDialog(context), ), ); diff --git a/lib/gen/assets.gen.dart b/lib/gen/assets.gen.dart index f0b6fdeb..8d81e5c6 100644 --- a/lib/gen/assets.gen.dart +++ b/lib/gen/assets.gen.dart @@ -14,7 +14,6 @@ class $AssetsImagesGen { const $AssetsImagesBonusAnimationGen(); $AssetsImagesComponentsGen get components => const $AssetsImagesComponentsGen(); - $AssetsImagesLinkBoxGen get linkBox => const $AssetsImagesLinkBoxGen(); $AssetsImagesLoadingGameGen get loadingGame => const $AssetsImagesLoadingGameGen(); $AssetsImagesScoreGen get score => const $AssetsImagesScoreGen(); @@ -56,14 +55,6 @@ class $AssetsImagesComponentsGen { const AssetGenImage('assets/images/components/space.png'); } -class $AssetsImagesLinkBoxGen { - const $AssetsImagesLinkBoxGen(); - - /// File path: assets/images/link_box/info_icon.png - AssetGenImage get infoIcon => - const AssetGenImage('assets/images/link_box/info_icon.png'); -} - class $AssetsImagesLoadingGameGen { const $AssetsImagesLoadingGameGen(); diff --git a/pubspec.yaml b/pubspec.yaml index 1b71a25f..7f925688 100644 --- a/pubspec.yaml +++ b/pubspec.yaml @@ -64,7 +64,6 @@ flutter: - assets/images/components/ - assets/images/bonus_animation/ - assets/images/score/ - - assets/images/link_box/ - assets/images/loading_game/ flutter_gen: diff --git a/test/game/view/pinball_game_page_test.dart b/test/game/view/pinball_game_page_test.dart index 74ef4fbb..fce6e74e 100644 --- a/test/game/view/pinball_game_page_test.dart +++ b/test/game/view/pinball_game_page_test.dart @@ -10,7 +10,6 @@ import 'package:leaderboard_repository/leaderboard_repository.dart'; import 'package:mocktail/mocktail.dart'; import 'package:pinball/assets_manager/assets_manager.dart'; import 'package:pinball/game/game.dart'; -import 'package:pinball/gen/gen.dart'; import 'package:pinball/l10n/l10n.dart'; import 'package:pinball/more_information/more_information.dart'; import 'package:pinball/select_character/select_character.dart'; @@ -316,7 +315,7 @@ void main() { gameBloc: gameBloc, startGameBloc: startGameBloc, ); - expect(find.image(Assets.images.linkBox.infoIcon), findsOneWidget); + expect(find.byIcon(Icons.info), findsOneWidget); }); testWidgets('opens MoreInformationDialog when tapped', (tester) async {