From 4403dbc38eba94db482d2cc40c51a3cfa3cf1433 Mon Sep 17 00:00:00 2001 From: RuiAlonso Date: Thu, 24 Mar 2022 18:36:40 +0100 Subject: [PATCH] test: removed unnecessary tests for ramps --- lib/game/components/jetpack_ramp.dart | 2 +- lib/game/components/launcher_ramp.dart | 6 +- .../lib/src/components/shapes/arc_shape.dart | 1 - test/game/components/jetpack_ramp_test.dart | 63 ---------------- test/game/components/launcher_ramp_test.dart | 74 ------------------- test/game/pinball_game_test.dart | 26 ------- 6 files changed, 4 insertions(+), 168 deletions(-) delete mode 100644 test/game/components/jetpack_ramp_test.dart delete mode 100644 test/game/components/launcher_ramp_test.dart diff --git a/lib/game/components/jetpack_ramp.dart b/lib/game/components/jetpack_ramp.dart index 67c53c35..8656c61e 100644 --- a/lib/game/components/jetpack_ramp.dart +++ b/lib/game/components/jetpack_ramp.dart @@ -1,4 +1,4 @@ -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_renaming_method_parameters import 'dart:math' as math; diff --git a/lib/game/components/launcher_ramp.dart b/lib/game/components/launcher_ramp.dart index f9d3f36e..8f9f7b19 100644 --- a/lib/game/components/launcher_ramp.dart +++ b/lib/game/components/launcher_ramp.dart @@ -1,4 +1,4 @@ -// ignore_for_file: public_member_api_docs +// ignore_for_file: public_member_api_docs, avoid_renaming_method_parameters import 'dart:math' as math; @@ -9,7 +9,7 @@ import 'package:pinball/flame/blueprint.dart'; import 'package:pinball/game/game.dart'; import 'package:pinball_components/pinball_components.dart'; -/// A [Blueprint] which creates the [LauncherRamp]. +/// A [Blueprint] which creates the launcher ramp. class Launcher extends Forge2DBlueprint { /// Width between walls of the [Pathway]. static const width = 5.0; @@ -155,7 +155,7 @@ class LauncherCurveRamp extends BodyComponent with InitialPosition, Layered { /// {@template launcher_ramp_opening} /// [RampOpening] with [Layer.launcher] to filter [Ball]s collisions -/// inside [LauncherRamp]. +/// inside launcher ramp. /// {@endtemplate} class _LauncherRampOpening extends RampOpening { /// {@macro launcher_ramp_opening} diff --git a/packages/pinball_components/lib/src/components/shapes/arc_shape.dart b/packages/pinball_components/lib/src/components/shapes/arc_shape.dart index f7eeeecc..ef392e34 100644 --- a/packages/pinball_components/lib/src/components/shapes/arc_shape.dart +++ b/packages/pinball_components/lib/src/components/shapes/arc_shape.dart @@ -1,6 +1,5 @@ // ignore_for_file: public_member_api_docs -import 'package:flame/extensions.dart'; import 'package:flame_forge2d/flame_forge2d.dart'; import 'package:geometry/geometry.dart'; diff --git a/test/game/components/jetpack_ramp_test.dart b/test/game/components/jetpack_ramp_test.dart deleted file mode 100644 index b88bdf23..00000000 --- a/test/game/components/jetpack_ramp_test.dart +++ /dev/null @@ -1,63 +0,0 @@ -// ignore_for_file: cascade_invocations - -import 'package:flame/components.dart'; -import 'package:flame_forge2d/flame_forge2d.dart'; -import 'package:flame_test/flame_test.dart'; -import 'package:flutter_test/flutter_test.dart'; -import 'package:pinball/game/game.dart'; - -import '../../helpers/helpers.dart'; - -void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - final flameTester = FlameTester(PinballGameTest.create); - - group('JetpackRamp', () { - flameTester.test( - 'loads correctly', - (game) async { - final ramp = JetpackRamp( - position: Vector2.zero(), - ); - await game.ready(); - await game.ensureAdd(ramp); - - expect(game.contains(ramp), isTrue); - }, - ); - - group('children', () { - flameTester.test( - 'has only one Pathway.arc', - (game) async { - final ramp = JetpackRamp( - position: Vector2.zero(), - ); - await game.ready(); - await game.ensureAdd(ramp); - - expect( - () => ramp.children.singleWhere( - (component) => component is Pathway, - ), - returnsNormally, - ); - }, - ); - - flameTester.test( - 'has a two RampOpenings for the ramp', - (game) async { - final ramp = JetpackRamp( - position: Vector2.zero(), - ); - await game.ready(); - await game.ensureAdd(ramp); - - final rampAreas = ramp.children.whereType(); - expect(rampAreas.length, 2); - }, - ); - }); - }); -} diff --git a/test/game/components/launcher_ramp_test.dart b/test/game/components/launcher_ramp_test.dart deleted file mode 100644 index e9350f05..00000000 --- a/test/game/components/launcher_ramp_test.dart +++ /dev/null @@ -1,74 +0,0 @@ -// ignore_for_file: cascade_invocations - -import 'package:flame/components.dart'; -import 'package:flame_forge2d/flame_forge2d.dart'; -import 'package:flame_test/flame_test.dart'; -import 'package:flutter_test/flutter_test.dart'; -import 'package:pinball/game/game.dart'; - -import '../../helpers/helpers.dart'; - -void main() { - TestWidgetsFlutterBinding.ensureInitialized(); - final flameTester = FlameTester(PinballGameTest.create); - - group('LauncherRamp', () { - flameTester.test( - 'loads correctly', - (game) async { - final ramp = LauncherRamp( - position: Vector2.zero(), - ); - await game.ready(); - await game.ensureAdd(ramp); - - expect(game.contains(ramp), isTrue); - }, - ); - - group('constructor', () { - flameTester.test( - 'positions correctly', - (game) async { - final position = Vector2.all(10); - final ramp = LauncherRamp( - position: position, - ); - await game.ensureAdd(ramp); - - expect(ramp.position, equals(position)); - }, - ); - }); - - group('children', () { - flameTester.test( - 'has two Pathway', - (game) async { - final ramp = LauncherRamp( - position: Vector2.zero(), - ); - await game.ready(); - await game.ensureAdd(ramp); - - final pathways = ramp.children.whereType().toList(); - expect(pathways.length, 2); - }, - ); - - flameTester.test( - 'has a two RampOpenings for the ramp', - (game) async { - final ramp = LauncherRamp( - position: Vector2.zero(), - ); - await game.ready(); - await game.ensureAdd(ramp); - - final rampAreas = ramp.children.whereType().toList(); - expect(rampAreas.length, 2); - }, - ); - }); - }); -} diff --git a/test/game/pinball_game_test.dart b/test/game/pinball_game_test.dart index 65732608..52008074 100644 --- a/test/game/pinball_game_test.dart +++ b/test/game/pinball_game_test.dart @@ -62,32 +62,6 @@ void main() { }); }); - group('Paths', () { - flameTester.test( - 'has only one JetpackRamp', - (game) async { - await game.ready(); - - expect( - () => game.children.singleWhere( - (component) => component is JetpackRamp, - ), - returnsNormally, - ); - }, - ); - - flameTester.test( - 'has only one LauncherRamp', - (game) async { - await game.ready(); - - final rampAreas = game.children.whereType().toList(); - expect(rampAreas.length, 1); - }, - ); - }); - debugModeFlameTester.test('adds a ball on tap up', (game) async { await game.ready();