From 2a72e3a5454050efc2533d421b3dfd61e5417b76 Mon Sep 17 00:00:00 2001
From: arturplaczek <arturp1989@gmail.com>
Date: Wed, 20 Apr 2022 10:43:37 +0200
Subject: [PATCH] fix: apply code review

---
 lib/game/view/widgets/play_button_overlay.dart       |  5 ++---
 test/app/view/app_test.dart                          | 10 +++-------
 test/game/view/widgets/play_button_overlay_test.dart |  2 +-
 test/theme/view/character_selection_page_test.dart   |  2 +-
 4 files changed, 7 insertions(+), 12 deletions(-)

diff --git a/lib/game/view/widgets/play_button_overlay.dart b/lib/game/view/widgets/play_button_overlay.dart
index 27cb59a1..70070520 100644
--- a/lib/game/view/widgets/play_button_overlay.dart
+++ b/lib/game/view/widgets/play_button_overlay.dart
@@ -27,13 +27,12 @@ class PlayButtonOverlay extends StatelessWidget {
           showDialog<void>(
             context: context,
             builder: (_) {
-              final width = MediaQuery.of(context).size.width * 0.9;
-              final height = MediaQuery.of(context).size.height * 0.9;
+              final height = MediaQuery.of(context).size.height * 0.5;
 
               return Center(
                 child: SizedBox(
                   height: height,
-                  width: width,
+                  width: height * 1.4,
                   child: const CharacterSelectionDialog(),
                 ),
               );
diff --git a/test/app/view/app_test.dart b/test/app/view/app_test.dart
index 169567e4..9fc79b5d 100644
--- a/test/app/view/app_test.dart
+++ b/test/app/view/app_test.dart
@@ -5,7 +5,6 @@
 // license that can be found in the LICENSE file or at
 // https://opensource.org/licenses/MIT.
 
-import 'package:flutter_bloc/flutter_bloc.dart';
 import 'package:flutter_test/flutter_test.dart';
 import 'package:leaderboard_repository/leaderboard_repository.dart';
 import 'package:mocktail/mocktail.dart';
@@ -29,12 +28,9 @@ void main() {
 
     testWidgets('renders PinballGamePage', (tester) async {
       await tester.pumpWidget(
-        RepositoryProvider<PinballAudio>(
-          create: (_) => pinballAudio,
-          child: App(
-            leaderboardRepository: leaderboardRepository,
-            pinballAudio: pinballAudio,
-          ),
+        App(
+          leaderboardRepository: leaderboardRepository,
+          pinballAudio: pinballAudio,
         ),
       );
       expect(find.byType(PinballGamePage), findsOneWidget);
diff --git a/test/game/view/widgets/play_button_overlay_test.dart b/test/game/view/widgets/play_button_overlay_test.dart
index e0801b54..210cc347 100644
--- a/test/game/view/widgets/play_button_overlay_test.dart
+++ b/test/game/view/widgets/play_button_overlay_test.dart
@@ -33,7 +33,7 @@ void main() {
       verify(gameFlowController.start).called(1);
     });
 
-    testWidgets('is showing CharacterSelectionDialog when tapped',
+    testWidgets('displays CharacterSelectionDialog when tapped',
         (tester) async {
       await tester.pumpApp(PlayButtonOverlay(game: game));
 
diff --git a/test/theme/view/character_selection_page_test.dart b/test/theme/view/character_selection_page_test.dart
index 8b76ac35..dcf54a13 100644
--- a/test/theme/view/character_selection_page_test.dart
+++ b/test/theme/view/character_selection_page_test.dart
@@ -83,7 +83,7 @@ void main() {
       verify(() => themeCubit.characterSelected(SparkyTheme())).called(1);
     });
 
-    testWidgets('is showing how to play dialog when start is tapped',
+    testWidgets('displays how to play dialog when start is tapped',
         (tester) async {
       await tester.pumpApp(
         CharacterSelectionView(),