From 25d0c8a45d5bf6d0842c90785837b3c4f5f18565 Mon Sep 17 00:00:00 2001 From: Erick Date: Tue, 29 Mar 2022 12:12:45 -0300 Subject: [PATCH] Apply suggestions from code review Co-authored-by: Allison Ryan <77211884+allisonryan0002@users.noreply.github.com> Co-authored-by: Alejandro Santiago --- .../pinball_components/lib/src/components/spaceship.dart | 6 +++--- .../test/src/components/spaceship_test.dart | 2 ++ 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packages/pinball_components/lib/src/components/spaceship.dart b/packages/pinball_components/lib/src/components/spaceship.dart index 917716e1..42d1f09c 100644 --- a/packages/pinball_components/lib/src/components/spaceship.dart +++ b/packages/pinball_components/lib/src/components/spaceship.dart @@ -10,15 +10,15 @@ import 'package:pinball_components/pinball_components.dart' hide Assets; /// {@template spaceship} /// A [Blueprint] which creates the spaceship feature. -/// P@endtemplate} +/// {@endtemplate} class Spaceship extends Forge2DBlueprint { /// {@macro spaceship} Spaceship({required this.position}); - /// Total size of the spaceship + /// Total size of the spaceship. static final size = Vector2(24, 18); - /// The [position] that the elements will be created + /// The [position] where the elements will be created final Vector2 position; @override diff --git a/packages/pinball_components/test/src/components/spaceship_test.dart b/packages/pinball_components/test/src/components/spaceship_test.dart index bea8ed82..127d94a4 100644 --- a/packages/pinball_components/test/src/components/spaceship_test.dart +++ b/packages/pinball_components/test/src/components/spaceship_test.dart @@ -42,6 +42,8 @@ void main() { testWidgets('renders correctly', (tester) async { final game = TestGame(); + // TODO(erickzanardo): This should be handled by flame test. + // refctor it when https://github.com/flame-engine/flame/pull/1501 is merged await tester.runAsync(() async { await tester.pumpWidget(GameWidget(game: game)); await game.ready();