From 11c076c386eb656d674a4ff7b14ea174a999ae04 Mon Sep 17 00:00:00 2001
From: Jorge Coca <jorgecoca@users.noreply.github.com>
Date: Mon, 9 May 2022 09:24:59 -0500
Subject: [PATCH] revert: mobile backgrounds load on mobile (#437)

---
 .../character_selection_behavior.dart         | 16 +++-----
 lib/game/game_assets.dart                     | 15 +++-----
 .../character_selection_behavior_test.dart    | 37 +------------------
 3 files changed, 12 insertions(+), 56 deletions(-)

diff --git a/lib/game/behaviors/character_selection_behavior.dart b/lib/game/behaviors/character_selection_behavior.dart
index e62438f6..27003d75 100644
--- a/lib/game/behaviors/character_selection_behavior.dart
+++ b/lib/game/behaviors/character_selection_behavior.dart
@@ -2,8 +2,6 @@ import 'package:flame/components.dart';
 import 'package:flame_bloc/flame_bloc.dart';
 import 'package:pinball/select_character/select_character.dart';
 import 'package:pinball_components/pinball_components.dart';
-import 'package:pinball_flame/pinball_flame.dart';
-import 'package:platform_helper/platform_helper.dart';
 
 /// Updates the [ArcadeBackground] and launch [Ball] to reflect character
 /// selections.
@@ -13,14 +11,12 @@ class CharacterSelectionBehavior extends Component
         HasGameRef {
   @override
   void onNewState(CharacterThemeState state) {
-    if (!readProvider<PlatformHelper>().isMobile) {
-      gameRef
-          .descendants()
-          .whereType<ArcadeBackground>()
-          .single
-          .bloc
-          .onCharacterSelected(state.characterTheme);
-    }
+    gameRef
+        .descendants()
+        .whereType<ArcadeBackground>()
+        .single
+        .bloc
+        .onCharacterSelected(state.characterTheme);
     gameRef
         .descendants()
         .whereType<Ball>()
diff --git a/lib/game/game_assets.dart b/lib/game/game_assets.dart
index fccd494e..0d0ef26a 100644
--- a/lib/game/game_assets.dart
+++ b/lib/game/game_assets.dart
@@ -11,8 +11,7 @@ extension PinballGameAssetsX on PinballGame {
     const sparkyTheme = SparkyTheme();
     const androidTheme = AndroidTheme();
     const dinoTheme = DinoTheme();
-
-    final gameAssets = [
+    return [
       images.load(components.Assets.images.boardBackground.keyName),
       images.load(components.Assets.images.ball.flameEffect.keyName),
       images.load(components.Assets.images.signpost.inactive.keyName),
@@ -155,14 +154,10 @@ extension PinballGameAssetsX on PinballGame {
       images.load(dinoTheme.ball.keyName),
       images.load(sparkyTheme.leaderboardIcon.keyName),
       images.load(sparkyTheme.ball.keyName),
+      images.load(androidTheme.background.keyName),
+      images.load(dashTheme.background.keyName),
+      images.load(dinoTheme.background.keyName),
+      images.load(sparkyTheme.background.keyName),
     ];
-
-    return (platformHelper.isMobile) ? gameAssets : gameAssets
-      ..addAll([
-        images.load(androidTheme.background.keyName),
-        images.load(dashTheme.background.keyName),
-        images.load(dinoTheme.background.keyName),
-        images.load(sparkyTheme.background.keyName),
-      ]);
   }
 }
diff --git a/test/game/behaviors/character_selection_behavior_test.dart b/test/game/behaviors/character_selection_behavior_test.dart
index edf17999..5bcd6c50 100644
--- a/test/game/behaviors/character_selection_behavior_test.dart
+++ b/test/game/behaviors/character_selection_behavior_test.dart
@@ -77,42 +77,7 @@ void main() {
       );
 
       flameTester.test(
-        'onNewState does not call onCharacterSelected on the arcade background '
-        'bloc when platform is mobile',
-        (game) async {
-          final platformHelper = _MockPlatformHelper();
-          when(() => platformHelper.isMobile).thenAnswer((_) => true);
-          final arcadeBackgroundBloc = _MockArcadeBackgroundCubit();
-          whenListen(
-            arcadeBackgroundBloc,
-            const Stream<ArcadeBackgroundState>.empty(),
-            initialState: const ArcadeBackgroundState.initial(),
-          );
-          final behavior = CharacterSelectionBehavior();
-          await game.pump(
-            [
-              behavior,
-              ZCanvasComponent(),
-              Plunger.test(compressionDistance: 10),
-              Ball.test(),
-            ],
-            platformHelper: platformHelper,
-          );
-
-          const dinoThemeState = CharacterThemeState(theme.DinoTheme());
-          behavior.onNewState(dinoThemeState);
-          await game.ready();
-
-          verifyNever(
-            () => arcadeBackgroundBloc
-                .onCharacterSelected(dinoThemeState.characterTheme),
-          );
-        },
-      );
-
-      flameTester.test(
-        'onNewState calls onCharacterSelected on the arcade background '
-        'bloc when platform is not mobile',
+        'onNewState calls onCharacterSelected on the arcade background bloc',
         (game) async {
           final platformHelper = _MockPlatformHelper();
           when(() => platformHelper.isMobile).thenAnswer((_) => false);