From 01fda6613aefbad0725c8c1f53fe5c5395d12e2c Mon Sep 17 00:00:00 2001 From: Allison Ryan Date: Sun, 8 May 2022 14:36:56 -0500 Subject: [PATCH] refactor: PR revisions --- .../google_gallery/behaviors/google_word_bonus_behavior.dart | 4 +--- .../src/components/google_word/cubit/google_word_cubit.dart | 2 +- .../test/src/components/google_letter_test.dart | 4 ++++ 3 files changed, 6 insertions(+), 4 deletions(-) diff --git a/lib/game/components/google_gallery/behaviors/google_word_bonus_behavior.dart b/lib/game/components/google_gallery/behaviors/google_word_bonus_behavior.dart index cdae747c..7456447f 100644 --- a/lib/game/components/google_gallery/behaviors/google_word_bonus_behavior.dart +++ b/lib/game/components/google_gallery/behaviors/google_word_bonus_behavior.dart @@ -15,9 +15,7 @@ class GoogleWordBonusBehavior extends Component listenWhen: (_, state) => state.letterSpriteStates.values .every((element) => element == GoogleLetterSpriteState.lit), onNewState: (state) { - readBloc().add( - const BonusActivated(GameBonus.googleWord), - ); + bloc.add(const BonusActivated(GameBonus.googleWord)); readBloc().onBonusAwarded(); }, ), diff --git a/packages/pinball_components/lib/src/components/google_word/cubit/google_word_cubit.dart b/packages/pinball_components/lib/src/components/google_word/cubit/google_word_cubit.dart index d01bddbc..6ce5c66e 100644 --- a/packages/pinball_components/lib/src/components/google_word/cubit/google_word_cubit.dart +++ b/packages/pinball_components/lib/src/components/google_word/cubit/google_word_cubit.dart @@ -8,7 +8,7 @@ class GoogleWordCubit extends Cubit { GoogleWordCubit() : super(GoogleWordState.initial()); int _lastLitLetter = 0; - final _lettersInGoogle = 6; + static const _lettersInGoogle = 6; void onRolloverContacted() { final spriteStatesMap = {...state.letterSpriteStates}; diff --git a/packages/pinball_components/test/src/components/google_letter_test.dart b/packages/pinball_components/test/src/components/google_letter_test.dart index 0fe7a872..7deea645 100644 --- a/packages/pinball_components/test/src/components/google_letter_test.dart +++ b/packages/pinball_components/test/src/components/google_letter_test.dart @@ -42,6 +42,10 @@ void main() { final flameTester = FlameTester(_TestGame.new); group('Google Letter', () { + test('can be instantiated', () { + expect(GoogleLetter(0), isA()); + }); + flameTester.test( '0th loads correctly', (game) async {