From 92254853170e86aa9ea6335d17bb7587a6980aee Mon Sep 17 00:00:00 2001
From: Michael Li <alimy@gility.net>
Date: Mon, 9 Jan 2023 10:29:30 +0800
Subject: [PATCH] optimize get user info logic in JWT process

---
 internal/servants/chain/chain.go | 24 ++++++++++++++++++++++++
 internal/servants/chain/jwt.go   | 25 ++++++++-----------------
 2 files changed, 32 insertions(+), 17 deletions(-)
 create mode 100644 internal/servants/chain/chain.go

diff --git a/internal/servants/chain/chain.go b/internal/servants/chain/chain.go
new file mode 100644
index 00000000..84faeca5
--- /dev/null
+++ b/internal/servants/chain/chain.go
@@ -0,0 +1,24 @@
+// Copyright 2023 ROC. All rights reserved.
+// Use of this source code is governed by a MIT style
+// license that can be found in the LICENSE file.
+
+package chain
+
+import (
+	"sync"
+
+	"github.com/rocboss/paopao-ce/internal/core"
+	"github.com/rocboss/paopao-ce/internal/dao"
+)
+
+var (
+	_ums     core.UserManageService
+	_onceUms sync.Once
+)
+
+func userManageService() core.UserManageService {
+	_onceUms.Do(func() {
+		_ums = dao.DataService()
+	})
+	return _ums
+}
diff --git a/internal/servants/chain/jwt.go b/internal/servants/chain/jwt.go
index a0396630..62a50e93 100644
--- a/internal/servants/chain/jwt.go
+++ b/internal/servants/chain/jwt.go
@@ -10,14 +10,12 @@ import (
 	"github.com/gin-gonic/gin"
 	"github.com/golang-jwt/jwt/v4"
 	"github.com/rocboss/paopao-ce/internal/conf"
-	"github.com/rocboss/paopao-ce/internal/core"
 	"github.com/rocboss/paopao-ce/pkg/app"
 	"github.com/rocboss/paopao-ce/pkg/errcode"
 )
 
 func JWT() gin.HandlerFunc {
-	// TODO: optimize get user from a simple service that provide fetch a user info interface.
-	db := conf.MustGormDB()
+	ums := userManageService()
 	return func(c *gin.Context) {
 		var (
 			token string
@@ -55,13 +53,12 @@ func JWT() gin.HandlerFunc {
 				c.Set("USERNAME", claims.Username)
 
 				// 加载用户信息
-				user := &core.User{
-					Model: &core.Model{
-						ID: claims.UID,
-					},
+				user, err := ums.GetUserByID(claims.UID)
+				if err == nil {
+					c.Set("USER", user)
+				} else {
+					ecode = errcode.UnauthorizedAuthNotExist
 				}
-				user, _ = user.Get(db)
-				c.Set("USER", user)
 
 				// 强制下线机制
 				if (conf.JWTSetting.Issuer + ":" + user.Salt) != claims.Issuer {
@@ -82,8 +79,7 @@ func JWT() gin.HandlerFunc {
 }
 
 func JwtLoose() gin.HandlerFunc {
-	// TODO: optimize get user from a simple service that provide fetch a user info interface.
-	db := conf.MustGormDB()
+	ums := userManageService()
 	return func(c *gin.Context) {
 		token, exist := c.GetQuery("token")
 		if !exist {
@@ -101,12 +97,7 @@ func JwtLoose() gin.HandlerFunc {
 				c.Set("UID", claims.UID)
 				c.Set("USERNAME", claims.Username)
 				// 加载用户信息
-				user := &core.User{
-					Model: &core.Model{
-						ID: claims.UID,
-					},
-				}
-				user, err := user.Get(db)
+				user, err := ums.GetUserByID(claims.UID)
 				if err == nil && (conf.JWTSetting.Issuer+":"+user.Salt) == claims.Issuer {
 					c.Set("USER", user)
 				}