51d3903a4b
Merge branch 'main' into remove-GetSearchContentsCountUseCase
1 year ago
0584f191bc
Merge pull request #1271 from android/dt/remove-feature-dep
...
Remove the search module's dependency on other feature modules
1 year ago
825a5e2f5f
[Refactor]: Directly call SearchContentsRepository interface in SearchViewModel
...
- Remove GetSearchContentsCountUseCase.
- Remove GetSearchContentsCountUseCase from SearchViewModel.
- Remove GetSearchContentsCountUseCase from SearchViewModelTest.
Fixes #1283
1 year ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
1 year ago
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
1 year ago
3e4aad3210
Merge pull request #1257 from android/dt/add-module-graphs
...
Update module dependency graphs and add script to create them
1 year ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
1 year ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
1 year ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
1 year ago
c4642cea61
Add graph for screenshot testing module, minor update to script
...
Change-Id: I611f73d59790bde240756e8016aa721a1783335f
1 year ago
abe798056e
Add @After to guarantee DB was closed. ( #1240 )
...
* Add @After to guarantee DB was closed.
Change-Id: Ic29b7d12125853c71ddaef1a997ec123bb2dfc8b
* Fix spotless
- style
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
---------
Co-authored-by: Simon Marquis <contact@simon-marquis.fr>
1 year ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
1 year ago
2d610b0775
Merge branch 'main' into replace-testharness
...
* main: (37 commits)
Disable animations of instrumented tests (#1167 )
Bump gradle/wrapper-validation-action from 1 to 2
Remove unused release variable. Fixes #1231
Apply Composable Parameter Ordering Guidelines
Remove kotlinx-coroutines-guava dependency from :sync:work
Add explicit guava-android dependency for :sync:work
Extract ScreenshotHelper to separate testing module
Update AGP to 8.3.0
Remove Insert function - Insert is only used in test. - Upsert do same thing as Insert.
🤖 Updates baselines for Dependency Guard
Bump the kotlin-ksp-compose group with 6 updates
🤖 Updates baselines for Dependency Guard
Bump hilt from 2.50 to 2.51
Bump com.google.truth:truth from 1.1.5 to 1.4.2
Move java to kotlin folder.
Remove disk usage testing
Figuring out what is using 66Gb in the runner
Dpm
Improve converting to kotlin timezone
Use trySend multiple times
...
Change-Id: If3f564108d42675ba55ef242f0d06f04aff45c4a
1 year ago
42e9a3a2c6
Merge pull request #1182 from SimonMarquis/api-compose-ui-tooling
...
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
1 year ago
350e7b1bba
Merge pull request #1144 from SimonMarquis/move-fakes-to-data-test-module
...
Move `:core:data` fake repositories to `:core:data-test`
1 year ago
171fa88ac0
Merge pull request #1248 from yongsuk44/main
...
Apply Composable Parameter Ordering Guidelines
1 year ago
067d68e1c6
Merge pull request #1247 from Jaehwa-Noh/remove-unused-function
...
Remove Insert function
1 year ago
3fa75a037a
Apply Composable Parameter Ordering Guidelines
...
Change-Id: Id456e91b5ce8bd5807c40df67c3deac008c61670
1 year ago
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
1 year ago
52c0d7ae0a
Remove Insert function
...
- Insert is only used in test.
- Upsert do same thing as Insert.
Change-Id: Ib5f8e693e71c895b83e43f6b51cebdc698bf744b
1 year ago
f31fdb3ec2
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: Id49a580012629163ec4a3663d95ab71b98910220
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# app/src/testDemo/kotlin/com/google/samples/apps/nowinandroid/ui/NiaAppScreenSizesScreenshotTests.kt
# gradle/libs.versions.toml
1 year ago
50d5583fe1
🤖 Updates screenshots
1 year ago
d6357be8c4
Replace Accompanist TestHarness with DeviceConfigurationOverride
...
Change-Id: I6742d5e221f86a019f44d3e623609bf76d2a3a2a
1 year ago
7abcefdfdf
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
1 year ago
8d89a89096
Merge remote-tracking branch 'origin/main' into move-android-instrumented-test
1 year ago
dc22e8ae31
Merge remote-tracking branch 'origin/main' into jvm-alt
1 year ago
dc2f435a27
Merge remote-tracking branch 'origin/main' into move-fakes-to-data-test-module
1 year ago
27fd4e544a
🤖 Updates screenshots
1 year ago
08dfec01f6
Fix individual UI components
...
Change-Id: I7dec3672b9efc3524371811743b06efc1e113a36
1 year ago
02d4fea615
🤖 Updates screenshots
1 year ago
8494b74646
Fix spotless (really should enable the commit hook to do this)
...
Change-Id: I68cb9bd989a809e5db1bca3157c2c978ad8c8906
1 year ago
68c15a891c
Fix text styles and spacing now that includeFontPadding is false
...
Change-Id: I6894836a7cd3a6139511a5d1ac0a96702a265186
1 year ago
81a5c0a3a7
🤖 Updates screenshots
1 year ago
092daacced
Revert fontSize change
...
Change-Id: I4011205f8a07c418653ee463d7355fe1e4ff6f44
1 year ago
1de15f0fab
Fix spotless (again)
...
Change-Id: If6b292af514df435d7bd233bd634657904c67d6b
1 year ago
76d59b3da8
Merge branch 'main' into update-compose-bom
1 year ago
1d2029aa2c
Merge pull request #1040 from SimonMarquis/fix-unit-test
...
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
1 year ago
adddea6fc7
Remove includeFontPadding, default behaviour is fine
...
Change-Id: I334c5a488c1e2a2b49670a97b16385a7df1791c8
1 year ago
75a3295381
Merge branch 'main' into mlykotom/tz-perf-improvement
...
Change-Id: I8730afc0cc3786784ea47276873fdf48dd82081c
# Conflicts:
# app/dependencies/prodReleaseRuntimeClasspath.txt
# build-logic/convention/src/main/kotlin/AndroidFeatureConventionPlugin.kt
1 year ago
9e645356f6
🤖 Updates screenshots
1 year ago
3868371ec8
Switch default padding to true since this was actually false by default since Compose 1.6.0-alpha01
...
Change-Id: Ifd291b247f848cea43e084cc0fb99917e47e26eb
1 year ago
c773fd7d0a
Switch off default font padding to avoid changing UI
...
Change-Id: Ida974df8fd4b1aba6f9525ef5335a6cbe02ddb18
1 year ago
3b1ee87194
Fix ShortText icon
...
Change-Id: I8b243ef88c1cc8be83f5fbeaee6a2576c453a062
1 year ago
6b2b01ed82
🤖 Updates screenshots
1 year ago
522efac8c0
Update Compose BOM to 2024.02.00. Fixes #1218
...
Change-Id: I838b81bf8e7fd7cb135f422653a8d8041829b28b
1 year ago
4cdc2ad345
Add comment for Retrofit async OkHttp
...
Change-Id: Ic7a6887b76caf26f00b58b0753271d426b67e75b
1 year ago
d110d92b87
Optimize OkHttp initialization for Retrofit
...
Change-Id: I347f1080ab5adf774a0cdd3c659cbf25c4820f9a
1 year ago
5f0612102d
Improve lazy loading for Coil + OkHttp
...
This way, we can load Coil's backend on a background thread and not block the MainThread with it.
Previously, the Coil image loader was initialized with the first composed image, which caused ~10ms duration and most likely skipped frames.
Change-Id: Iaa583b6adc1df7d7a51dbae1473e539f2c0b0b62
1 year ago
9daedc9690
Improve converting to kotlin timezone
...
Change-Id: I2af929c341cb274ae6b93bb8dffe696de6ed1c63
1 year ago
12a3a6edde
Use trySend multiple times
...
Change-Id: Ie00c4180d07fc4bb9d457647f3b7ddadd5a3c032
1 year ago
3d339e1658
Move `:core:data` fake repositories to `:core:data-test`
...
Now that these fake implementations are no longer used in the production source code (only in tests), we can safely extract them out of this module.
Hopefully, we'll later be able to use Kotlin testFixtures for that.
References:
- #709
- #875
1 year ago
e629d5e4bf
Merge branch 'main' into jvm-alt
1 year ago
6ec3b3c7a2
Use androidx.tracing everywhere
...
Change-Id: I9a77c4434d271e2e23700823f9f513aa61d177f8
1 year ago
ea1573fcc1
Use kotlinx.datetime.Timezone instead of java ZoneId
...
Change-Id: I62c4d044b319a9b59e06bb42fd12971d992e8628
1 year ago
b687328567
Replace comments with proper `@TestOnly` annotations
1 year ago
a83f6691c4
Fix addNewsResources issue
1 year ago
5a1258232f
Fix `emptyResultIsReturned_withNotMatchingQuery` unit test
...
`searchResultUiState` transitively relied on `getSearchContentsCount` updates and on `userDataRepository` to emit something.
1 year ago
a16d5f726c
More readable zoneId creation
...
Change-Id: I912dc021554e4886a5d09e63799aa5c81e8fd16a
1 year ago
44ae059a2b
Rename LocalTimeZone -> LocalZoneId + collects with lifecycle
...
Change-Id: I429c563765a489965d0a1741e36c98a30e5d0ef3
1 year ago
1e925ed99f
Conflate TimeZoneMonitor emissions
...
Co-authored-by: Alex Vanyo <vanyo@google.com>
1 year ago
0b3ece1bb9
Fix spotless
...
Change-Id: I6583fa9ed7c1563f6164653be9bbaf7904ec0215
1 year ago
cb00d2c8cb
Add TimeZoneMonitor to prevent multiple TimeZoneBroadcastReceivers
...
This way, we can save ~1ms per composed item on screen.
Change-Id: Ib9ada3cea53304fca4fb2b36c48c175845bc683d
1 year ago
d932cde110
Move `androidx.compose.ui:ui-tooling` dependency to convention plugin
1 year ago
691bf2aad6
Merge pull request #785 from SimonMarquis/optimize-avd
...
Optimize AVD to fix long vector paths Lint warning
1 year ago
d9d9153eda
Merge branch 'main' into firebase-ktx
1 year ago
377d3bef0c
Optimize AVD to fix long vector paths Lint warning
...
... with SVGOM, but you'll have to check on Android Studio the AVD diff.
https://googlesamples.github.io/android-custom-lint-rules/checks/VectorPath.md.html
1 year ago
d17f3b1101
Merge branch 'main' into move-android-instrumented-test
1 year ago
c1118eaf22
Apply suggestions from code review
1 year ago
61c7d71870
Migrate `:core:common` to pure JVM module
...
The notification icons are now stored in `:core:notifications`.
This forces `:sync:work` to depend on it.
Another solution could be to provide the resource id through Hilt, but it would require more changes.
1 year ago
4f8f08380f
Prep work for JVM alternatives to modules/plugins
1 year ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
be9dc533e3
Replace `Enum.values()` with `Enum.entries`
...
'Enum.values()' is recommended to be replaced by 'Enum.entries' since 1.9
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
bdb10a6870
Update core/designsystem/src/main/kotlin/com/google/samples/apps/nowinandroid/core/designsystem/component/scrollbar/ScrollbarExt.kt
...
Co-authored-by: Don Turner <dturner@users.noreply.github.com>
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
56fbe13b5a
Ignore function naming check when annotated with @Test
1 year ago
485440b550
Suppress ktlint:standard:function-naming in ResultKtTest
1 year ago
d671126f9e
Move @Suppress("ktlint:standard:max-line-length") to function scope
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
f8f932705a
Remove violations: discouraged-comment-location
1 year ago
fb5bd225be
Spotless
1 year ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
768738350b
Merge branch 'main' into firebase-ktx
1 year ago
e8f4537e7c
Update thumbTrackSizePercent calculation for readability
...
Change-Id: I7ef067a950b4b5911b8c2e6a8c1f72c3e95d938d
1 year ago
07d9877331
Update thumb movement range by thumb size, in app scrollbars
...
Change-Id: I4438debd5037965a837758e0c78b110ab8197da5
1 year ago
e62d70bf5a
Merge pull request #1067 from android/ben/itemstate
...
Remove redundant mutable state in NewsFeed
1 year ago
e334a727c3
Fix typo in app scrollbars
...
Change-Id: Ie72f1410fa8e5a68a520321c34d4fad251016486
1 year ago
3142ecb495
Remove redundant mutable state
1 year ago
22df321b9e
Apply spotless
1 year ago
72da8e2e56
Use custom Modifier.Node instead of background
1 year ago
d8880e98f0
Move state into a state holder and remove redundant Box
1 year ago
01928d7df5
Move scrollbar changes out of composition
1 year ago
447386d5dc
spotless
1 year ago
382eb1e695
Firebase: Migrate to using the Kotlin extensions (KTX) APIs in the main modules
...
https://firebase.google.com/docs/android/kotlin-migration
Requirements: Firebase BoM 32.5.0, but let's update to the latest 32.6.0.
And remove warnings:
- `'logEvent(String, ParametersBuilder.() -> Unit): Unit' is deprecated. Migrate to use the KTX API from the main module: https://firebase.google.com/docs/android/kotlin-migration .`
- `'param(String, String): Unit' is deprecated. Migrate to use the KTX API from the main module: https://firebase.google.com/docs/android/kotlin-migration .`
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
1 year ago
cf2d445362
Move Android instrumented test `ThemeTest` to unit test
1 year ago
c908f989c8
Update to Hilt 2.48.1 and use the KSP version
...
* Moved protobuf to separate module to avoid having to wire KSP's Plugin with the Protobuf Plugin.
* `@Binds` function cannot be an extension function.
* Commented `kotlin.compiler.execution.strategy=in-process` in CI to circumvent OOMs due to increased metaspace usage.
1 year ago
Don Turner
sanao1006
Alex Vanyo
Don Turner
Jaehwa Noh
kim-yongsuk
Tomáš Mlynarič
Simon Marquis
lihenggui
Yuya
Ben Trengrove
dahunsi
Ben Trengrove
Daniel Santiago