f0434e52a4
Spotless Apply
4 months ago
46e15f21dc
Fix duplicate composition trace markers in composable
4 months ago
8d57134663
Fix spotless
...
Change-Id: Ib093c206809a470b7f6135933bd2a72046865684
4 months ago
a8ffd1f2f1
Fix incorrect deep link key name in ForYouViewModelTest
...
Change-Id: I945632c419e11671eb73690999f9a234e577d16b
4 months ago
4b3f5370b9
Clean up deep link handling
...
Change-Id: I9d589cfe5c20a6b55708b99f5d79b10271af8ab4
4 months ago
00efda54e8
Merge branch 'main' into dt/nav-safe-args
...
* main: (58 commits)
Instrumented tests for InterestsListDetailScreen (#1518 )
Remove Firebase AD_SERVICE_CONFIG property
updateProdReleaseBadging
Merge Android & JVM plugins into a single `HiltConventionPlugin`
Update dependency guard
🤖 Updates baselines for Dependency Guard
Update to Lifecycle 2.8.3
Add android.adservices.AD_SERVICES_CONFIG to badges
Apply suggestions from code review
Update app/src/main/AndroidManifest.xml
generateModuleGraphs
dependencyGuardBaseline
updateProdReleaseBadging
Fix spotless.
Change set to `=` operator
Cleanup unused reference in `libs.versions.toml`
Regenerate SVG graphs
Update comment wording
Use stdin to avoid repeating the output file name
Replace bash commands with proper svgo cli
...
Change-Id: I1d804dcb6ac0ca857cb303b8c8bff5704b5d27a5
4 months ago
1c5513283a
Merge remote-tracking branch 'origin/main' into fix/1161-2
6 months ago
95bdc0f533
Rename ForYouRoute composable to ForYouScreen
...
Change-Id: I47456f19f2b41cafe44ba7636cad6d1fea782a33
7 months ago
da8f32a2ea
Rename Destinations to Routes
...
Change-Id: Ie9120031fc3738d0640c922624f15db0e15417d7
7 months ago
aba2b2c154
Remove different deeplink destination, add route for nested nav host
...
Change-Id: Idb9586752d815449243d6d529e9b655c45e395ad
8 months ago
4a84cf2bf4
Add specific type for deeplinks
...
Change-Id: I63c0abb16cbf540ef72dfb945518a48113bdbf75
8 months ago
f67f4d1a83
Update ForYou destination to match current deeplink pattern
...
Change-Id: Ia5ab36f2d75d8d061e63c0cac5262503bc93a638
8 months ago
7ec21d9d2f
Fix issue where selected topic in list was not showing as selected. Minor tidy ups.
...
Change-Id: Icfa79eac6f7327c365f79fd7d15dfa1f8c77184d
8 months ago
3fb6df7c33
Add NavigationSuiteScaffold
...
Change-Id: I36710d880bff381ed86c61632f2ab91902727775
8 months ago
8cc0fc00e6
🤖 Updates screenshots
8 months ago
924391cd22
Fix spotless
...
Change-Id: I7dcd7fa9544c873edeb8270f8d89b3bcb7211428
8 months ago
89163b5ea1
Migrate remainder of app to type-safe navigation
...
Change-Id: I02a8efb46695b3a90701966bfea4ed76aeec131b
8 months ago
930e061611
Cleanup dependencies
...
This is a followup cleanup of #1163 that was partially addressed by #1140 .
- Remove unused `projects.core.testing` dependencies (or replace with direct dependencies).
- Introduce `androidx.compose.ui.test` bundle.
- Remove `NiaTestRunner` from the default config, forcing consumers to depend on it, even when not used.
9 months ago
0584f191bc
Merge pull request #1271 from android/dt/remove-feature-dep
...
Remove the search module's dependency on other feature modules
10 months ago
78c77737c0
Merge pull request #1275 from Jaehwa-Noh/rename-function
...
Rename function to setNewsResourceBookmarked
10 months ago
a4c52e6485
Remove the search module's dependency on other feature modules
...
Change-Id: I17df9948fed04ddc7ba507b437d39536b8b180bb
10 months ago
a5025390af
Add title to READMEs to describe the dependency graph
...
Change-Id: Ifb4b44e67df53ddd8ed048122c6c12a904e61528
10 months ago
ee4320723f
Fix typo.
...
Change-Id: Id3aed2e3c54660fbbb42bc0c08dea68de0d5230f
10 months ago
ed91723e2f
Fix #1270
...
Change-Id: Id9774ad300b04c17cb1d7668c1ab1bac014bf70c
10 months ago
80a82de945
Update module dependency graphs and add script to create them
...
Change-Id: I7b2ae264ec84491c847a44869934e2f238564c31
10 months ago
e3c7018124
Extract ScreenshotHelper to separate testing module
...
Change-Id: Icf98a4acc9963656530a1a9fc8b156a553a070af
10 months ago
db5e2b649e
Remove unnecessary Boxes
...
Change-Id: Ia404cde7f6b555234bef4b27058fabd4471ea3c6
10 months ago
27fd4e544a
🤖 Updates screenshots
10 months ago
02d4fea615
🤖 Updates screenshots
10 months ago
81a5c0a3a7
🤖 Updates screenshots
10 months ago
9e645356f6
🤖 Updates screenshots
10 months ago
2271d01da5
Fix spotless
...
Change-Id: I8d19c437fc6e2e2198af5ac871c3f7813d280923
10 months ago
b1d867f827
Replace BoxWithConstraints with Box (fixes linter error)
...
Change-Id: Iea0401e28ae0e884511800652fde0f1896642aa0
10 months ago
6b2b01ed82
🤖 Updates screenshots
10 months ago
f64f1c0aa2
Remove legacy benchmark build type ( #1207 )
...
* Remove legacy benchmark build type
Now that we have the baseline profile gradle plugin,
there is no need for a benchmark build type.
The plugin does the setup and configuration and runs against the
correct app flavor.
* Remove explicit benchmark build type from benchmark module
* Remove stale build task exclusions
* Fix tracing import location
FYI @mlykotom
11 months ago
d9aaec0699
Use androidx.tracing everywhere
...
Change-Id: I847827efc08f5cbc00f0c809ad992c267f826e50
11 months ago
3ff5d48f37
Restores screenshot tests in foryou ( #1199 )
11 months ago
707117a4f2
Merge branch 'main' into kotlinify
1 year ago
0f0511748e
Merge pull request #1088 from SimonMarquis/cleanup-dependencies
...
Reduce overall build complexity
1 year ago
89d39a7242
Merge pull request #767 from SimonMarquis/resource-prefix
...
Enforce `resourcePrefix` on Android library modules
1 year ago
65f0d5b2d9
Update feature/foryou/src/main/kotlin/com/google/samples/apps/nowinandroid/feature/foryou/navigation/ForYouNavigation.kt
1 year ago
9d41ffa318
Merge branch 'main' into kotlinify
1 year ago
b6d82e24df
Merge branch 'main' into kotlinify
1 year ago
2a2d8ed88d
Change the name of FOR_YOU_NAVIGATION_ROUTE to FOR_YOU_ROUTE
1 year ago
32e1ec0447
Remove violations: property-naming
1 year ago
f8f932705a
Remove violations: discouraged-comment-location
1 year ago
f27a2e176e
Reduce overall build complexity
...
- Reduce the visibility of multiple Hilt `Module`s and implementations of public interfaces
- Correctly configure the visibility of dependencies:
- `api` when it's part of it's public `api`
- `implementation` when it's part of it's internal `implementation`
- Remove unnecessary dependencies in build.gradle.kts files
- Remove unnecessary dependencies provided by plugins
- Remove unnecessary applied plugins (i.e. roborazzi)
- Sort dependencies in `build.gradle.kts`
- Delete unused entries in `libs.versions.toml`
1 year ago
caa482bc71
Kotlinify codebase
...
- Remove unnecessary nullable types
- Replace no-op method bodies with Unit
- Convert to expression body
- Replace if with when
- Remove braces from 'when' entries
- Remove braces from if statement
- Convert to single line lambda
- oneline if/returns
- Replace 'contains' call with 'in' operator
Following this refactor, it could be great to envision a more "strict" code formatter like ktlint 1.0 (we are currently stuck at 0.48.1)
1 year ago
988002e692
Update Robolectric 4.11.1
...
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11
- https://github.com/robolectric/robolectric/releases/tag/robolectric-4.11.1
> Robolectric 4.11 adds support for Android SDK 34 (U). It also contains many bug fixes, performance improvements, and Shadow API enhancements. Robolectric 4.11 removes support for Android SDKs 18 and below.
Removing explicit API 33 Robolectric configuration.
1 year ago
0287af8d9a
Merge pull request #947 from android/tj/staggered-grid-feed
...
Use lazy vertical staggered grid in feed to maximize space utilization
1 year ago
yongsuk44
Don Turner
Simon Marquis
Alex Vanyo
dturner
Jaehwa Noh
Ben Weiss
Tomáš Mlynarič
Jose Alcérreca
lihenggui
Adetunji Dahunsi